You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/03 17:43:39 UTC
[GitHub] haojin2 commented on a change in pull request #12016: [MXNET-774]
Flaky test in test_executor.py:test_bind
haojin2 commented on a change in pull request #12016: [MXNET-774] Flaky test in test_executor.py:test_bind
URL: https://github.com/apache/incubator-mxnet/pull/12016#discussion_r207618194
##########
File path: tests/python/unittest/test_executor.py
##########
@@ -72,7 +72,9 @@ def check_bind_with_uniform(uf, gf, dim, sf=None, lshape=None, rshape=None):
assert_almost_equal(rhs_grad.asnumpy(), rhs_grad2, rtol=1e-5, atol=1e-5)
-@with_seed(0)
+# @roywei: Removing fixed seed as flakiness in this test is fixed
+# tracked at: https://github.com/apache/incubator-mxnet/issues/11685
Review comment:
Feel free to remove those comments and simply link the issue in description of PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services