You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ra...@apache.org on 2008/12/23 07:27:54 UTC
svn commit: r728882 - in /commons/proper/digester/trunk: RELEASE-NOTES.txt
src/java/org/apache/commons/digester/FactoryCreateRule.java
Author: rahul
Date: Mon Dec 22 22:27:54 2008
New Revision: 728882
URL: http://svn.apache.org/viewvc?rev=728882&view=rev
Log:
ObjectCreationFactory#createObject() retuning null, NPE when log debug is enabled.
DIGESTER-126
Modified:
commons/proper/digester/trunk/RELEASE-NOTES.txt
commons/proper/digester/trunk/src/java/org/apache/commons/digester/FactoryCreateRule.java
Modified: commons/proper/digester/trunk/RELEASE-NOTES.txt
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/RELEASE-NOTES.txt?rev=728882&r1=728881&r2=728882&view=diff
==============================================================================
--- commons/proper/digester/trunk/RELEASE-NOTES.txt (original)
+++ commons/proper/digester/trunk/RELEASE-NOTES.txt Mon Dec 22 22:27:54 2008
@@ -56,6 +56,9 @@
* [DIGESTER-122] Potential NullPointerException if debug is enabled in
Digester#resolveEntity()
+ * [DIGESTER-126] Potential NullPointerException if debug is enabled in
+ FactoryCreateRule#begin()
+
DEPRECATIONS
============
None
Modified: commons/proper/digester/trunk/src/java/org/apache/commons/digester/FactoryCreateRule.java
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/src/java/org/apache/commons/digester/FactoryCreateRule.java?rev=728882&r1=728881&r2=728882&view=diff
==============================================================================
--- commons/proper/digester/trunk/src/java/org/apache/commons/digester/FactoryCreateRule.java (original)
+++ commons/proper/digester/trunk/src/java/org/apache/commons/digester/FactoryCreateRule.java Mon Dec 22 22:27:54 2008
@@ -369,7 +369,8 @@
if (digester.log.isDebugEnabled()) {
digester.log.debug("[FactoryCreateRule]{" + digester.match +
- "} New " + instance.getClass().getName());
+ "} New " + (instance == null ? "null object" :
+ instance.getClass().getName()));
}
digester.push(instance);
exceptionIgnoredStack.push(Boolean.FALSE);
@@ -391,7 +392,8 @@
if (digester.log.isDebugEnabled()) {
digester.log.debug("[FactoryCreateRule]{" + digester.match +
- "} New " + instance.getClass().getName());
+ "} New " + (instance == null ? "null object" :
+ instance.getClass().getName()));
}
digester.push(instance);
}