[GitHub] [incubator-nuttx] patacongo commented on pull request #4571: Correct a few license headers under net/

[GitBox <gi...@apache.org>]

patacongo commented on pull request #4571:
URL: https://github.com/apache/incubator-nuttx/pull/4571#issuecomment-922171561


   Here is how I would see the rest of this working out.  uIP 1.0 consists only of IPv4, ARP, TCP, and glue logic.
   
       * IPv4.  This is scattered throughout the code.  There is no real discussion for this.
       * ARP.  uIP 1.0 had a very buggy ARP implementation.  For example, it would drop outgoing packets if the MAC address was not already in the ARP table, sending an ARP request instead.  Because of this I completely redesigned and re=implemented ARP.  I don't think there is anything from uIP 1.0 in NuttX except for, perhaps, the ARP table access routines.  I would have to look at that to be certain.
       * TCP.  The uIP 1.0 TCP was also largely re-implemented, but I am not certain of the extent.  I suspect that there may still be some traces of the uIP 1.0 TCP state machine (tcp_input.c) but  most likely, that is the only uIP 1.0 TCP logic left.
       * UDP.  UDP was expermental and incomplete in uIP 1.0.  UDP has been completely re-implemented and should not have any relation to UDP in uIP 1.0.  That needs to be verified.
       * Since the execution environments are so different, I don't there should be any licensing dependencies between the two code bases for the "glue logic".  By glue logic, it is meant the socket layer and and the network device interface.  NuttX has true BSD sockets and true network device drivers which have no counterpart in uIP 1.0.
   
   One other thing, parts of the 6LoWPAN implementation came from  Contiki and also have attributions to Adam Dunkels.  These specific files should have the headers reverted and should be treated as third party files.
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org