You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by PaulElschot <gi...@git.apache.org> on 2014/06/29 12:05:45 UTC

[GitHub] lucene-solr pull request: efbytesref as of 20140629

GitHub user PaulElschot opened a pull request:

    https://github.com/apache/lucene-solr/pull/60

    efbytesref as of 20140629

    LUCENE-5524
    
    This closes #50
    
    Update to recent trunk.
    Implement Accountable in EliasFanoDocIdSet.
    
    There is one nocommit for the test of Accountable.ramBytesUsed on EliasFanoDocIdSet: disabled the test inherited from BaseDocIdSetTestCase because it fails even though there is a reasonable implementation.
    The question is how to make this test pass: reimplement it to fit the implementation of Accountable in EliasFanoDocIdSet, or improve the implementation in EliasFanoDocIdSet. I'm probably overlooking something here.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PaulElschot/lucene-solr efbytesref-201406a

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucene-solr/pull/60.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #60
    
----
commit 5ef98c1a655d9b79a01f8ffc884676076dbbec47
Author: Paul Elschot <pa...@gmail.com>
Date:   2014-06-29T09:40:04Z

    efbytesref as of 20140629

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[GitHub] lucene-solr pull request #60: SOLR-9002: Patch against latest master

Posted by arafalov <gi...@git.apache.org>.
Github user arafalov closed the pull request at:

    https://github.com/apache/lucene-solr/pull/60


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[GitHub] lucene-solr pull request: efbytesref as of 20140629

Posted by PaulElschot <gi...@git.apache.org>.
Github user PaulElschot closed the pull request at:

    https://github.com/apache/lucene-solr/pull/60


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[GitHub] lucene-solr pull request: efbytesref as of 20140629

Posted by PaulElschot <gi...@git.apache.org>.
Github user PaulElschot commented on the pull request:

    https://github.com/apache/lucene-solr/pull/60#issuecomment-105225303
  
    See LUCENE-5524 and LUCENE-5627


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org