[GitHub] [superset] michael-s-molina commented on a change in pull request #16637: fix: Apply custom label colors in the Dashboard immediately

[GitBox <gi...@apache.org>]

michael-s-molina commented on a change in pull request #16637:
URL: https://github.com/apache/superset/pull/16637#discussion_r727464087



##########
File path: superset-frontend/src/dashboard/containers/Chart.jsx
##########
@@ -75,13 +76,15 @@ function mapStateToProps(
     sliceId: id,
     nativeFilters,
     dataMask,
+    labelColors,
   });
 
   formData.dashboardId = dashboardInfo.id;
 
   return {
     chart,
     datasource,
+    labelColors: labelColors && Object.keys(labelColors).length && labelColors,

Review comment:
       If `labelColors` is an empty object, the resulting value for `labelColors` will be `false` instead of an empty object. Is that expected?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org