[GitHub] [cloudstack] s-seitz edited a comment on pull request #5506: kvm: Use lscpu to get cpu max speed

[GitBox <gi...@apache.org>]

s-seitz edited a comment on pull request #5506:
URL: https://github.com/apache/cloudstack/pull/5506#issuecomment-968060679


   As @weizhouapache mentioned earlier ("lscpu > nodeInfo.mhz (libvirt-java) -> /proc/cpuinfo > cpuinfo_max_freq"), I'ld suggest to outsource the whole logic into a script (at a tbd .../scripts/ .../scriptlets/-folder) to ensure ENV's are set correctly. Keep in mind "lscpu" is usually localized, so at least PATH and LC_ALL are necessary. In my opinion, having a script with defined return-values in place, would also make testing and debugging a lot easier. (Not to mention, the possibility of patching without the need of forking and recompiling cloudstack, maybe if your kvm  runs on arm64?)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org