You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/13 09:32:41 UTC

[GitHub] [flink] lsyldliu commented on a diff in pull request #19860: [FLINK-27658][table] FlinkUserCodeClassLoader expose addURL method to allow to register jar dynamically

lsyldliu commented on code in PR #19860:
URL: https://github.com/apache/flink/pull/19860#discussion_r895518287


##########
flink-core/src/main/java/org/apache/flink/util/FlinkUserCodeClassLoader.java:
##########
@@ -67,4 +67,9 @@ protected Class<?> loadClassWithoutExceptionHandling(String name, boolean resolv
             throws ClassNotFoundException {
         return super.loadClass(name, resolve);
     }
+
+    @Override
+    public void addURL(URL url) {

Review Comment:
   This method is called by SafetyNetWrapperClassLoader, so we need it. but we can change public to protected



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org