[GitHub] [maven-release] slawekjaranowski commented on a diff in pull request #197: [MRELEASE-1134] Pass interactive flag to SCM provider

["slawekjaranowski (via GitHub)" <gi...@apache.org>]

slawekjaranowski commented on code in PR #197:
URL: https://github.com/apache/maven-release/pull/197#discussion_r1269311298


##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/scm/DefaultScmRepositoryConfigurator.java:
##########
@@ -164,7 +164,9 @@ public ScmRepository getConfiguredRepository(String url, ReleaseDescriptor relea
                 svnRepo.setBranchBase(branchBase);
             }
         }
-
+        if (!releaseDescriptor.isInteractive()) {

Review Comment:
   Do we need such condition?
   Maybe simply set  - what is default value in scm provider?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org