You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/12/08 13:49:22 UTC
[GitHub] [druid] huyuanfeng2018 opened a new pull request #12042: Introduce query/long/count metric and add long query identifier to request log
huyuanfeng2018 opened a new pull request #12042:
URL: https://github.com/apache/druid/pull/12042
### Description
When we use druid for various query operations, there may be some query requests that take a long time. These query requests may be some bad query requests. If there are many such requests, it will cause a lot of pressure on druid, so we hope A metric can be added to count the number of occurrences of these query requests, and to mark these requests in the request log. So that we can analyze these queries and can make it a little easier for cluster operators to diagnose query issues better.
This PR adds a new query metric query/long/count that represents the number of long queries during the emission period and request logging will mark if this request is a long query request
This PR has:
- [x] been self-reviewed.
- [x] added documentation for new or modified features or behaviors.
- [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 commented on pull request #12042: Introduce query/long/count metric and add long query identifier to request log
Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 commented on pull request #12042:
URL: https://github.com/apache/druid/pull/12042#issuecomment-988879077
identifying what queries are taking longer can and should be done in the system, druid is emitting metrics to. That will be much more flexible than configuring a threshold in druid services and changing such a threshold will require a restart.
Druid should already be emitting query-id along with the time. In the metric store that you are using, you can filter the query ids based on the time taken and then find the actual queries in the logs corresponding to those ids. does that not work for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] huyuanfeng2018 closed pull request #12042: Introduce query/long/count metric and add long query identifier to request log
Posted by GitBox <gi...@apache.org>.
huyuanfeng2018 closed pull request #12042:
URL: https://github.com/apache/druid/pull/12042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] huyuanfeng2018 commented on pull request #12042: Introduce query/long/count metric and add long query identifier to request log
Posted by GitBox <gi...@apache.org>.
huyuanfeng2018 commented on pull request #12042:
URL: https://github.com/apache/druid/pull/12042#issuecomment-989379860
> identifying what queries are taking longer can and should be done in the system, druid is emitting metrics to. That will be much more flexible than configuring a threshold in druid services and changing such a threshold will require a restart.
>
> Druid should already be emitting query-id along with the time. In the metric store that you are using, you can filter the query ids based on the time taken and then find the actual queries in the logs corresponding to those ids. does that not work for you?
Of course it works! But I want to count the number and proportion of these longquery occurrences in druid, which is reflected in the metric, so that I can quickly judge the number of long queries that take a long time through the metric information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org