You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@allura.apache.org by Dave Brondsema <da...@brondsema.net> on 2012/08/15 17:41:45 UTC
Licensing of contributions
I would like to merge
https://sourceforge.net/p/allura/git/merge-requests/6/ a contribution
from Hendrik Brummermann, but am not sure how we should handle licensing.
I understand that other projects that take patches via JIRA have a
checkbox when the patch is attached. "Grant license to ASF for
inclusion in ASF works (as per the Apache License §5)"
Should we just capture the same approval on the Allura merge request or
ticket? For now it'd have to be a regular comment, but we could make it
a special field eventually.
In the past, our few contributors have signified that they have rights
to the code and that they wish to share it under the terms of the Apache
License Version 2.0 by using "git commit --signoff" This has been a bit
of a pain since sometimes we'd have to ask folks to redo their commits
with the sign-off. Also IMO the sign-off doesn't clearly denote its
meaning.
--
Dave Brondsema : dave@brondsema.net
http://www.brondsema.net : personal
http://www.splike.com : programming
<><
Re: Licensing of contributions
Posted by Greg Stein <gs...@gmail.com>.
Yes I do, have it starred already, and will get to it after returning from
vacation tmw.
On Aug 17, 2012 8:56 AM, "Dave Brondsema" <da...@brondsema.net> wrote:
> Does one of our mentors (Ross, Greg, Jim, Rich) know how we should
> handle this? Or should I ask more broadly like on the incubator general
> list?
>
> I am excited to have contributions, so want to figure this out :)
>
> -Dave
>
> On 8/15/12 11:41 AM, Dave Brondsema wrote:
> > I would like to merge
> > https://sourceforge.net/p/allura/git/merge-requests/6/ a contribution
> > from Hendrik Brummermann, but am not sure how we should handle licensing.
> >
> > I understand that other projects that take patches via JIRA have a
> > checkbox when the patch is attached. "Grant license to ASF for
> > inclusion in ASF works (as per the Apache License §5)"
> >
> > Should we just capture the same approval on the Allura merge request or
> > ticket? For now it'd have to be a regular comment, but we could make it
> > a special field eventually.
> >
> > In the past, our few contributors have signified that they have rights
> > to the code and that they wish to share it under the terms of the Apache
> > License Version 2.0 by using "git commit --signoff" This has been a bit
> > of a pain since sometimes we'd have to ask folks to redo their commits
> > with the sign-off. Also IMO the sign-off doesn't clearly denote its
> > meaning.
> >
>
>
>
> --
> Dave Brondsema : dave@brondsema.net
> http://www.brondsema.net : personal
> http://www.splike.com : programming
> <><
>
Re: Licensing of contributions
Posted by Ross Gardler <rg...@opendirective.com>.
I wouldn't go to incubator general at this stage. That list tends to have
many conflicting opinions on issues like this. I'd have to review the
archives of legal-discuss@ to be sure but I think the tick box is
considered superfluous.
Legal-discuss@ is a public list. I'm on mobile for a few days so unlikely
to review them myself. However, a search for "jira checklist" might turn
something up. I'm sure one of the other mentors will be able to give a more
direct response though.
>From a mobile device - forgive errors and terseness
On Aug 17, 2012 3:40 PM, "Rich Bowen" <rb...@rcbowen.com> wrote:
>
> On Aug 17, 2012, at 9:55 AM, Dave Brondsema wrote:
>
> > Does one of our mentors (Ross, Greg, Jim, Rich) know how we should
> > handle this? Or should I ask more broadly like on the incubator general
> > list?
>
>
> I don't. It might indeed be a good question for Incubator General, as no
> doubt other projects have that question too.
>
> --
> Rich Bowen
> rbowen@rcbowen.com
> Shosholoza
>
>
>
Re: Licensing of contributions
Posted by Rich Bowen <rb...@rcbowen.com>.
On Aug 17, 2012, at 9:55 AM, Dave Brondsema wrote:
> Does one of our mentors (Ross, Greg, Jim, Rich) know how we should
> handle this? Or should I ask more broadly like on the incubator general
> list?
I don't. It might indeed be a good question for Incubator General, as no doubt other projects have that question too.
--
Rich Bowen
rbowen@rcbowen.com
Shosholoza
Re: Licensing of contributions
Posted by Dave Brondsema <da...@brondsema.net>.
Does one of our mentors (Ross, Greg, Jim, Rich) know how we should
handle this? Or should I ask more broadly like on the incubator general
list?
I am excited to have contributions, so want to figure this out :)
-Dave
On 8/15/12 11:41 AM, Dave Brondsema wrote:
> I would like to merge
> https://sourceforge.net/p/allura/git/merge-requests/6/ a contribution
> from Hendrik Brummermann, but am not sure how we should handle licensing.
>
> I understand that other projects that take patches via JIRA have a
> checkbox when the patch is attached. "Grant license to ASF for
> inclusion in ASF works (as per the Apache License §5)"
>
> Should we just capture the same approval on the Allura merge request or
> ticket? For now it'd have to be a regular comment, but we could make it
> a special field eventually.
>
> In the past, our few contributors have signified that they have rights
> to the code and that they wish to share it under the terms of the Apache
> License Version 2.0 by using "git commit --signoff" This has been a bit
> of a pain since sometimes we'd have to ask folks to redo their commits
> with the sign-off. Also IMO the sign-off doesn't clearly denote its
> meaning.
>
--
Dave Brondsema : dave@brondsema.net
http://www.brondsema.net : personal
http://www.splike.com : programming
<><
Re: Licensing of contributions
Posted by Dave Brondsema <da...@brondsema.net>.
On 8/20/12 2:44 PM, Greg Stein wrote:
> Hey Dave,
>
>
> On Wed, Aug 15, 2012 at 11:41 AM, Dave Brondsema <da...@brondsema.net> wrote:
>> I would like to merge
>> https://sourceforge.net/p/allura/git/merge-requests/6/ a contribution
>> from Hendrik Brummermann, but am not sure how we should handle licensing.
>
> Section 5 of the Apache License covers such contributions. Just apply the patch.
>
Excellent. I love it when the process is no process :) Thanks for the
explanations and examples.
--
Dave Brondsema : dave@brondsema.net
http://www.brondsema.net : personal
http://www.splike.com : programming
<><
Re: Licensing of contributions
Posted by Greg Stein <gs...@gmail.com>.
Hey Dave,
On Wed, Aug 15, 2012 at 11:41 AM, Dave Brondsema <da...@brondsema.net> wrote:
> I would like to merge
> https://sourceforge.net/p/allura/git/merge-requests/6/ a contribution
> from Hendrik Brummermann, but am not sure how we should handle licensing.
Section 5 of the Apache License covers such contributions. Just apply the patch.
Beyond the text of license, there is also demonstrated *intent* for
the patch to be applied. Hendrik knows he is contributing to a work
under the ALv2. On the weird chance that he comes back and says
"that's not what I meant"... well, we'd just revert the patch. But
it's not gonna happen. Some third party can't raise a claim that we
improperly included his Contribution, given the license and the
intent.
> I understand that other projects that take patches via JIRA have a
> checkbox when the patch is attached. "Grant license to ASF for
> inclusion in ASF works (as per the Apache License §5)"
There isn't a strong need for that checkbox in Jira (and it is
in-process on being removed).
> Should we just capture the same approval on the Allura merge request or
> ticket? For now it'd have to be a regular comment, but we could make it
> a special field eventually.
Nope. Just pull the commits into the repo. Given the use of Git, we
can track the author of the patch, separate from the person who
incorporated the change into the project repository (soon to be moved
to the ASF, right?).
In Apache Subversion, we apply patches regularly, and have a standard
item in our log message to say who provided it:
Patch by: Joe Developer <somewhere{_AT_}example.com>
That gives appropriate credit to the developer, and provides
historical tracking of where the code came from.
If the git records don't have enough, or you're applying the patch
(from the ticket) manually, then I would very much recommend attaching
something like the above to the commit/log message.
> In the past, our few contributors have signified that they have rights
> to the code and that they wish to share it under the terms of the Apache
> License Version 2.0 by using "git commit --signoff" This has been a bit
> of a pain since sometimes we'd have to ask folks to redo their commits
> with the sign-off. Also IMO the sign-off doesn't clearly denote its
> meaning.
The ICLA covers this. For the random patches supplied by people who do
NOT have an ICLA, then we refer to §5 and intent.
Note: for "large" contributions, it is best to get the developer to
sign an ICLA. That would cover the contribution, and all future
contributions. If there is no expectation of future contributions,
then a software grant would be fine.
Cheers,
-g
Re: Licensing of contributions
Posted by Peter Hartmann <ma...@gmail.com>.
On 15.08.2012 17:41, Dave Brondsema wrote:
> I would like to merge
> https://sourceforge.net/p/allura/git/merge-requests/6/ a contribution
> from Hendrik Brummermann, but am not sure how we should handle licensing.
>
> I understand that other projects that take patches via JIRA have a
> checkbox when the patch is attached. "Grant license to ASF for
> inclusion in ASF works (as per the Apache License §5)"
>
> Should we just capture the same approval on the Allura merge request or
> ticket? For now it'd have to be a regular comment, but we could make it
> a special field eventually.
>
> In the past, our few contributors have signified that they have rights
> to the code and that they wish to share it under the terms of the Apache
> License Version 2.0 by using "git commit --signoff" This has been a bit
> of a pain since sometimes we'd have to ask folks to redo their commits
> with the sign-off. Also IMO the sign-off doesn't clearly denote its
> meaning.
Glad you've mentioned this now, when I only have one commit to redo ;)
As far as I know, current docs on contributing only tackle licensing by
mentioning that merge requests should indicate (i.e. in a comment) both
ownership of code itself and willingness to publish it under Apache Licence.