You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Sailesh Mukil (Code Review)" <ge...@cloudera.org> on 2016/11/02 06:53:36 UTC
[Impala-ASF-CR] IMPALA-4412: Per operator timing in profile summary is incorrect when mt dop > 0
Sailesh Mukil has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4913
Change subject: IMPALA-4412: Per operator timing in profile summary is incorrect when mt_dop > 0
......................................................................
IMPALA-4412: Per operator timing in profile summary is incorrect when mt_dop > 0
With mt_dop > 0, we may incorrectly populate the
per_fragment_instance_idx for each FInstanceExecParams in
SimpleScheduler::CreateScanInstances().
This causes the averages in the exec summary to be wrong resulting in
misleading Runtime Profiles.
This patch makes sure that each FInstanceExecParams has the correct
instance index associated with it, thereby fixing the exec summaries
in the runtime profiles.
Change-Id: Id24435829da6626f41930a77c0c4104b2bb7a236
---
M be/src/scheduling/simple-scheduler.cc
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/4913/1
--
To view, visit http://gerrit.cloudera.org:8080/4913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id24435829da6626f41930a77c0c4104b2bb7a236
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-4412: Per operator timing in profile summary is incorrect when mt dop > 0
Posted by "Marcel Kornacker (Code Review)" <ge...@cloudera.org>.
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4412: Per operator timing in profile summary is incorrect when mt_dop > 0
......................................................................
Patch Set 1: Code-Review+2
as discussed, please do the unittest as a follow-up.
--
To view, visit http://gerrit.cloudera.org:8080/4913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id24435829da6626f41930a77c0c4104b2bb7a236
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4412: Per operator timing in profile summary is incorrect when mt dop > 0
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-4412: Per operator timing in profile summary is incorrect when mt_dop > 0
......................................................................
Patch Set 2: Code-Review+2
Carry +2.
--
To view, visit http://gerrit.cloudera.org:8080/4913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id24435829da6626f41930a77c0c4104b2bb7a236
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4412: Per operator timing in profile summary is incorrect when mt dop > 0
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has abandoned this change.
Change subject: IMPALA-4412: Per operator timing in profile summary is incorrect when mt_dop > 0
......................................................................
Abandoned
Messed up change-id's. New patch at:
https://gerrit.cloudera.org/#/c/4933/
--
To view, visit http://gerrit.cloudera.org:8080/4913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: Id24435829da6626f41930a77c0c4104b2bb7a236
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-4412: Per operator timing in profile summary is incorrect when mt dop > 0
Posted by "Marcel Kornacker (Code Review)" <ge...@cloudera.org>.
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4412: Per operator timing in profile summary is incorrect when mt_dop > 0
......................................................................
Patch Set 1:
could you also create a repro for this in our scheduler unittests?
you can do this in a follow-on patch if you want. if this ends up being a lot of work, please just file a jira.
--
To view, visit http://gerrit.cloudera.org:8080/4913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id24435829da6626f41930a77c0c4104b2bb7a236
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: No