You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@turbine.apache.org by Eric Pugh <ep...@opensourceconnections.com> on 2004/11/12 12:49:26 UTC
Updated Turbine 3 to use Fulcrum Avalon Components
Hi all,
I wanted to give you all a heads up before I start committing things. I
have done some *massive* refactoring of Turbine 3 that has directly impacted
Scarab:
1) Moved the fulcrum-yaafi container into Turbine 3. Turbine 3 now expects,
and indeed requires, Yaafi to function.
2) Moved the following services from the old Fulcrum to the new Avalon based
Fulcrum Components:
a) Localization
b) Pool
c) Factory
d) MimeType
e) Parser
f) Upload
This change, especially changing to the Fulcrum Parser component, led to
lots of issues with the imports throughout Scarab. Lots of action classes
were updated to handle the new imports.
3) Removed all facade class usage. Facade classes that don't add anything
don't help when using an IoC container. They just make it harder to swap in
another implementation. I've wiped them out of all the Fulcrum components,
which means a lot of updates throughout Turbine and Scarab codebase.
4) Refactored the ConfigureReport and Search actions. They had tons of
looking up basic tools like the ScarabRequestTool or ScarabLocationTool. I
was able to refactor that all out into a generic setup(data,context) method
called by all the doAction style methods. I think this is a good pattern to
use on other action classes.
5) Moved remaining non Fulcrum code out of branch "PRE_AVALON_BRANCH" and
moved them directly into the jakarta-turbine-3 source tree:
a) Security
b) Intake
c) Template
d) Velocity
e) Basic Old Fulcrum Service structure
6) Cleaned out all the moved over fulcrum code from Scarab.
7) Removed the old org.tigris.services.yaafi in favor of new
org.apache.turbine.services.yaafi
This has been about 3 days of work, including some real false starts..
However, I think this really helps get us closer to the goal of moving to
Turbine 2.4, as many of the services being used by Scarab on Turbine 3 are
shared by Turbine 2.4. And, no longer requiring a weird branch of Fulcrum
to work with Turbine 3 makes me more confortable for testing and supporting
Scarab.
I've committed the code changes to Turbine 3. If no one sees a reason not
to commit this code, I'd like to do it later today.
Everything *seems* to be running nicely, but we may run into issues as the
changes get more of a workout by different folks.
Eric
---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
RE: Updated Turbine 3 to use Fulcrum Avalon Components
Posted by Daniel Rall <dl...@collab.net>.
Eric, this is definitely possible. Check out a working copy of jakarta-
turbine-3 from CVS by date, then tag the working copy. The tag will
affect the versions from your working copy, which will give it the
desired state.
On Sun, 2004-11-14 at 20:36 +0000, Eric Pugh wrote:
> Crud.. You know, I thought about that after I committed.. I've somewhat
> taken the "I'm hellbent on moving Scarab to T2.4 and I'm ripping up Turbine
> 3 to let me do it" approach. Which maybe isn't customer friendly enough of
> me...
>
> I believe it's possible to go and add a tag based on date, correct? Do you
> think it's worth adding a "PRE_ADD_AVALON_HEAD" tag to T3 that is based on
> the day before I committed all the new code?
>
> Eric
>
> > -----Original Message-----
> > From: Henning P. Schmiedehausen [mailto:hps@intermeta.de]
> > Sent: Sunday, November 14, 2004 7:28 PM
> > To: turbine-dev@jakarta.apache.org
> > Subject: Re: Updated Turbine 3 to use Fulcrum Avalon Components
> >
> >
> > "Eric Pugh" <ep...@opensourceconnections.com> writes:
> >
> > >Hi all,
> >
> > >I wanted to give you all a heads up before I start committing things. I
> > >have done some *massive* refactoring of Turbine 3 that has
> > directly impacted
> > >Scarab:
> >
> > While I'm not using Turbine 3, I'd suggest that you tag the
> > current state before putting in your changes to allow people
> > whose apps break, to compare the
> > pre-refactoring to the HEAD.
> >
> > Regards
> > Henning
> >
> > --
> > Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
> > hps@intermeta.de +49 9131 50 654 0 http://www.intermeta.de/
> >
> > RedHat Certified Engineer -- Jakarta Turbine Development -- hero for hire
> > Linux, Java, perl, Solaris -- Consulting, Training, Development
> >
> > What is more important to you...
> > [ ] Product Security
> > or [ ] Quality of Sales and Marketing Support
> > -- actual question from a Microsoft customer survey
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
RE: Updated Turbine 3 to use Fulcrum Avalon Components
Posted by Eric Pugh <ep...@upstate.com>.
Crud.. You know, I thought about that after I committed.. I've somewhat
taken the "I'm hellbent on moving Scarab to T2.4 and I'm ripping up Turbine
3 to let me do it" approach. Which maybe isn't customer friendly enough of
me...
I believe it's possible to go and add a tag based on date, correct? Do you
think it's worth adding a "PRE_ADD_AVALON_HEAD" tag to T3 that is based on
the day before I committed all the new code?
Eric
> -----Original Message-----
> From: Henning P. Schmiedehausen [mailto:hps@intermeta.de]
> Sent: Sunday, November 14, 2004 7:28 PM
> To: turbine-dev@jakarta.apache.org
> Subject: Re: Updated Turbine 3 to use Fulcrum Avalon Components
>
>
> "Eric Pugh" <ep...@opensourceconnections.com> writes:
>
> >Hi all,
>
> >I wanted to give you all a heads up before I start committing things. I
> >have done some *massive* refactoring of Turbine 3 that has
> directly impacted
> >Scarab:
>
> While I'm not using Turbine 3, I'd suggest that you tag the
> current state before putting in your changes to allow people
> whose apps break, to compare the
> pre-refactoring to the HEAD.
>
> Regards
> Henning
>
> --
> Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
> hps@intermeta.de +49 9131 50 654 0 http://www.intermeta.de/
>
> RedHat Certified Engineer -- Jakarta Turbine Development -- hero for hire
> Linux, Java, perl, Solaris -- Consulting, Training, Development
>
> What is more important to you...
> [ ] Product Security
> or [ ] Quality of Sales and Marketing Support
> -- actual question from a Microsoft customer survey
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
Re: Updated Turbine 3 to use Fulcrum Avalon Components
Posted by "Henning P. Schmiedehausen" <hp...@intermeta.de>.
"Eric Pugh" <ep...@opensourceconnections.com> writes:
>Hi all,
>I wanted to give you all a heads up before I start committing things. I
>have done some *massive* refactoring of Turbine 3 that has directly impacted
>Scarab:
While I'm not using Turbine 3, I'd suggest that you tag the current state before putting in your changes to allow people whose apps break, to compare the
pre-refactoring to the HEAD.
Regards
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
hps@intermeta.de +49 9131 50 654 0 http://www.intermeta.de/
RedHat Certified Engineer -- Jakarta Turbine Development -- hero for hire
Linux, Java, perl, Solaris -- Consulting, Training, Development
What is more important to you...
[ ] Product Security
or [ ] Quality of Sales and Marketing Support
-- actual question from a Microsoft customer survey
---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org