You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by hn...@apache.org on 2019/07/31 13:20:02 UTC
[myfaces-tobago] branch master updated (8bcf37d -> 620af8a)
This is an automated email from the ASF dual-hosted git repository.
hnoeth pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git.
from 8bcf37d TOBAGO-1633: TS refactoring: fix sheet sorting test
new e13b9b3 TOBAGO-1633: TS refactoring: replace deprecated event.initEvent()
new 620af8a TOBAGO-1633: TS refactoring: fix tests
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../080-sheet/10-sort/Sheet_Sorting.test.js | 80 +++++-----------------
.../080-sheet/30-event/Sheet_Event.test.js | 25 +++----
.../090-tree/01-select/Tree_Select.test.js | 20 ++----
.../content/40-test/6000-event/Event.test.js | 2 +-
4 files changed, 35 insertions(+), 92 deletions(-)
[myfaces-tobago] 01/02: TOBAGO-1633: TS refactoring: replace
deprecated event.initEvent()
Posted by hn...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
hnoeth pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git
commit e13b9b34e7da1cb314666ea81ba859c93b5679e3
Author: Henning Noeth <hn...@apache.org>
AuthorDate: Wed Jul 31 14:45:39 2019 +0200
TOBAGO-1633: TS refactoring: replace deprecated event.initEvent()
---
.../080-sheet/10-sort/Sheet_Sorting.test.js | 80 +++++-----------------
.../090-tree/01-select/Tree_Select.test.js | 20 ++----
2 files changed, 21 insertions(+), 79 deletions(-)
diff --git a/tobago-example/tobago-example-demo/src/main/webapp/content/20-component/080-sheet/10-sort/Sheet_Sorting.test.js b/tobago-example/tobago-example-demo/src/main/webapp/content/20-component/080-sheet/10-sort/Sheet_Sorting.test.js
index 58c9466..083dfd3 100644
--- a/tobago-example/tobago-example-demo/src/main/webapp/content/20-component/080-sheet/10-sort/Sheet_Sorting.test.js
+++ b/tobago-example/tobago-example-demo/src/main/webapp/content/20-component/080-sheet/10-sort/Sheet_Sorting.test.js
@@ -37,10 +37,7 @@ QUnit.test("Basics: Name", function (assert) {
});
TTT.action(function () {
leftPagingFn().value = "22";
-
- const event = document.createEvent('HTMLEvents');
- event.initEvent('blur', true, false);
- leftPagingFn().dispatchEvent(event);
+ leftPagingFn().dispatchEvent(new Event('blur'));
});
TTT.waitForResponse();
TTT.asserts(12, function () {
@@ -94,10 +91,7 @@ QUnit.test("Basics: Period", function (assert) {
});
TTT.action(function () {
leftPagingFn().value = "29";
-
- const event = document.createEvent('HTMLEvents');
- event.initEvent('blur', true, false);
- leftPagingFn().dispatchEvent(event);
+ leftPagingFn().dispatchEvent(new Event('blur'));
});
TTT.waitForResponse();
TTT.asserts(12, function () {
@@ -151,10 +145,7 @@ QUnit.test("Basics: Year", function (assert) {
});
TTT.action(function () {
leftPagingFn().value = "22";
-
- const event = document.createEvent('HTMLEvents');
- event.initEvent('blur', true, false);
- leftPagingFn().dispatchEvent(event);
+ leftPagingFn().dispatchEvent(new Event('blur'));
});
TTT.waitForResponse();
TTT.asserts(4, function () {
@@ -209,10 +200,7 @@ QUnit.test("Basics: left paging", function (assert) {
});
TTT.action(function () {
leftPagingFn().value = "8";
-
- const event = document.createEvent('HTMLEvents');
- event.initEvent('blur', true, false);
- leftPagingFn().dispatchEvent(event);
+ leftPagingFn().dispatchEvent(new Event('blur'));
});
TTT.waitForResponse();
TTT.asserts(12, function () {
@@ -224,10 +212,7 @@ QUnit.test("Basics: left paging", function (assert) {
});
TTT.action(function () {
leftPagingFn().value = "9";
-
- const event = document.createEvent('HTMLEvents');
- event.initEvent('blur', true, false);
- leftPagingFn().dispatchEvent(event);
+ leftPagingFn().dispatchEvent(new Event('blur'));
});
TTT.waitForResponse();
TTT.asserts(12, function () {
@@ -265,10 +250,7 @@ QUnit.test("Basics: center paging", function (assert) {
});
TTT.action(function () {
leftPagingFn().value = "1";
-
- const event = document.createEvent('HTMLEvents');
- event.initEvent('blur', true, false);
- leftPagingFn().dispatchEvent(event);
+ leftPagingFn().dispatchEvent(new Event('blur'));
});
TTT.waitForResponse();
TTT.asserts(12, function () {
@@ -342,10 +324,7 @@ QUnit.test("Basics: right paging", function (assert) {
});
TTT.action(function () {
leftPagingFn().value = "22";
-
- const event = document.createEvent('HTMLEvents');
- event.initEvent('blur', true, false);
- leftPagingFn().dispatchEvent(event);
+ leftPagingFn().dispatchEvent(new Event('blur'));
});
TTT.waitForResponse();
TTT.asserts(12, function () {
@@ -401,10 +380,7 @@ QUnit.test("Basics: right paging", function (assert) {
});
TTT.action(function () {
jumpToPageFn().value = "14";
-
- const event = document.createEvent('HTMLEvents');
- event.initEvent('blur', true, false);
- jumpToPageFn().dispatchEvent(event);
+ jumpToPageFn().dispatchEvent(new Event('blur'));
});
TTT.waitForResponse();
TTT.asserts(12, function () {
@@ -436,10 +412,7 @@ QUnit.test("Custom Sorting: Name", function (assert) {
});
TTT.action(function () {
leftPagingFn().value = "22";
-
- const event = document.createEvent('HTMLEvents');
- event.initEvent('blur', true, false);
- leftPagingFn().dispatchEvent(event);
+ leftPagingFn().dispatchEvent(new Event('blur'));
});
TTT.waitForResponse();
TTT.asserts(12, function () {
@@ -493,10 +466,7 @@ QUnit.test("Custom Sorting: Period", function (assert) {
});
TTT.action(function () {
leftPagingFn().value = "29";
-
- const event = document.createEvent('HTMLEvents');
- event.initEvent('blur', true, false);
- leftPagingFn().dispatchEvent(event);
+ leftPagingFn().dispatchEvent(new Event('blur'));
});
TTT.waitForResponse();
TTT.asserts(12, function () {
@@ -550,10 +520,7 @@ QUnit.test("Custom Sorting: Year", function (assert) {
});
TTT.action(function () {
leftPagingFn().value = "22";
-
- const event = document.createEvent('HTMLEvents');
- event.initEvent('blur', true, false);
- leftPagingFn().dispatchEvent(event);
+ leftPagingFn().dispatchEvent(new Event('blur'));
});
TTT.waitForResponse();
TTT.asserts(4, function () {
@@ -608,10 +575,7 @@ QUnit.test("Custom Sorting: left paging", function (assert) {
});
TTT.action(function () {
leftPagingFn().value = "8";
-
- const event = document.createEvent('HTMLEvents');
- event.initEvent('blur', true, false);
- leftPagingFn().dispatchEvent(event);
+ leftPagingFn().dispatchEvent(new Event('blur'));
});
TTT.waitForResponse();
TTT.asserts(12, function () {
@@ -623,10 +587,7 @@ QUnit.test("Custom Sorting: left paging", function (assert) {
});
TTT.action(function () {
leftPagingFn().value = "9";
-
- const event = document.createEvent('HTMLEvents');
- event.initEvent('blur', true, false);
- leftPagingFn().dispatchEvent(event);
+ leftPagingFn().dispatchEvent(new Event('blur'));
});
TTT.waitForResponse();
TTT.asserts(12, function () {
@@ -664,10 +625,7 @@ QUnit.test("Custom Sorting: center paging", function (assert) {
});
TTT.action(function () {
leftPagingFn().value = "1";
-
- const event = document.createEvent('HTMLEvents');
- event.initEvent('blur', true, false);
- leftPagingFn().dispatchEvent(event);
+ leftPagingFn().dispatchEvent(new Event('blur'));
});
TTT.waitForResponse();
TTT.asserts(12, function () {
@@ -741,10 +699,7 @@ QUnit.test("Custom Sorting: right paging", function (assert) {
});
TTT.action(function () {
leftPagingFn().value = "22";
-
- const event = document.createEvent('HTMLEvents');
- event.initEvent('blur', true, false);
- leftPagingFn().dispatchEvent(event);
+ leftPagingFn().dispatchEvent(new Event('blur'));
});
TTT.waitForResponse();
TTT.asserts(12, function () {
@@ -800,10 +755,7 @@ QUnit.test("Custom Sorting: right paging", function (assert) {
});
TTT.action(function () {
rightPagingInputFn().value = "14";
-
- const event = document.createEvent('HTMLEvents');
- event.initEvent('blur', true, false);
- rightPagingInputFn().dispatchEvent(event);
+ rightPagingInputFn().dispatchEvent(new Event('blur'));
});
TTT.waitForResponse();
TTT.asserts(12, function () {
diff --git a/tobago-example/tobago-example-demo/src/main/webapp/content/20-component/090-tree/01-select/Tree_Select.test.js b/tobago-example/tobago-example-demo/src/main/webapp/content/20-component/090-tree/01-select/Tree_Select.test.js
index c683d3f..4f2152f 100644
--- a/tobago-example/tobago-example-demo/src/main/webapp/content/20-component/090-tree/01-select/Tree_Select.test.js
+++ b/tobago-example/tobago-example-demo/src/main/webapp/content/20-component/090-tree/01-select/Tree_Select.test.js
@@ -205,9 +205,7 @@ QUnit.test("multiCascade: select Music, select Mathematics, deselect Classic", f
TTT.action(function () {
selectableNoneFn().checked = true;
- const event = document.createEvent('HTMLEvents');
- event.initEvent('change', true, false);
- selectableNoneFn().dispatchEvent(event);
+ selectableNoneFn().dispatchEvent(new Event('change'));
});
TTT.waitForResponse();
TTT.asserts(1, function () {
@@ -216,9 +214,7 @@ QUnit.test("multiCascade: select Music, select Mathematics, deselect Classic", f
TTT.action(function () {
selectableMultiCascadeFn().checked = true;
- const event = document.createEvent('HTMLEvents');
- event.initEvent('change', true, false);
- selectableMultiCascadeFn().dispatchEvent(event);
+ selectableMultiCascadeFn().dispatchEvent(new Event('change'));
});
TTT.waitForResponse();
TTT.asserts(1, function () {
@@ -227,9 +223,7 @@ QUnit.test("multiCascade: select Music, select Mathematics, deselect Classic", f
TTT.action(function () {
musicFn().checked = true;
- const event = document.createEvent('HTMLEvents');
- event.initEvent('change', true, false);
- musicFn().dispatchEvent(event);
+ musicFn().dispatchEvent(new Event('change'));
});
TTT.waitForResponse(); // an ajax request is send for every leaf (Music, Classic, Pop, World)
TTT.waitMs(2000); // wait for the last ajax
@@ -239,9 +233,7 @@ QUnit.test("multiCascade: select Music, select Mathematics, deselect Classic", f
TTT.action(function () {
mathematicsFn().checked = true;
- const event = document.createEvent('HTMLEvents');
- event.initEvent('change', true, false);
- mathematicsFn().dispatchEvent(event);
+ mathematicsFn().dispatchEvent(new Event('change'));
});
TTT.waitForResponse();
TTT.asserts(1, function () {
@@ -250,9 +242,7 @@ QUnit.test("multiCascade: select Music, select Mathematics, deselect Classic", f
TTT.action(function () {
classicFn().checked = false;
- const event = document.createEvent('HTMLEvents');
- event.initEvent('change', true, false);
- classicFn().dispatchEvent(event);
+ classicFn().dispatchEvent(new Event('change'));
});
TTT.waitForResponse();
TTT.asserts(1, function () {
[myfaces-tobago] 02/02: TOBAGO-1633: TS refactoring: fix tests
Posted by hn...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
hnoeth pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git
commit 620af8afe22c24e2db61d23b7d4890f9bcda68cf
Author: Henning Noeth <hn...@apache.org>
AuthorDate: Wed Jul 31 15:04:15 2019 +0200
TOBAGO-1633: TS refactoring: fix tests
* sheet event test fixed
* event test fixed
---
.../080-sheet/30-event/Sheet_Event.test.js | 25 +++++++++++-----------
.../content/40-test/6000-event/Event.test.js | 2 +-
2 files changed, 14 insertions(+), 13 deletions(-)
diff --git a/tobago-example/tobago-example-demo/src/main/webapp/content/20-component/080-sheet/30-event/Sheet_Event.test.js b/tobago-example/tobago-example-demo/src/main/webapp/content/20-component/080-sheet/30-event/Sheet_Event.test.js
index 671f893..6615f80 100644
--- a/tobago-example/tobago-example-demo/src/main/webapp/content/20-component/080-sheet/30-event/Sheet_Event.test.js
+++ b/tobago-example/tobago-example-demo/src/main/webapp/content/20-component/080-sheet/30-event/Sheet_Event.test.js
@@ -15,22 +15,20 @@
* limitations under the License.
*/
-import {jQueryFrameFn} from "/script/tobago-test.js";
+import {jQueryFrameFn, testFrameQuerySelectorFn} from "/script/tobago-test.js";
import {TobagoTestTool} from "/tobago/test/tobago-test-tool.js";
QUnit.test("On click with ajax", function (assert) {
- var oneClickAjaxFn = jQueryFrameFn("#page\\:mainForm\\:changeExample\\:\\:0");
+ var oneClickAjaxFn = testFrameQuerySelectorFn("#page\\:mainForm\\:changeExample\\:\\:0");
var venusFn = jQueryFrameFn("#page\\:mainForm\\:s1\\:2\\:sample0");
var jupiterFn = jQueryFrameFn("#page\\:mainForm\\:s1\\:5\\:sample0");
var saturnFn = jQueryFrameFn("#page\\:mainForm\\:s1\\:6\\:sample0");
var namefieldFn = jQueryFrameFn("#page\\:mainForm\\:name\\:\\:field");
- // ensure: the radio button is not checked
- oneClickAjaxFn().prop("checked", false);
-
var TTT = new TobagoTestTool(assert);
TTT.action(function () {
- oneClickAjaxFn().click();
+ oneClickAjaxFn().checked = true;
+ oneClickAjaxFn().dispatchEvent(new Event('change'));
});
TTT.waitForResponse();
TTT.asserts(3, function () {
@@ -63,7 +61,7 @@ QUnit.test("On click with ajax", function (assert) {
});
QUnit.test("On click with full request", function (assert) {
- var oneClickFullRequestFn = jQueryFrameFn("#page\\:mainForm\\:changeExample\\:\\:1");
+ var oneClickFullRequestFn = testFrameQuerySelectorFn("#page\\:mainForm\\:changeExample\\:\\:1");
var venusFn = jQueryFrameFn("#page\\:mainForm\\:s1\\:2\\:sample1");
var jupiterFn = jQueryFrameFn("#page\\:mainForm\\:s1\\:5\\:sample1");
var saturnFn = jQueryFrameFn("#page\\:mainForm\\:s1\\:6\\:sample1");
@@ -71,7 +69,8 @@ QUnit.test("On click with full request", function (assert) {
var TTT = new TobagoTestTool(assert);
TTT.action(function () {
- oneClickFullRequestFn().click();
+ oneClickFullRequestFn().checked = true;
+ oneClickFullRequestFn().dispatchEvent(new Event('change'));
});
TTT.waitForResponse();
TTT.asserts(3, function () {
@@ -104,7 +103,7 @@ QUnit.test("On click with full request", function (assert) {
});
QUnit.test("On double click with full request", function (assert) {
- var doubleClickFullRequestFn = jQueryFrameFn("#page\\:mainForm\\:changeExample\\:\\:2");
+ var doubleClickFullRequestFn = testFrameQuerySelectorFn("#page\\:mainForm\\:changeExample\\:\\:2");
var venusFn = jQueryFrameFn("#page\\:mainForm\\:s1\\:2\\:sample2");
var jupiterFn = jQueryFrameFn("#page\\:mainForm\\:s1\\:5\\:sample2");
var saturnFn = jQueryFrameFn("#page\\:mainForm\\:s1\\:6\\:sample2");
@@ -112,7 +111,8 @@ QUnit.test("On double click with full request", function (assert) {
var TTT = new TobagoTestTool(assert);
TTT.action(function () {
- doubleClickFullRequestFn().click();
+ doubleClickFullRequestFn().checked = true;
+ doubleClickFullRequestFn().dispatchEvent(new Event('change'));
});
TTT.waitForResponse();
TTT.asserts(3, function () {
@@ -145,7 +145,7 @@ QUnit.test("On double click with full request", function (assert) {
});
QUnit.test("Open popup on click with ajax", function (assert) {
- var radioButtonFn = jQueryFrameFn("#page\\:mainForm\\:changeExample\\:\\:3");
+ var radioButtonFn = testFrameQuerySelectorFn("#page\\:mainForm\\:changeExample\\:\\:3");
var venusFn = jQueryFrameFn("#page\\:mainForm\\:s1\\:2\\:sample3");
var jupiterFn = jQueryFrameFn("#page\\:mainForm\\:s1\\:5\\:sample3");
var saturnFn = jQueryFrameFn("#page\\:mainForm\\:s1\\:6\\:sample3");
@@ -155,7 +155,8 @@ QUnit.test("Open popup on click with ajax", function (assert) {
var TTT = new TobagoTestTool(assert);
TTT.action(function () {
- radioButtonFn().click();
+ radioButtonFn().checked = true;
+ radioButtonFn().dispatchEvent(new Event('change'));
});
TTT.waitForResponse();
TTT.asserts(3, function () {
diff --git a/tobago-example/tobago-example-demo/src/main/webapp/content/40-test/6000-event/Event.test.js b/tobago-example/tobago-example-demo/src/main/webapp/content/40-test/6000-event/Event.test.js
index 6f82e4d..f282b16 100644
--- a/tobago-example/tobago-example-demo/src/main/webapp/content/40-test/6000-event/Event.test.js
+++ b/tobago-example/tobago-example-demo/src/main/webapp/content/40-test/6000-event/Event.test.js
@@ -15,7 +15,7 @@
* limitations under the License.
*/
-import {jQueryFrameFn} from "/script/tobago-test.js";
+import {jQueryFrame, jQueryFrameFn} from "/script/tobago-test.js";
import {TobagoTestTool} from "/tobago/test/tobago-test-tool.js";
QUnit.test("tc:button", function (assert) {