You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "Ivan Ukhov (JIRA)" <ji...@apache.org> on 2019/03/06 19:23:00 UTC

[jira] [Commented] (AIRFLOW-3856) Incorrect treatment of use_legacy_sql in BigQueryOperator

    [ https://issues.apache.org/jira/browse/AIRFLOW-3856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786052#comment-16786052 ] 

Ivan Ukhov commented on AIRFLOW-3856:
-------------------------------------

[~jackjack10], since this issue hasn’t received much attention, I’ve started to wonder if it’s my misunderstanding of the code, or if it’s indeed a problem. Could you please explain your point of view?

> Incorrect treatment of use_legacy_sql in BigQueryOperator
> ---------------------------------------------------------
>
>                 Key: AIRFLOW-3856
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3856
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: api, gcp
>    Affects Versions: 1.10.2
>            Reporter: Ivan Ukhov
>            Priority: Major
>
> BigQueryOperator does not allow use_legacy_sql set to False and query_params at the same time. The problem can be seen here:
> [https://github.com/apache/airflow/blob/1.10.2/airflow/contrib/hooks/bigquery_hook.py#L731]
> It is not the presence that matters but the actual value. This effectively prevents the usage of query parameters, as the default value for use_legacy_sql is True.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)