You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by sh...@apache.org on 2015/06/30 04:07:11 UTC

[2/2] incubator-kylin git commit: KYLIN-839 bug fix

KYLIN-839 bug fix

Project: http://git-wip-us.apache.org/repos/asf/incubator-kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kylin/commit/7fdcd31d
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kylin/tree/7fdcd31d
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kylin/diff/7fdcd31d

Branch: refs/heads/0.7-staging
Commit: 7fdcd31d07b6f1b5000e96a90018747158a59505
Parents: 9a467fd
Author: shaofengshi <sh...@apache.org>
Authored: Mon Jun 29 19:11:54 2015 +0800
Committer: shaofengshi <sh...@apache.org>
Committed: Mon Jun 29 19:11:54 2015 +0800

----------------------------------------------------------------------
 .../main/java/org/apache/kylin/dict/lookup/SnapshotTable.java  | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/7fdcd31d/dictionary/src/main/java/org/apache/kylin/dict/lookup/SnapshotTable.java
----------------------------------------------------------------------
diff --git a/dictionary/src/main/java/org/apache/kylin/dict/lookup/SnapshotTable.java b/dictionary/src/main/java/org/apache/kylin/dict/lookup/SnapshotTable.java
index 130a4c2..28db5b4 100644
--- a/dictionary/src/main/java/org/apache/kylin/dict/lookup/SnapshotTable.java
+++ b/dictionary/src/main/java/org/apache/kylin/dict/lookup/SnapshotTable.java
@@ -209,6 +209,8 @@ public class SnapshotTable extends RootPersistentEntity implements ReadableTable
         int rowNum = in.readInt();
         if (rowNum > 0) {
             int n = in.readInt();
+            rowIndices = new ArrayList<int[]>(rowNum);
+
             if (this.useDictionary == true) {
                 this.dict = new TrieDictionary<String>();
                 dict.readFields(in);
@@ -222,7 +224,6 @@ public class SnapshotTable extends RootPersistentEntity implements ReadableTable
                 }
             } else {
                 List<String[]> rows = new ArrayList<String[]>(rowNum);
-                ArrayList<int[]> allRowIndices = new ArrayList<int[]>();
                 TrieDictionaryBuilder<String> b = new TrieDictionaryBuilder<String>(new StringBytesConverter());
 
                 for (int i = 0; i < rowNum; i++) {
@@ -239,9 +240,8 @@ public class SnapshotTable extends RootPersistentEntity implements ReadableTable
                     for (int i = 0; i < n; i++) {
                         rowIndex[i] = dict.getIdFromValue(row[i]);
                     }
-                    allRowIndices.add(rowIndex);
+                    this.rowIndices.add(rowIndex);
                 }
-                this.rowIndices = allRowIndices;
             }
         }
     }