You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "XComp (via GitHub)" <gi...@apache.org> on 2023/02/01 09:47:45 UTC

[GitHub] [flink] XComp opened a new pull request, #21818: [FLINK-30474][runtime] Propagates leader information change only if the leadership is still acquired

XComp opened a new pull request, #21818:
URL: https://github.com/apache/flink/pull/21818

   LeaderElectionEventHandler.onLeaderInformationChange should only be called if the handler (i.e. DefaultLeaderElectionService) is actually the leader. This check is already implemented in the corresponding calling methods of the MultipleComponentLeaderElectionDriver implementations. But these methods only schedule the logic rather than executing it right away. The execution is handled in a separate thread (i.e. DefaultMultipleComponentLeaderElectionService#leadershipOperationExecutor). That might create a race condition if a leader change is queued up already but not performed, yet, before the leader information change event gets queued up as well.
   
   1.15 backport PR of parent PR #21537


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp merged pull request #21818: [BP-1.15][FLINK-30474][runtime] Propagates leader information change only if the leadership is still acquired

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp merged PR #21818:
URL: https://github.com/apache/flink/pull/21818


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21818: [BP-1.15][FLINK-30474][runtime] Propagates leader information change only if the leadership is still acquired

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #21818:
URL: https://github.com/apache/flink/pull/21818#issuecomment-1411769791

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a4e4b2e55383796129ed78d9c2a73c8517583d64",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a4e4b2e55383796129ed78d9c2a73c8517583d64",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a4e4b2e55383796129ed78d9c2a73c8517583d64 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org