[GitHub] [netbeans] neilcsmith-net commented on a diff in pull request #4678: Improve java platform selection logic for hints.

[GitBox <gi...@apache.org>]

neilcsmith-net commented on code in PR #4678:
URL: https://github.com/apache/netbeans/pull/4678#discussion_r985219586


##########
java/spi.java.hints/src/org/netbeans/modules/java/hints/spiimpl/Utilities.java:
##########
@@ -1090,7 +1091,7 @@ public synchronized ClasspathInfo createUniversalCPInfo() {
                     .filter((p) -> "j2se".equals(p.getSpecification().getName()))
                     .filter((p) -> p.getSpecification().getVersion() != null)
                     .filter((p) -> p.getSpecification().getVersion().compareTo(maxVersion) < 0)
-                    .max((p1, p2) -> p1.getSpecification().getVersion().compareTo(p2.getSpecification().getVersion()))
+                    .max(Comparator.comparing((p) -> p.getSpecification().getVersion()))

Review Comment:
   @mbien I _think_ that's fine.  And leads to nicer code here.  Still binary compatible because of bridge method not picked up by sigtest?  @jtulach the best person to check with on sigtests and compatible API updates.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists