You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "mweirauch (via GitHub)" <gi...@apache.org> on 2023/11/20 11:34:33 UTC
[PR] [MBUILDCACHE-74] Clean local cache for any artifact [maven-build-cache-extension]
mweirauch opened a new pull request, #110:
URL: https://github.com/apache/maven-build-cache-extension/pull/110
This MR cleans up any cached local build, no matter if the module/project in question has a package phase.
I noticed stale cache entries for our parent POM in the local build cache, which were not cleaned up.
--
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [MBUILDCACHE JIRA issue](https://issues.apache.org/jira/browse/MBUILDCACHE) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[MBUILDCACHE-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MBUILDCACHE-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MBUILDCACHE-74] Clean local cache for any artifact [maven-build-cache-extension]
Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on PR #110:
URL: https://github.com/apache/maven-build-cache-extension/pull/110#issuecomment-2955451212
Resolve #304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MBUILDCACHE-74] Clean local cache for any artifact [maven-build-cache-extension]
Posted by "mweirauch (via GitHub)" <gi...@apache.org>.
mweirauch commented on code in PR #110:
URL: https://github.com/apache/maven-build-cache-extension/pull/110#discussion_r1401527968
##########
src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java:
##########
@@ -503,6 +503,7 @@ public void save(
}
}
} else {
+ localCache.beforeSave(context);
Review Comment:
Oh sorry, I should have left a comment in the MR intially ...
While checking existing issues, I stumbled upon MBUILDCACHE-71 (only publish buildinfo after optional artifacts were pushed) and tried to pull both calls (::beforeSave and ::saveBuildInfo) actually down/below the "if", but that makes Issue67Test actually fail.
I'll try to have a look what the expectations are on Issue67Test, but my time is a bit limited. So is the proposoal to move both statements above the "if" and dropping the "else branch" acceptable for the moment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MBUILDCACHE-74] Clean local cache for any artifact [maven-build-cache-extension]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #110:
URL: https://github.com/apache/maven-build-cache-extension/pull/110#discussion_r1400478435
##########
src/test/projects/mbuildcache-74-clean-cache-any-artifact/pom.xml:
##########
@@ -0,0 +1,60 @@
+<!--
+
+ Copyright 2021 the original author or authors.
Review Comment:
2023
##########
src/test/projects/mbuildcache-74-clean-cache-any-artifact/.mvn/extensions.xml:
##########
@@ -0,0 +1,25 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Copyright 2021 the original author or authors.
Review Comment:
2023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MBUILDCACHE-74] Clean local cache for any artifact [maven-build-cache-extension]
Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on PR #110:
URL: https://github.com/apache/maven-build-cache-extension/pull/110#issuecomment-2955468168
Resolve #304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MBUILDCACHE-74] Clean local cache for any artifact [maven-build-cache-extension]
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on PR #110:
URL: https://github.com/apache/maven-build-cache-extension/pull/110#issuecomment-1823508706
@mweirauch no worries. My bad I didn’t check the PR correctly with last commit.
Please just create a PR to revert this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MBUILDCACHE-74] Clean local cache for any artifact [maven-build-cache-extension]
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy merged PR #110:
URL: https://github.com/apache/maven-build-cache-extension/pull/110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MBUILDCACHE-74] Clean local cache for any artifact [maven-build-cache-extension]
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on PR #110:
URL: https://github.com/apache/maven-build-cache-extension/pull/110#issuecomment-1823557045
@mweirauch done with https://github.com/apache/maven-build-cache-extension/pull/114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MBUILDCACHE-74] Clean local cache for any artifact [maven-build-cache-extension]
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on code in PR #110:
URL: https://github.com/apache/maven-build-cache-extension/pull/110#discussion_r1401411398
##########
src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java:
##########
@@ -503,6 +503,7 @@ public void save(
}
}
} else {
+ localCache.beforeSave(context);
Review Comment:
as this will done for both if and else maybe better to write this only once before the if?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MBUILDCACHE-74] Clean local cache for any artifact [maven-build-cache-extension]
Posted by "mweirauch (via GitHub)" <gi...@apache.org>.
mweirauch commented on PR #110:
URL: https://github.com/apache/maven-build-cache-extension/pull/110#issuecomment-1822705452
Oops, I didn't pay attention and force pushed a local change to the root pom.xml which helps vscode to actually recognize the generated sources folder for the mdo generated models. This now landed on master. I am very sorry for this mistake!
Please let me know if you want to keep it. It shouldn't hurt the build, but it's still IDE specific. (vscode uses Eclipse' m2e backend which needs some help with the classpath extension; dunno specifically if this change also helps Eclipse users as well)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org