You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Ross Donaldson (JIRA)" <ji...@apache.org> on 2017/11/21 15:57:00 UTC
[jira] [Commented] (AIRFLOW-843) Store task exceptions in context
[ https://issues.apache.org/jira/browse/AIRFLOW-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260940#comment-16260940 ]
Ross Donaldson commented on AIRFLOW-843:
----------------------------------------
I'd like to volunteer to fix this. I can see two perfectly lovely approaches:
1. Attach the `error` object in to the `context` dict `on_failure_callback` receives.
2. Modify the signature to `on_failure_callback` to accept the error as a (potentially optional) second argument.
Any preferences? Otherwise, I have a gentle preference for #2, and will open a PR.
> Store task exceptions in context
> --------------------------------
>
> Key: AIRFLOW-843
> URL: https://issues.apache.org/jira/browse/AIRFLOW-843
> Project: Apache Airflow
> Issue Type: Improvement
> Reporter: Scott Kruger
> Priority: Minor
>
> If a task encounters an exception during execution, it should store the exception on the execution context so that other methods (namely `on_failure_callback` can access it. This would help with custom error integrations, e.g. Sentry.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)