[GitHub] [doris] cambyzju commented on a diff in pull request #15837: [Feature](Materialized-View) support duplicate base column for diffrent aggregate function

[GitBox <gi...@apache.org>]

cambyzju commented on code in PR #15837:
URL: https://github.com/apache/doris/pull/15837#discussion_r1067657509


##########
be/src/olap/schema_change.cpp:
##########
@@ -427,7 +416,7 @@ Status VSchemaChangeDirectly::_inner_process(RowsetReaderSharedPtr rowset_reader
         auto ref_block = std::make_unique<vectorized::Block>(base_tablet_schema->create_block());
 
         rowset_reader->next_block(ref_block.get());
-        if (ref_block->rows() < 1) {
+        if (ref_block->rows() == 0) {

Review Comment:
   ```suggestion
           if (ref_block->empty()) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org