[GitHub] [beam] ihji commented on a change in pull request #15692: [BEAM-13021] Deduplicate Python artifact not only by hash but also by…

[GitBox <gi...@apache.org>]

ihji commented on a change in pull request #15692:
URL: https://github.com/apache/beam/pull/15692#discussion_r734002398



##########
File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
##########
@@ -572,7 +572,8 @@ def _stage_resources(self, pipeline, options):
       raise RuntimeError('The --temp_location option must be specified.')
 
     resources = []
-    hashes = {}
+    path_hashes = {}

Review comment:
       Thanks for pointing this out. We actually store paths not hashes. Renamed the variables to clarify their use.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org