You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "nchammas (via GitHub)" <gi...@apache.org> on 2026/09/08 04:00:07 UTC
[PR] [BUILD] Add config test module [spark]
nchammas opened a new pull request, #58587:
URL: https://github.com/apache/spark/pull/58587
### What changes were proposed in this pull request?
Add a new `config` test module that runs the `config/test` sbt goal (which runs `ConfigRegistrySuite`).
### Why are the changes needed?
When this new suite was added in #53488 I believe it was left out of the test modules by mistake.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
CI
### Was this patch authored or co-authored using generative AI tooling?
I wrote this patch with assistance from GitHub Copilot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59327][BUILD] Add config test module [spark]
Posted by "nchammas (via GitHub)" <gi...@apache.org>.
nchammas commented on PR #58587:
URL: https://github.com/apache/spark/pull/58587#issuecomment-6078628935
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/670927a20faee83e81f5857e74c71f4d184b2415
- merged into branch-4.x https://github.com/apache/spark/commit/175405f00279bab52c0df514b04aaf9653a4e13c
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59327][BUILD] Add config test module [spark]
Posted by "nchammas (via GitHub)" <gi...@apache.org>.
nchammas commented on PR #58587:
URL: https://github.com/apache/spark/pull/58587#issuecomment-5845326382
@cloud-fan - Is anything still holding this PR up from your point of view? I would have merged it in already, but I understood that you would like to do that yourself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59327][BUILD] Add config test module [spark]
Posted by "nchammas (via GitHub)" <gi...@apache.org>.
nchammas closed pull request #58587: [SPARK-59327][BUILD] Add config test module
URL: https://github.com/apache/spark/pull/58587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59327][BUILD] Add config test module [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #58587:
URL: https://github.com/apache/spark/pull/58587#issuecomment-5652389566
I'll merge after CI is green
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59327][BUILD] Add config test module [spark]
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho commented on PR #58587:
URL: https://github.com/apache/spark/pull/58587#issuecomment-5943641846
I think @cloud-fan is on vacation and maybe just lost track. It looks safe to merge though for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59327][BUILD] Add config test module [spark]
Posted by "nchammas (via GitHub)" <gi...@apache.org>.
nchammas commented on PR #58587:
URL: https://github.com/apache/spark/pull/58587#issuecomment-5639675844
Tagging some others who previously reviewed https://github.com/apache/spark/pull/53488.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59327][BUILD] Add config test module [spark]
Posted by "nchammas (via GitHub)" <gi...@apache.org>.
nchammas commented on PR #58587:
URL: https://github.com/apache/spark/pull/58587#issuecomment-5688137604
@cloud-fan - CI is green. I will let you merge since you asked to do that yourself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59327][BUILD] Add config test module [spark]
Posted by "nchammas (via GitHub)" <gi...@apache.org>.
nchammas commented on PR #58587:
URL: https://github.com/apache/spark/pull/58587#issuecomment-5655513536
@cloud-fan - The CI failure is unrelated: https://github.com/apache/spark/pull/58587#issuecomment-5586602000
But I'll update from `master` anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59327][BUILD] Add config test module [spark]
Posted by "nchammas (via GitHub)" <gi...@apache.org>.
nchammas commented on PR #58587:
URL: https://github.com/apache/spark/pull/58587#issuecomment-6076005767
I'm going to just merge this in once CI is green. I'm pretty sure that's OK, and that @cloud-fan didn't mean to say that only he should merge this PR in.
I don't want to keep waiting because every push to `master` can potentially break these config tests silently since they are currently _not_ being run by CI!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59327][BUILD] Add config test module [spark]
Posted by "nchammas (via GitHub)" <gi...@apache.org>.
nchammas commented on PR #58587:
URL: https://github.com/apache/spark/pull/58587#issuecomment-5586602000
The [CI failure](https://github.com/nchammas/spark/actions/runs/34184737093/job/102052112353#step:12:72448) seems unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org