You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/06/23 15:48:07 UTC
[GitHub] [incubator-doris] morningman opened a new pull request #3934: [Refactor] Replace some boost to std in OlapScanNode
morningman opened a new pull request #3934:
URL: https://github.com/apache/incubator-doris/pull/3934
Replace some boost to std in OlapScanNode.
This refactor seems solve the problem describe in #3929.
Because I found that BE will crash to calling `boost::condition_variable.notify_all()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #3934: [Refactor] Replace some boost to std in OlapScanNode
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #3934:
URL: https://github.com/apache/incubator-doris/pull/3934
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] chaoyli commented on a change in pull request #3934: [Refactor] Replace some boost to std in OlapScanNode
Posted by GitBox <gi...@apache.org>.
chaoyli commented on a change in pull request #3934:
URL: https://github.com/apache/incubator-doris/pull/3934#discussion_r444598726
##########
File path: be/src/exec/olap_scan_node.cpp
##########
@@ -186,9 +185,9 @@ Status OlapScanNode::get_next(RuntimeState* state, RowBatch* row_batch, bool* eo
// check if Canceled.
if (state->is_cancelled()) {
- boost::unique_lock<boost::mutex> l(_row_batches_lock);
+ std::unique_lock<std::mutex> l(_row_batches_lock);
Review comment:
You can use util/condition_variable.h.
It comes from kudu, it's use is simple than std::
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #3934: [Refactor] Replace some boost to std in OlapScanNode
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #3934:
URL: https://github.com/apache/incubator-doris/pull/3934#discussion_r445999465
##########
File path: be/src/exec/olap_scan_node.cpp
##########
@@ -186,9 +185,9 @@ Status OlapScanNode::get_next(RuntimeState* state, RowBatch* row_batch, bool* eo
// check if Canceled.
if (state->is_cancelled()) {
- boost::unique_lock<boost::mutex> l(_row_batches_lock);
+ std::unique_lock<std::mutex> l(_row_batches_lock);
Review comment:
This PR is only try to solve the BE crash problem and I don't want to introduce any new potential problems.
I can't see any necessary to replace the `std::condition_variable` with `ConditionVariable`. If it is,
maybe we can replace all `std::condition_variable` in another PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org