You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "pwargulak (via GitHub)" <gi...@apache.org> on 2026/10/19 12:26:37 UTC
[PR] FINERACT-2969: Subtract a taxed charge's tax once across its rows [fineract]
pwargulak opened a new pull request, #6692:
URL: https://github.com/apache/fineract/pull/6692
## Description
[FINERACT-2969](https://issues.apache.org/jira/browse/FINERACT-2969)
Split out of #6666, as asked in its review.
One transaction paying a taxed charge in several rows (an instalment fee for two instalments) is refused with 403 `Meltdown in advanced accounting...sum of all charges is not equal to the fee charge for a transaction`, because `LoanCommonAccountingHelper#computeNetChargePayments` subtracts the charge's whole tax from each row.
The rows of each taxed charge are now merged into one before its tax is subtracted. The rows are summed per GL account afterwards anyway, so the posted amounts are unchanged for single-row charges, and no row goes negative (@adamsaghy's point 3 on #6666). Untaxed rows are passed through as they are.
Tests:
- new `LoanCommonAccountingHelperTest` (3);
- `LoanChargeTaxIntegrationTest`: a taxed instalment fee paid for two instalments in one repayment. It fails on `develop` with the 403.
Run locally: spotless, checkstyle, rat, javadoc and spotbugs; the core build; the `fineract-provider` unit suite; and `LoanChargeTaxIntegrationTest`, `ChargesTest`, `TaxesTest`, `AccountingScenarioIntegrationTest`, `LoanAccrualTransactionOnChargeSubmittedDateTest`, `LoanAccrualTransactionReversalTest`, `LoanChargebackWithCreditAllocationsIntegrationTests` and `ClientLoanIntegrationTest` on PostgreSQL, MariaDB and MySQL.
## Checklist
- [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
- [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made.
- [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute).
- [x] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately.
- [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2969: Subtract a taxed charge's tax once across its rows [fineract]
Posted by "pwargulak (via GitHub)" <gi...@apache.org>.
pwargulak commented on PR #6692:
URL: https://github.com/apache/fineract/pull/6692#issuecomment-6286318774
@adamsaghy re-signed commits correctly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2969: Subtract a taxed charge's tax once across its rows [fineract]
Posted by "pwargulak (via GitHub)" <gi...@apache.org>.
pwargulak commented on PR #6692:
URL: https://github.com/apache/fineract/pull/6692#issuecomment-6468359323
@adamsaghy @galovics
Could you take another look when you have a moment?
(this is extracted from https://github.com/apache/fineract/pull/6666)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2969: Subtract a taxed charge's tax once across its rows [fineract]
Posted by "pwargulak (via GitHub)" <gi...@apache.org>.
pwargulak commented on PR #6692:
URL: https://github.com/apache/fineract/pull/6692#issuecomment-6477365178
@adamsaghy rebased
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2969: Subtract a taxed charge's tax once across its rows [fineract]
Posted by "pwargulak (via GitHub)" <gi...@apache.org>.
pwargulak commented on PR #6692:
URL: https://github.com/apache/fineract/pull/6692#issuecomment-6523641658
@adamsaghy The test doesn't seem to relate to the change, I run it locally and got 4 fails in 25 runs. There is some race happening, and if you put a 1.5s wait in that test in a specific place it will fail every time.
I'm checking if there is an easy fix for the test and post it as separate ticket/PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2969: Subtract a taxed charge's tax once across its rows [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #6692:
URL: https://github.com/apache/fineract/pull/6692#issuecomment-6502738877
@pwargulak Please review the failing test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2969: Subtract a taxed charge's tax once across its rows [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #6692:
URL: https://github.com/apache/fineract/pull/6692#issuecomment-6475811870
@pwargulak Please rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2969: Subtract a taxed charge's tax once across its rows [fineract]
Posted by "adamsaghy (via GitHub) via issues" <is...@fineract.apache.org>.
adamsaghy merged PR #6692:
URL: https://github.com/apache/fineract/pull/6692
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org