You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/09/03 10:55:17 UTC

[GitHub] [airflow] feluelle commented on a change in pull request #9246: Few new functionalities and changes in S3ToRedshiftOperator

feluelle commented on a change in pull request #9246:
URL: https://github.com/apache/airflow/pull/9246#discussion_r482889114



##########
File path: airflow/providers/amazon/aws/transfers/s3_to_redshift.py
##########
@@ -112,6 +121,12 @@ def execute(self, context):
             copy_options=copy_options,
         )
 
+        transaction = f"""BEGIN;
+        {truncate_statement}
+        {copy_statement}
+        COMMIT
+        """

Review comment:
       You only need this when we want to truncate the table. If you do this, you don't have to modify existing tests.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org