[GitHub] [hadoop] bolerio commented on a change in pull request #2342: HADOOP-17288. Use shaded guava from thirdparty.

[GitBox <gi...@apache.org>]

bolerio commented on a change in pull request #2342:
URL: https://github.com/apache/hadoop/pull/2342#discussion_r508246398



##########
File path: hadoop-common-project/hadoop-auth/pom.xml
##########
@@ -234,6 +235,24 @@
           <excludeFilterFile>${basedir}/dev-support/findbugsExcludeFile.xml</excludeFilterFile>
         </configuration>
       </plugin>
+      <plugin>
+        <groupId>com.google.code.maven-replacer-plugin</groupId>
+        <artifactId>replacer</artifactId>
+        <executions>
+          <execution>
+            <id>replace-sources</id>
+            <configuration>
+              <skip>false</skip>
+            </configuration>
+          </execution>
+          <execution>
+            <id>replace-test-sources</id>
+            <configuration>
+              <skip>false</skip>
+            </configuration>
+          </execution>
+        </executions>
+      </plugin>

Review comment:
       @ayushtkn et al.
   
   I recently did similar work as this PR on top of the 3.3.0 release, using the exact same approach with the replacer plugin and renaming the guava namespace to the Hadoop thirdparty shaded version throughout the whole codebase. The short term goal was to solve the Hive incompatibility issue with Spark. The change worked, the Hive unit tests within the Spark codebase largely pass, no more linkage error.  However, a guava dependency still needed to be declared in the Hadoop pom.xml to overcome an enforcerer error about conflicting Guava versions that show up as transitive dependencies.  
   
   Hope this is helpful information. If there is interest in the community, I make a PR or otherwise make that available for testing?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org