You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2023/08/11 14:16:17 UTC

[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1804: [CELEBORN-886][HELM]Support multiple celeborn clusters in the same k8s namespace

pan3793 commented on code in PR #1804:
URL: https://github.com/apache/incubator-celeborn/pull/1804#discussion_r1291396798


##########
charts/celeborn/templates/configmap.yaml:
##########
@@ -18,7 +18,7 @@
 apiVersion: v1
 kind: ConfigMap
 metadata:
-  name: celeborn-conf
+  name: {{ .Values.celebornClusterPrefix }}-conf

Review Comment:
   The idea looks good, I'm concern with the name, maybe `celebornResourcePrefix`.
   
   Another idea is to use helm release name as we discussed offline, but it requires to do investigation whether it's designed/suitable for such cases before applying.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org