You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by mi...@apache.org on 2011/07/21 18:17:03 UTC

svn commit: r1149256 - /lucene/dev/trunk/lucene/src/java/org/apache/lucene/search/TopScoreDocCollector.java

Author: mikemccand
Date: Thu Jul 21 16:17:00 2011
New Revision: 1149256

URL: http://svn.apache.org/viewvc?rev=1149256&view=rev
Log:
small optimization: don't add docBase unless score may be competitive

Modified:
    lucene/dev/trunk/lucene/src/java/org/apache/lucene/search/TopScoreDocCollector.java

Modified: lucene/dev/trunk/lucene/src/java/org/apache/lucene/search/TopScoreDocCollector.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/src/java/org/apache/lucene/search/TopScoreDocCollector.java?rev=1149256&r1=1149255&r2=1149256&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/src/java/org/apache/lucene/search/TopScoreDocCollector.java (original)
+++ lucene/dev/trunk/lucene/src/java/org/apache/lucene/search/TopScoreDocCollector.java Thu Jul 21 16:17:00 2011
@@ -82,8 +82,13 @@ public abstract class TopScoreDocCollect
       assert !Float.isNaN(score);
 
       totalHits++;
+      if (score < pqTop.score) {
+        // Doesn't compete w/ bottom entry in queue
+        return;
+      }
       doc += docBase;
-      if (score < pqTop.score || (score == pqTop.score && doc > pqTop.doc)) {
+      if (score == pqTop.score && doc > pqTop.doc) {
+        // Break tie in score by doc ID:
         return;
       }
       pqTop.doc = doc;