You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/06/03 23:35:05 UTC

[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #3024: [WIP][GOBBLIN-1178] Propagation of exception from task creation to helix and request for new container

sv2000 commented on a change in pull request #3024:
URL: https://github.com/apache/incubator-gobblin/pull/3024#discussion_r434911632



##########
File path: gobblin-runtime/src/main/java/org/apache/gobblin/runtime/GobblinMultiTaskAttempt.java
##########
@@ -413,6 +424,10 @@ private boolean taskSuccessfulInPriorAttempt(String taskId) {
         }
 
         if (task == null) {
+          if (e instanceof RetryException) {
+            // Indicating task being null due to failure in creation even after retrying.
+            failureInTaskCreation = false;

Review comment:
       failureInTaskCreation -> isTaskCreatedSuccessfully? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org