[GitHub] [fineract] Sanyam96 commented on issue #629: Swagger documentation gsoc2019

[GitBox <gi...@apache.org>]

Sanyam96 commented on issue #629: Swagger documentation gsoc2019
URL: https://github.com/apache/fineract/pull/629#issuecomment-524723910
 
 
   Adding Authentication and common params for swagger documentation to each and every endpoint(API's ) is unnecessary and is not a good coding standard.
   It will increase redundant code for auth to every API's, which can be done by sharing a common resource to all the API's
   
   In the review of removing Auth params from every API in your commit: 
   https://github.com/kangbreder/fineract/commit/7418ac403e4e145c86dd826086a2799dd5c4bf7c#commitcomment-34794554
   
   Here are some reference links which you can refer to remove those params!
   https://stackoverflow.com/questions/47627469/swagger2-too-many-the-same-annotations
   https://stackoverflow.com/questions/39853217/swagger-how-to-combine-shared-information-from-different-apis

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services