You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dolphinscheduler.apache.org by Jiajie Zhong <zh...@apache.org> on 2021/10/09 03:28:53 UTC
Re: [PROPOSAL] Combine docs and code repo into apache/dolphinscheduler
Hi Calvin,
I agrees with you about we should add a labels to mark PR, which mean code change PR would merge until doc PR was merged. Or maybe create a related doc issues Immediately.
If you worry about lose our contributors contact, maybe the second way is a better choose.
On 2021/09/09 06:37:47, CalvinKirs <ac...@163.com> wrote:
> Contributors are usually required to provide relevant documents after submitting the code and merge. Some contributors (especially new contributors) may forget to provide, so contributors from the community are required to contribute.
>
>
> Maybe we can mark it as ready merge-wait for doc after approval. At this time, the pr of the document is required, but some cases may cause code conflicts when completing the doc. There are also worse cases where contributors lose contact.
>
>
> do you have any good suggestions?
Re: [PROPOSAL] Combine docs and code repo into apache/dolphinscheduler
Posted by Lidong Dai <li...@apache.org>.
this is a good idea, doc should be added when the PR is ready to merge
Best Regards
---------------
Apache DolphinScheduler PMC Chair
LidongDai
lidongdai@apache.org
Linkedin: https://www.linkedin.com/in/dailidong
Twitter: @WorkflowEasy <https://twitter.com/WorkflowEasy>
---------------
On Sat, Oct 9, 2021 at 11:28 AM Jiajie Zhong <zh...@apache.org> wrote:
> Hi Calvin,
> I agrees with you about we should add a labels to mark PR, which mean
> code change PR would merge until doc PR was merged. Or maybe create a
> related doc issues Immediately.
> If you worry about lose our contributors contact, maybe the second way
> is a better choose.
>
> On 2021/09/09 06:37:47, CalvinKirs <ac...@163.com> wrote:
> > Contributors are usually required to provide relevant documents after
> submitting the code and merge. Some contributors (especially new
> contributors) may forget to provide, so contributors from the community are
> required to contribute.
> >
> >
> > Maybe we can mark it as ready merge-wait for doc after approval. At this
> time, the pr of the document is required, but some cases may cause code
> conflicts when completing the doc. There are also worse cases where
> contributors lose contact.
> >
> >
> > do you have any good suggestions?
>
>