You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2023/02/13 14:02:12 UTC
[GitHub] [incubator-kvrocks] tisonkun opened a new pull request, #1258: build: Drop travis workflow
tisonkun opened a new pull request, #1258:
URL: https://github.com/apache/incubator-kvrocks/pull/1258
Signed-off-by: tison <wa...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on a diff in pull request #1258: build: Drop travis workflow
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #1258:
URL: https://github.com/apache/incubator-kvrocks/pull/1258#discussion_r1104516550
##########
.github/workflows/kvrocks.yaml:
##########
@@ -254,6 +254,16 @@ jobs:
./build/kvrocks
./coredumps/*
+ docker:
+ name: Check Docker image
+ needs: [check-and-lint]
+ runs-on: ubuntu-20.04
+ steps:
+ - uses: actions/checkout@v3
+ - uses: docker/build-push-action@v3
Review Comment:
Verify docker build per PR, but for amd64 only. We don't have too much different when compile on amd64 or arm64.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on a diff in pull request #1258: build: Drop travis workflow
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #1258:
URL: https://github.com/apache/incubator-kvrocks/pull/1258#discussion_r1105314093
##########
.github/workflows/nightly.yaml:
##########
@@ -0,0 +1,66 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Nightly
+
+on:
+ push:
+ branch: [unstable]
Review Comment:
```suggestion
branches: [unstable]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun merged pull request #1258: build: Drop travis workflow
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #1258:
URL: https://github.com/apache/incubator-kvrocks/pull/1258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org