You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/06/15 20:43:36 UTC
[GitHub] [beam] TheNeuralBit commented on a change in pull request #14963: [BEAM-12074] Make sure all GroupBy operations have docstrings
TheNeuralBit commented on a change in pull request #14963:
URL: https://github.com/apache/beam/pull/14963#discussion_r652136555
##########
File path: sdks/python/apache_beam/dataframe/frame_base.py
##########
@@ -100,9 +100,7 @@ def __repr__(self):
class DeferredFrame(DeferredBase):
- @property
- def dtypes(self):
- return self._expr.proxy().dtypes
Review comment:
@robertwb do you know why we had dtypes defined in `DeferredFrame`, is this just because it predates `DeferredFrameOrSeries`?
##########
File path: sdks/python/apache_beam/dataframe/frame_base.py
##########
@@ -100,9 +100,7 @@ def __repr__(self):
class DeferredFrame(DeferredBase):
- @property
- def dtypes(self):
- return self._expr.proxy().dtypes
Review comment:
@robertwb do you know why we had dtypes defined in `DeferredFrame`, is this just because it predates `DeferredDataFrameOrSeries`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org