You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/07/19 23:09:46 UTC
[GitHub] [pinot] jackjlli commented on a diff in pull request #9063: feature: add table type to segment upload
jackjlli commented on code in PR #9063:
URL: https://github.com/apache/pinot/pull/9063#discussion_r925027474
##########
pom.xml:
##########
@@ -166,8 +166,8 @@
To change kafka connector dependency, we only need to update this version number config.
TODO: figure out a way to inject kafka dependency instead of explicitly setting the kafka module dependency -->
<kafka.version>2.0</kafka.version>
- <protobuf.version>3.19.2</protobuf.version>
- <grpc.version>1.41.0</grpc.version>
+ <protobuf.version>3.20.1</protobuf.version>
Review Comment:
+1 on that. Similar to grpc version in the next line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org