You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by grkvlt <gi...@git.apache.org> on 2016/09/20 21:24:39 UTC

[GitHub] brooklyn-server pull request #337: Add config inheritance to customizers key

GitHub user grkvlt opened a pull request:

    https://github.com/apache/brooklyn-server/pull/337

    Add config inheritance to customizers key

    Enables merging of customizsers for locations.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/grkvlt/brooklyn-server customizers-inheritance

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/337.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #337
    
----
commit 00ccf22c655033602b47ff2564e1a54e0f0fffca
Author: Andrew Donald Kennedy <an...@cloudsoftcorp.com>
Date:   2016-09-20T21:23:24Z

    Add config inheritance to customizers key

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #337: Add config inheritance to customizers key

Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on the issue:

    https://github.com/apache/brooklyn-server/pull/337
  
    @ahgittin understood; i will work on the change you suggest instead. closing this for now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #337: Add config inheritance to customizers key

Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the issue:

    https://github.com/apache/brooklyn-server/pull/337
  
    failure is unrelated
    
    intention makes sense
    
    however this will do nothing as deep_merge only applies to maps.
    
    with #340 you could relatively easily introduce a new `COLLECTION_ANCESTORS_FIRST` or `COLLECTION_ANCESTORS_LAST` into `BasicConfigInheritance` which would make sense for sets or lists (but with different semantics).  or maybe simpler change the `deepMerge` method in that class to support collections, probably adding ancestors last.
    
    that change plus a test for this commit which tests that change would be welcome.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #337: Add config inheritance to customizers key

Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/337


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---