You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pirk.apache.org by tellison <gi...@git.apache.org> on 2016/08/18 11:55:25 UTC
[GitHub] incubator-pirk pull request #66: [PIRK-55] Move all tests under src/test dir...
GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/66
[PIRK-55] Move all tests under src/test directory
- Moves test files under src/test.
- Rename packages to ensure consistency with org.apache.pirk.test.
- Update pom exclusion filter.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tellison/incubator-pirk pirk-55
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-pirk/pull/66.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #66
----
commit 0b4a49ce5b42e28d1c19077c065e67bdb575ea89
Author: Tim Ellison <t....@gmail.com>
Date: 2016-08-18T11:39:59Z
[PIRK-55] Move all tests under src/test directory
- Moves test files under src/test.
- Rename packages to ensure consistency with org.apache.pirk.test.
- Update pom exclusion filter.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk pull request #66: [PIRK-55] Move all tests under src/test dir...
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/66#discussion_r75328858
--- Diff: pom.xml ---
@@ -464,7 +464,7 @@
<version>3.0.1</version>
<configuration>
<excludes>
- <exclude>org/apache/pirk/benchmark/**</exclude>
+ <exclude>org/apache/pirk/test/benchmark/**</exclude>
--- End diff --
Don't think this is needed, the test/ folder is never packaged into Maven artifacts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk issue #66: [PIRK-55] Move all tests under src/test directory
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the issue:
https://github.com/apache/incubator-pirk/pull/66
Merging this now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] incubator-pirk pull request #66: [PIRK-55] Move all
tests under src/test dir...
Posted by Suneel Marthi <su...@gmail.com>.
The commit has been reverted, please get the latest from master.
On Thu, Aug 18, 2016 at 3:57 PM, Jacob Wilder <
jacobwilder.opensource@gmail.com> wrote:
> Moving the benchmarks into the test tree broke all of the JMH benchmarks.
> We need to move them back into the main source tree. I don't see a way to
> make JMH happy with keeping the benchmarks in the test tree.
>
> If the JMH benchmarks are in the test tree then (after the error-free and
> successful compilation using pom-with-benchmarks.xml) when you run `java
> -jar target/benchmarks.jar` you get:
>
> Error: Could not find or load main class org.openjdk.jmh.Main
> I think this has to do with not being able to find BenchmarkDriver that
> invokes org.openjdk.jmh.Main but I'm not totally sure. That error is all of
> the output I get.
>
> —
> Jacob WIlder
>
> On Thu, Aug 18, 2016 at 11:32 AM, asfgit <gi...@git.apache.org> wrote:
>
> > Github user asfgit closed the pull request at:
> >
> > https://github.com/apache/incubator-pirk/pull/66
> >
> >
> > ---
> > If your project is set up for it, you can reply to this email and have
> your
> > reply appear on GitHub as well. If your project does not have this
> feature
> > enabled and wishes so, or if the feature is enabled but not working,
> please
> > contact infrastructure at infrastructure@apache.org or file a JIRA
> ticket
> > with INFRA.
> > ---
> >
>
Re: [GitHub] incubator-pirk pull request #66: [PIRK-55] Move all
tests under src/test dir...
Posted by Jacob Wilder <ja...@gmail.com>.
Moving the benchmarks into the test tree broke all of the JMH benchmarks.
We need to move them back into the main source tree. I don't see a way to
make JMH happy with keeping the benchmarks in the test tree.
If the JMH benchmarks are in the test tree then (after the error-free and
successful compilation using pom-with-benchmarks.xml) when you run `java
-jar target/benchmarks.jar` you get:
Error: Could not find or load main class org.openjdk.jmh.Main
I think this has to do with not being able to find BenchmarkDriver that
invokes org.openjdk.jmh.Main but I'm not totally sure. That error is all of
the output I get.
—
Jacob WIlder
On Thu, Aug 18, 2016 at 11:32 AM, asfgit <gi...@git.apache.org> wrote:
> Github user asfgit closed the pull request at:
>
> https://github.com/apache/incubator-pirk/pull/66
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] incubator-pirk pull request #66: [PIRK-55] Move all tests under src/test dir...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-pirk/pull/66
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk pull request #66: [PIRK-55] Move all tests under src/test dir...
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/66#discussion_r75328978
--- Diff: pom.xml ---
@@ -451,7 +451,7 @@
<version>3.0.1</version>
<configuration>
<excludes>
- <exclude>org/apache/pirk/benchmark/**</exclude>
+ <exclude>org/apache/pirk/test/benchmark/**</exclude>
--- End diff --
Not needed as test/ folder is never packaged into maven artifacts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk issue #66: [PIRK-55] Move all tests under src/test directory
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the issue:
https://github.com/apache/incubator-pirk/pull/66
+1 lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---