[I] fix(desktop): stop previous-session recovery from blocking repeated startup [maka]

["M4n5ter (via GitHub)" <gi...@apache.org>]

M4n5ter opened a new issue, #3804:
URL: https://github.com/apache/maka/issues/3804

   <details open>
   <summary><strong>English</strong></summary>
   
   ## What happens
   
   After an interrupted Desktop run, the next `npm run dev` launch shows the native “Previous Maka session ended before shutdown completed” dialog before Runtime Host and the Renderer start. If that launch is stopped or restarted while the dialog is present, the current run also leaves an active recovery record. Every later launch can therefore show the same blocking dialog again.
   
   This reproduces across multiple restarts. A fresh Desktop profile starts normally, and no orphaned local Electron or Runtime Host process is required.
   
   ## Root cause
   
   #3543 intentionally presented recovery evidence before Runtime Host startup so diagnostics remained available without a Renderer. That ordering makes an informational previous-run notice part of the current startup critical path. The pending record is deleted only after the dialog completes, while the current run is already journaled as active.
   
   ## Expected behavior
   
   - Recovery evidence remains bounded, local, redacted, and copyable.
   - Desktop starts and recovers normally before informing the user about the previous interrupted run.
   - The notice is non-blocking and is acknowledged once it reaches the live Renderer.
   - Fatal errors in the current startup remain native and blocking because no usable Desktop exists.
   - Repeated restarts do not reproduce one old interruption indefinitely.
   
   ## Scope
   
   Move only the previous-run presentation out of the pre-boot native dialog. Keep the existing journal format, retention, redaction, and failure classification unchanged.
   
   Refs #3491 and #3543.
   
   </details>
   
   <details>
   <summary><strong>简体中文</strong></summary>
   
   ## 现象
   
   Desktop 上一次运行中断后，下一次执行 `npm run dev` 会在 Runtime Host 和 Renderer 启动前显示原生“Previous Maka session ended before shutdown completed”弹窗。如果在弹窗仍显示时停止或重启，本次进程也会留下 active recovery 记录，之后每次启动都可能再次遇到同一个阻塞弹窗。
   
   该现象已在多次重启中稳定出现。新建 Desktop profile 可以正常启动，且无需存在残留的本地 Electron 或 Runtime Host 进程。
   
   ## 根因
   
   #3543 为了在 Renderer 尚未启动时仍可复制诊断信息，选择在 Runtime Host 启动前展示恢复证据。这个顺序把仅用于告知的上次运行提示放进了本次启动的关键路径。pending 记录只有在弹窗完成后才删除，而本次运行此时已经写入新的 active journal。
   
   ## 预期行为
   
   - 恢复证据继续保持有界、本地、脱敏且可复制。
   - Desktop 应先正常启动和恢复，再告知用户上次运行曾中断。
   - 提示应为非阻塞，并在到达可用 Renderer 后只确认一次。
   - 当前启动本身发生 fatal error 时，仍保留原生阻塞错误，因为此时没有可用 Desktop。
   - 多次重启不应让同一条旧中断记录无限重复出现。
   
   ## 范围
   
   只把 previous-run 展示移出启动前的原生弹窗；不改变现有 journal 格式、保留期限、脱敏规则或故障分类。
   
   关联 #3491 与 #3543。
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org

Re: [I] fix(desktop): stop previous-session recovery from blocking repeated startup [maka]

["nagarwal-godaddy (via GitHub)" <gi...@apache.org>]

nagarwal-godaddy commented on issue #3804:
URL: https://github.com/apache/maka/issues/3804#issuecomment-5411876009

   Picking this up — approach: decouple previous-run evidence from the pre-boot native dialog, defer presentation to the live Renderer, acknowledge-on-delivery.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org

Re: [I] fix(desktop): stop previous-session recovery from blocking repeated startup [maka]

["Astro-Han (via GitHub)" <gi...@apache.org>]

Astro-Han closed issue #3804: fix(desktop): stop previous-session recovery from blocking repeated startup
URL: https://github.com/apache/maka/issues/3804


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org