You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Charles Reiss <wo...@gmail.com> on 2012/02/28 20:22:20 UTC

Review Request: make dist/make clean fixes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4086/
-----------------------------------------------------------

Review request for mesos and Benjamin Hindman.


Summary
-------

This patch fixes some problems discovered through 'make distclean'.


This addresses bug MESOS-120.
    https://issues.apache.org/jira/browse/MESOS-120


Diffs
-----

  src/Makefile.am a1ff40c 
  third_party/Makefile.am fdfb665 

Diff: https://reviews.apache.org/r/4086/diff


Testing
-------


Thanks,

Charles

Re: Review Request: make dist/make clean fixes

Posted by Benjamin Hindman <be...@berkeley.edu>.

> On 2012-02-29 06:54:32, Benjamin Hindman wrote:
> > third_party/Makefile.am, line 113
> > <https://reviews.apache.org/r/4086/diff/1/?file=86278#file86278line113>
> >
> >     When does this file not exist?
> 
> Charles Reiss wrote:
>     The clean-local target can be run as part of distclean (apparently after doing the distclean on the DIST_SUBDIRS).
> 
> Benjamin Hindman wrote:
>     Ah ha. Is the better thing to do here just add SUBDIRS = libprocess and remove the call into libprocess in the all-local target as well as the clean-local target?

FYI, making this change (and fixing a bug in the libprocess tests) I was able to run 'make distcheck'. I'll commit this unless you have any reservations.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4086/#review5445
-----------------------------------------------------------


On 2012-02-28 19:22:19, Charles Reiss wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4086/
> -----------------------------------------------------------
> 
> (Updated 2012-02-28 19:22:19)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Summary
> -------
> 
> This patch fixes some problems discovered through 'make distclean'.
> 
> 
> This addresses bug MESOS-120.
>     https://issues.apache.org/jira/browse/MESOS-120
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am a1ff40c 
>   third_party/Makefile.am fdfb665 
> 
> Diff: https://reviews.apache.org/r/4086/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Charles
> 
>

Re: Review Request: make dist/make clean fixes

Posted by Benjamin Hindman <be...@berkeley.edu>.

> On 2012-02-29 06:54:32, Benjamin Hindman wrote:
> > third_party/Makefile.am, line 113
> > <https://reviews.apache.org/r/4086/diff/1/?file=86278#file86278line113>
> >
> >     When does this file not exist?
> 
> Charles Reiss wrote:
>     The clean-local target can be run as part of distclean (apparently after doing the distclean on the DIST_SUBDIRS).

Ah ha. Is the better thing to do here just add SUBDIRS = libprocess and remove the call into libprocess in the all-local target as well as the clean-local target?


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4086/#review5445
-----------------------------------------------------------


On 2012-02-28 19:22:19, Charles Reiss wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4086/
> -----------------------------------------------------------
> 
> (Updated 2012-02-28 19:22:19)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Summary
> -------
> 
> This patch fixes some problems discovered through 'make distclean'.
> 
> 
> This addresses bug MESOS-120.
>     https://issues.apache.org/jira/browse/MESOS-120
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am a1ff40c 
>   third_party/Makefile.am fdfb665 
> 
> Diff: https://reviews.apache.org/r/4086/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Charles
> 
>

Re: Review Request: make dist/make clean fixes

Posted by Charles Reiss <wo...@gmail.com>.

> On 2012-02-29 06:54:32, Benjamin Hindman wrote:
> > third_party/Makefile.am, line 113
> > <https://reviews.apache.org/r/4086/diff/1/?file=86278#file86278line113>
> >
> >     When does this file not exist?

The clean-local target can be run as part of distclean (apparently after doing the distclean on the DIST_SUBDIRS).


- Charles


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4086/#review5445
-----------------------------------------------------------


On 2012-02-28 19:22:19, Charles Reiss wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4086/
> -----------------------------------------------------------
> 
> (Updated 2012-02-28 19:22:19)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Summary
> -------
> 
> This patch fixes some problems discovered through 'make distclean'.
> 
> 
> This addresses bug MESOS-120.
>     https://issues.apache.org/jira/browse/MESOS-120
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am a1ff40c 
>   third_party/Makefile.am fdfb665 
> 
> Diff: https://reviews.apache.org/r/4086/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Charles
> 
>

Re: Review Request: make dist/make clean fixes

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4086/#review5445
-----------------------------------------------------------



third_party/Makefile.am
<https://reviews.apache.org/r/4086/#comment11848>

    When does this file not exist?


- Benjamin


On 2012-02-28 19:22:19, Charles Reiss wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4086/
> -----------------------------------------------------------
> 
> (Updated 2012-02-28 19:22:19)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Summary
> -------
> 
> This patch fixes some problems discovered through 'make distclean'.
> 
> 
> This addresses bug MESOS-120.
>     https://issues.apache.org/jira/browse/MESOS-120
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am a1ff40c 
>   third_party/Makefile.am fdfb665 
> 
> Diff: https://reviews.apache.org/r/4086/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Charles
> 
>