You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Ron Dagostino <rn...@gmail.com> on 2022/12/12 20:13:17 UTC
Re: [DISCUSS] Apache Kafka 3.3.2
Hi Chris. https://github.com/apache/kafka/pull/12856 "KAFKA-14392:
KRaft broker heartbeat timeout should not exceed
broker.session.timeout.ms" just merged to trunk and seems like a
reasonable candidate for 3.3.2. Can it be included?
Ron
On Fri, Nov 18, 2022 at 10:57 AM Chris Egerton <ch...@aiven.io.invalid> wrote:
>
> Hi all,
>
> Here is the release plan for 3.3.2:
> https://cwiki.apache.org/confluence/display/KAFKA/Release+plan+3.3.2
>
> Currently there is one open blocker issue and one open non-blocker,
> non-critical issue. I plan to generate the first release candidate once the
> blocker issue is resolved, unless other blockers are raised in the meantime.
>
> Cheers,
>
> Chris
>
> On Thu, Nov 17, 2022 at 10:14 AM Bruno Cadonna <ca...@apache.org> wrote:
>
> > Thanks for volunteering!
> >
> > +1
> >
> > Best,
> > Bruno
> >
> > On 17.11.22 09:57, Luke Chen wrote:
> > > Thanks for volunteering!
> > >
> > > On Thu, Nov 17, 2022 at 1:07 AM José Armando García Sancio
> > > <js...@confluent.io.invalid> wrote:
> > >
> > >> +1. Thanks for volunteering.
> > >>
> > >> --
> > >> -José
> > >>
> > >
> >
Re: [DISCUSS] Apache Kafka 3.3.2
Posted by Chris Egerton <ch...@aiven.io.INVALID>.
Hi Kirk/Manikumar,
Thanks for raising KAFKA-14496 and for backporting its fix to the 3.3
branch. I agree that this should be included in 3.3.2.
Hi David,
Similarly, thank you for raising KAFKA-14532 and for backporting its fix to
the 3.3 branch. I agree that this, too, should be included in 3.3.2.
Hi José,
And lastly, thank you for raising KAFKA-14457. I agree that a fix should be
included in 3.3.2 and will attempt to cherry-pick today. If a merge
conflict or test failures occur, I'll reach out offline and see if you or
someone familiar with the fix can handle the backport.
Hi all,
Thanks to Kirk, Manikumar, David, and José for raising all of these issues
and working diligently to get fixes for them merged in time for 3.3.2. I
will be cancelling the vote thread for RC0 and beginning work on RC1 today
in order to include all of these fixes in the new release candidate.
José, would you mind lending a hand with system tests for RC1 like you did
with RC0?
Cheers,
Chris
On Wed, Dec 21, 2022 at 3:36 AM David Jacot <dj...@confluent.io.invalid>
wrote:
> Hi Chris,
>
> I have merged https://issues.apache.org/jira/browse/KAFKA-14532.
>
> Best,
> David
>
> On Tue, Dec 20, 2022 at 8:11 PM José Armando García Sancio
> <js...@confluent.io.invalid> wrote:
> >
> > Hi Chris,
> >
> > I am interested in including a bug fix for
> > https://issues.apache.org/jira/browse/KAFKA-14457 in the 3.3.2
> > release. The fix is here: https://github.com/apache/kafka/pull/12994.
> >
> > I think it is important to include this fix because some of the
> > controller metrics are inaccurate without this fix. This could impact
> > some users' ability to monitor the KRaft cluster.
> >
> > Fix is already merged to trunk and cherry-picked to 3.4.0.
> >
> > What do you think?
> >
> >
> > On Tue, Dec 20, 2022 at 4:52 AM David Jacot <dj...@confluent.io.invalid>
> wrote:
> > >
> > > Hi Chris,
> > >
> > > We just found a blocker for 3.3.2:
> > > https://issues.apache.org/jira/browse/KAFKA-14532. The PR is on the
> > > way.
> > >
> > > Best,
> > > David
> > >
> > > On Fri, Dec 16, 2022 at 3:35 PM Manikumar <ma...@gmail.com>
> wrote:
> > > >
> > > > Hi Chris,
> > > >
> > > > I have merged Kirk's PR for
> > > > https://issues.apache.org/jira/browse/KAFKA-14496 .
> > > > We would like to include this to the 3.3.2 release as this bug can
> cause
> > > > authentication Failures.
> > > >
> > > >
> > > > Thanks,
> > > >
> > > >
> > > > On Fri, Dec 16, 2022 at 4:28 AM Kirk True <ki...@kirktrue.pro> wrote:
> > > >
> > > > > Hi Chris,
> > > > >
> > > > > A bug was found with OAuth (
> > > > > https://issues.apache.org/jira/browse/KAFKA-14496) that we'd like
> to see
> > > > > included in the 3.3.2 release. I should be able to turn out a PR
> within the
> > > > > next 24 hours.
> > > > >
> > > > > Thanks,
> > > > > Kirk
> > > > >
> > > > > On Wed, Dec 14, 2022, at 4:10 PM, José Armando García Sancio wrote:
> > > > > > Hey Chris,
> > > > > >
> > > > > > Here are the results of just running the upgrade system tests on
> the
> > > > > > latest 3.3 branch:
> > > > > >
> > > > >
> http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/system-test-kafka-branch-builder--1671061000--apache--3.3--69fbaf2457/2022-12-14--001./2022-12-14--001./report.html
> > > > > >
> > > > > > Looks like the commit is now 69fbaf2457...
> > > > > >
> > > > > > Thanks
> > > > > > --
> > > > > > -José
> > > > > >
> > > > >
> >
> >
> >
> > --
> > -José
>
Re: [DISCUSS] Apache Kafka 3.3.2
Posted by David Jacot <dj...@confluent.io.INVALID>.
Hi Chris,
I have merged https://issues.apache.org/jira/browse/KAFKA-14532.
Best,
David
On Tue, Dec 20, 2022 at 8:11 PM José Armando García Sancio
<js...@confluent.io.invalid> wrote:
>
> Hi Chris,
>
> I am interested in including a bug fix for
> https://issues.apache.org/jira/browse/KAFKA-14457 in the 3.3.2
> release. The fix is here: https://github.com/apache/kafka/pull/12994.
>
> I think it is important to include this fix because some of the
> controller metrics are inaccurate without this fix. This could impact
> some users' ability to monitor the KRaft cluster.
>
> Fix is already merged to trunk and cherry-picked to 3.4.0.
>
> What do you think?
>
>
> On Tue, Dec 20, 2022 at 4:52 AM David Jacot <dj...@confluent.io.invalid> wrote:
> >
> > Hi Chris,
> >
> > We just found a blocker for 3.3.2:
> > https://issues.apache.org/jira/browse/KAFKA-14532. The PR is on the
> > way.
> >
> > Best,
> > David
> >
> > On Fri, Dec 16, 2022 at 3:35 PM Manikumar <ma...@gmail.com> wrote:
> > >
> > > Hi Chris,
> > >
> > > I have merged Kirk's PR for
> > > https://issues.apache.org/jira/browse/KAFKA-14496 .
> > > We would like to include this to the 3.3.2 release as this bug can cause
> > > authentication Failures.
> > >
> > >
> > > Thanks,
> > >
> > >
> > > On Fri, Dec 16, 2022 at 4:28 AM Kirk True <ki...@kirktrue.pro> wrote:
> > >
> > > > Hi Chris,
> > > >
> > > > A bug was found with OAuth (
> > > > https://issues.apache.org/jira/browse/KAFKA-14496) that we'd like to see
> > > > included in the 3.3.2 release. I should be able to turn out a PR within the
> > > > next 24 hours.
> > > >
> > > > Thanks,
> > > > Kirk
> > > >
> > > > On Wed, Dec 14, 2022, at 4:10 PM, José Armando García Sancio wrote:
> > > > > Hey Chris,
> > > > >
> > > > > Here are the results of just running the upgrade system tests on the
> > > > > latest 3.3 branch:
> > > > >
> > > > http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/system-test-kafka-branch-builder--1671061000--apache--3.3--69fbaf2457/2022-12-14--001./2022-12-14--001./report.html
> > > > >
> > > > > Looks like the commit is now 69fbaf2457...
> > > > >
> > > > > Thanks
> > > > > --
> > > > > -José
> > > > >
> > > >
>
>
>
> --
> -José
Re: [DISCUSS] Apache Kafka 3.3.2
Posted by José Armando García Sancio <js...@confluent.io.INVALID>.
Hi Chris,
I am interested in including a bug fix for
https://issues.apache.org/jira/browse/KAFKA-14457 in the 3.3.2
release. The fix is here: https://github.com/apache/kafka/pull/12994.
I think it is important to include this fix because some of the
controller metrics are inaccurate without this fix. This could impact
some users' ability to monitor the KRaft cluster.
Fix is already merged to trunk and cherry-picked to 3.4.0.
What do you think?
On Tue, Dec 20, 2022 at 4:52 AM David Jacot <dj...@confluent.io.invalid> wrote:
>
> Hi Chris,
>
> We just found a blocker for 3.3.2:
> https://issues.apache.org/jira/browse/KAFKA-14532. The PR is on the
> way.
>
> Best,
> David
>
> On Fri, Dec 16, 2022 at 3:35 PM Manikumar <ma...@gmail.com> wrote:
> >
> > Hi Chris,
> >
> > I have merged Kirk's PR for
> > https://issues.apache.org/jira/browse/KAFKA-14496 .
> > We would like to include this to the 3.3.2 release as this bug can cause
> > authentication Failures.
> >
> >
> > Thanks,
> >
> >
> > On Fri, Dec 16, 2022 at 4:28 AM Kirk True <ki...@kirktrue.pro> wrote:
> >
> > > Hi Chris,
> > >
> > > A bug was found with OAuth (
> > > https://issues.apache.org/jira/browse/KAFKA-14496) that we'd like to see
> > > included in the 3.3.2 release. I should be able to turn out a PR within the
> > > next 24 hours.
> > >
> > > Thanks,
> > > Kirk
> > >
> > > On Wed, Dec 14, 2022, at 4:10 PM, José Armando García Sancio wrote:
> > > > Hey Chris,
> > > >
> > > > Here are the results of just running the upgrade system tests on the
> > > > latest 3.3 branch:
> > > >
> > > http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/system-test-kafka-branch-builder--1671061000--apache--3.3--69fbaf2457/2022-12-14--001./2022-12-14--001./report.html
> > > >
> > > > Looks like the commit is now 69fbaf2457...
> > > >
> > > > Thanks
> > > > --
> > > > -José
> > > >
> > >
--
-José
Re: [DISCUSS] Apache Kafka 3.3.2
Posted by David Jacot <dj...@confluent.io.INVALID>.
Hi Chris,
We just found a blocker for 3.3.2:
https://issues.apache.org/jira/browse/KAFKA-14532. The PR is on the
way.
Best,
David
On Fri, Dec 16, 2022 at 3:35 PM Manikumar <ma...@gmail.com> wrote:
>
> Hi Chris,
>
> I have merged Kirk's PR for
> https://issues.apache.org/jira/browse/KAFKA-14496 .
> We would like to include this to the 3.3.2 release as this bug can cause
> authentication Failures.
>
>
> Thanks,
>
>
> On Fri, Dec 16, 2022 at 4:28 AM Kirk True <ki...@kirktrue.pro> wrote:
>
> > Hi Chris,
> >
> > A bug was found with OAuth (
> > https://issues.apache.org/jira/browse/KAFKA-14496) that we'd like to see
> > included in the 3.3.2 release. I should be able to turn out a PR within the
> > next 24 hours.
> >
> > Thanks,
> > Kirk
> >
> > On Wed, Dec 14, 2022, at 4:10 PM, José Armando García Sancio wrote:
> > > Hey Chris,
> > >
> > > Here are the results of just running the upgrade system tests on the
> > > latest 3.3 branch:
> > >
> > http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/system-test-kafka-branch-builder--1671061000--apache--3.3--69fbaf2457/2022-12-14--001./2022-12-14--001./report.html
> > >
> > > Looks like the commit is now 69fbaf2457...
> > >
> > > Thanks
> > > --
> > > -José
> > >
> >
Re: [DISCUSS] Apache Kafka 3.3.2
Posted by Manikumar <ma...@gmail.com>.
Hi Chris,
I have merged Kirk's PR for
https://issues.apache.org/jira/browse/KAFKA-14496 .
We would like to include this to the 3.3.2 release as this bug can cause
authentication Failures.
Thanks,
On Fri, Dec 16, 2022 at 4:28 AM Kirk True <ki...@kirktrue.pro> wrote:
> Hi Chris,
>
> A bug was found with OAuth (
> https://issues.apache.org/jira/browse/KAFKA-14496) that we'd like to see
> included in the 3.3.2 release. I should be able to turn out a PR within the
> next 24 hours.
>
> Thanks,
> Kirk
>
> On Wed, Dec 14, 2022, at 4:10 PM, José Armando García Sancio wrote:
> > Hey Chris,
> >
> > Here are the results of just running the upgrade system tests on the
> > latest 3.3 branch:
> >
> http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/system-test-kafka-branch-builder--1671061000--apache--3.3--69fbaf2457/2022-12-14--001./2022-12-14--001./report.html
> >
> > Looks like the commit is now 69fbaf2457...
> >
> > Thanks
> > --
> > -José
> >
>
Re: [DISCUSS] Apache Kafka 3.3.2
Posted by Kirk True <ki...@kirktrue.pro>.
Hi Chris,
A bug was found with OAuth (https://issues.apache.org/jira/browse/KAFKA-14496) that we'd like to see included in the 3.3.2 release. I should be able to turn out a PR within the next 24 hours.
Thanks,
Kirk
On Wed, Dec 14, 2022, at 4:10 PM, José Armando García Sancio wrote:
> Hey Chris,
>
> Here are the results of just running the upgrade system tests on the
> latest 3.3 branch:
> http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/system-test-kafka-branch-builder--1671061000--apache--3.3--69fbaf2457/2022-12-14--001./2022-12-14--001./report.html
>
> Looks like the commit is now 69fbaf2457...
>
> Thanks
> --
> -José
>
Re: [DISCUSS] Apache Kafka 3.3.2
Posted by José Armando García Sancio <js...@confluent.io.INVALID>.
Hey Chris,
Here are the results of just running the upgrade system tests on the
latest 3.3 branch:
http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/system-test-kafka-branch-builder--1671061000--apache--3.3--69fbaf2457/2022-12-14--001./2022-12-14--001./report.html
Looks like the commit is now 69fbaf2457...
Thanks
--
-José
Re: [DISCUSS] Apache Kafka 3.3.2
Posted by Chris Egerton <ch...@aiven.io.INVALID>.
Hi José,
Thanks for your help! I was able to locally rerun two of the three failed
tests and get passing results; the reports for them can be found at:
https://home.apache.org/~cegerton/system_tests/2022-12-14--015/report.html
(Connect REST test)
https://home.apache.org/~cegerton/system_tests/2022-12-14--016/report.html
(Consume bench test)
I still haven't been able to get a green run of the upgrade test, although
the cause of failure varied across runs. Is this test known to be
particularly flaky?
Cheers,
Chris
On Wed, Dec 14, 2022 at 1:36 PM José Armando García Sancio
<js...@confluent.io.invalid> wrote:
> Hey all,
>
> Here are the system test results for the 3.3 branch:
>
> https://eu01.z.antigena.com/l/Sx1FolWhf8d4T5FvVLnTK~tC4vADTaIz7lWjWml4UO3e6C-ymjdh8HOo-t~kEiLXcZLMkLT029Qe93L0YJU0AGLTWA-GpIMGZnlNZl~0ddmKP9Zwp-WtF4T0XBTGjc4FsrU4LV3x8fkIOgl9gH2qHb9jjh9XeSnCZ0S9GXdYwPwzoAIBNzC~5ZtASMc4T9DQBZvmrYF52BkZ9yC0ff1xl7YIzCZuYLoPt5KbWG4Ak8YQnS-eArBO9UgzanUOYJ585J7X-q7-DmREnRp9Rh
>
> The commit for that run is 22af3f29ced9e969c254004f592c06c8a45b84cc.
> It is also encoded in the URL above.
>
> Thanks
> --
> -José
>
>
Re: [DISCUSS] Apache Kafka 3.3.2
Posted by José Armando García Sancio <js...@confluent.io.INVALID>.
Hey all,
Here are the system test results for the 3.3 branch:
http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/system-test-kafka-branch-builder--1670984851--apache--3.3--22af3f29ce/2022-12-13--001./2022-12-13--001./report.html
The commit for that run is 22af3f29ced9e969c254004f592c06c8a45b84cc.
It is also encoded in the URL above.
Thanks
--
-José
Re: [DISCUSS] Apache Kafka 3.3.2
Posted by José Armando García Sancio <js...@confluent.io.INVALID>.
Thanks Chris!
I started a build for the system tests against the 3.3 branch using
Confluent's infrastructure. I'll reply here when the results are
avaialbe.
--
-José
Re: [DISCUSS] Apache Kafka 3.3.2
Posted by Chris Egerton <ch...@aiven.io.INVALID>.
Hi all (especially committers/PMC who have served as release manager
before),
I've created the first release candidate for 3.3.2 (
https://github.com/apache/kafka/tree/3.3.2-rc0) and am almost ready to
start a vote on it, but I haven't run system tests for it yet. I've tried
to kick off a run on my laptop but it's looking like that'll take over
three days to complete.
Is there a way to run system tests with Apache infra?
Cheers,
Chris
On Mon, Dec 12, 2022 at 3:38 PM Chris Egerton <ch...@aiven.io> wrote:
> Hi Ron,
>
> You're in luck, I was just about to start generating a release candidate!
> I'm fine with including the fix for KAFKA-14392 in 3.3.2.
>
> Cheers,
>
> Chris
>
> On Mon, Dec 12, 2022 at 3:13 PM Ron Dagostino <rn...@gmail.com> wrote:
>
>> Hi Chris.
>> https://eu01.z.antigena.com/l/dqC_AcOJullnCjJyPkdUEcH~mlZJ_G4H3YPEhXpPTMmRSGrk0C1f0T9~HsI-s~rWNCsHZeFaeszMvB9IcRqFW5cOurAQOujb16I131DBYS8hqSgkRzMObK~uLAEWmiiYylZ3O-dcWjZ3uoAZKBo~C4OQ_ss75P8ZD33vBZk5EPvm5v9A7m
>> "KAFKA-14392:
>> KRaft broker heartbeat timeout should not exceed
>>
>> https://eu01.z.antigena.com/l/-fHpsBqhAAaRHbr4QA2u~gvgCwjZcrATMwVm1qlTDl2fxTz3zpltpk~SIoRNlSFK44G1KBzHFM5AJTZWMcokxQVSWoBYvxEfuOoLwejDaAS~1jVupYN1YjBg8HirYS59h735N~GgNyEAuqYikpj41hwGgZbuozVJywAGGh
>> " just merged to trunk and seems like a
>> reasonable candidate for 3.3.2. Can it be included?
>>
>> Ron
>>
>> On Fri, Nov 18, 2022 at 10:57 AM Chris Egerton <ch...@aiven.io.invalid>
>> wrote:
>> >
>> > Hi all,
>> >
>> > Here is the release plan for 3.3.2:
>> >
>> https://eu01.z.antigena.com/l/FwWAibomRqqG798j~nU0I_F4V5giCOjaYI4rb88d~D7v9qm9oJhFLtWDr1W24QSwgJTmKVwF4ULU6XGtuAgEN_aDONVSOSExp-rwvuJTPMW8uw6sAqi8o4tOzZLDqDDaBPz6twuQZAJGcWRioMgwIDajrwpHhryG9zXf1ex5Mx9TMjF0vuzJ0LsUKpPUeRQz_EidLaiV6AY1yfmH
>> >
>> > Currently there is one open blocker issue and one open non-blocker,
>> > non-critical issue. I plan to generate the first release candidate once
>> the
>> > blocker issue is resolved, unless other blockers are raised in the
>> meantime.
>> >
>> > Cheers,
>> >
>> > Chris
>> >
>> > On Thu, Nov 17, 2022 at 10:14 AM Bruno Cadonna <ca...@apache.org>
>> wrote:
>> >
>> > > Thanks for volunteering!
>> > >
>> > > +1
>> > >
>> > > Best,
>> > > Bruno
>> > >
>> > > On 17.11.22 09:57, Luke Chen wrote:
>> > > > Thanks for volunteering!
>> > > >
>> > > > On Thu, Nov 17, 2022 at 1:07 AM José Armando García Sancio
>> > > > <js...@confluent.io.invalid> wrote:
>> > > >
>> > > >> +1. Thanks for volunteering.
>> > > >>
>> > > >> --
>> > > >> -José
>> > > >>
>> > > >
>> > >
>>
>>
Re: [DISCUSS] Apache Kafka 3.3.2
Posted by Chris Egerton <ch...@aiven.io.INVALID>.
Hi Ron,
You're in luck, I was just about to start generating a release candidate!
I'm fine with including the fix for KAFKA-14392 in 3.3.2.
Cheers,
Chris
On Mon, Dec 12, 2022 at 3:13 PM Ron Dagostino <rn...@gmail.com> wrote:
> Hi Chris.
> https://eu01.z.antigena.com/l/dqC_AcOJullnCjJyPkdUEcH~mlZJ_G4H3YPEhXpPTMmRSGrk0C1f0T9~HsI-s~rWNCsHZeFaeszMvB9IcRqFW5cOurAQOujb16I131DBYS8hqSgkRzMObK~uLAEWmiiYylZ3O-dcWjZ3uoAZKBo~C4OQ_ss75P8ZD33vBZk5EPvm5v9A7m
> "KAFKA-14392:
> KRaft broker heartbeat timeout should not exceed
>
> https://eu01.z.antigena.com/l/-fHpsBqhAAaRHbr4QA2u~gvgCwjZcrATMwVm1qlTDl2fxTz3zpltpk~SIoRNlSFK44G1KBzHFM5AJTZWMcokxQVSWoBYvxEfuOoLwejDaAS~1jVupYN1YjBg8HirYS59h735N~GgNyEAuqYikpj41hwGgZbuozVJywAGGh
> " just merged to trunk and seems like a
> reasonable candidate for 3.3.2. Can it be included?
>
> Ron
>
> On Fri, Nov 18, 2022 at 10:57 AM Chris Egerton <ch...@aiven.io.invalid>
> wrote:
> >
> > Hi all,
> >
> > Here is the release plan for 3.3.2:
> >
> https://eu01.z.antigena.com/l/FwWAibomRqqG798j~nU0I_F4V5giCOjaYI4rb88d~D7v9qm9oJhFLtWDr1W24QSwgJTmKVwF4ULU6XGtuAgEN_aDONVSOSExp-rwvuJTPMW8uw6sAqi8o4tOzZLDqDDaBPz6twuQZAJGcWRioMgwIDajrwpHhryG9zXf1ex5Mx9TMjF0vuzJ0LsUKpPUeRQz_EidLaiV6AY1yfmH
> >
> > Currently there is one open blocker issue and one open non-blocker,
> > non-critical issue. I plan to generate the first release candidate once
> the
> > blocker issue is resolved, unless other blockers are raised in the
> meantime.
> >
> > Cheers,
> >
> > Chris
> >
> > On Thu, Nov 17, 2022 at 10:14 AM Bruno Cadonna <ca...@apache.org>
> wrote:
> >
> > > Thanks for volunteering!
> > >
> > > +1
> > >
> > > Best,
> > > Bruno
> > >
> > > On 17.11.22 09:57, Luke Chen wrote:
> > > > Thanks for volunteering!
> > > >
> > > > On Thu, Nov 17, 2022 at 1:07 AM José Armando García Sancio
> > > > <js...@confluent.io.invalid> wrote:
> > > >
> > > >> +1. Thanks for volunteering.
> > > >>
> > > >> --
> > > >> -José
> > > >>
> > > >
> > >
>
>