You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Radhika Jandhyala via Review Board <no...@reviews.apache.org> on 2018/05/30 19:25:00 UTC
Review Request 67394: White list fds that child processes can inherit
in mesos containerizer.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67394/
-----------------------------------------------------------
Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jie Yu, and Li Li.
Repository: mesos
Description
-------
White list fds that child processes can inherit in mesos containerizer.
Diffs
-----
src/slave/containerizer/mesos/containerizer.cpp eac1d16f2388385fec04ff8f013ce0ebf4e97f0f
src/slave/containerizer/mesos/launcher.hpp f69d934d2e1a129e10df8c7f5c78723e832adc7d
src/slave/containerizer/mesos/launcher.cpp 2fe47d368cb82a46328e1f636baa836272db244c
src/slave/containerizer/mesos/linux_launcher.hpp 0ea9b875ae46cadea483bc8dd8bf4907fd324dc9
src/slave/containerizer/mesos/linux_launcher.cpp 80e444501e429c1e1ae354abcd51f86430316ada
src/tests/containerizer/launcher.hpp a8e436f164b67d937ebcff35e084d3ca755c003c
src/tests/containerizer/launcher.cpp a92d9890f0931425d69ef8ce0896d081b8722079
src/tests/containerizer/mesos_containerizer_tests.cpp 01f2b38cfa67b144298c361e92170322864ac201
Diff: https://reviews.apache.org/r/67394/diff/1/
Testing
-------
Thanks,
Radhika Jandhyala
Re: Review Request 67394: White list fds that child processes can
inherit in mesos containerizer.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67394/#review204078
-----------------------------------------------------------
PASS: Mesos patch 67394 was successfully built and tested.
Reviews applied: `['67286', '67287', '67394']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67394
- Mesos Reviewbot Windows
On May 30, 2018, 7:25 p.m., Radhika Jandhyala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67394/
> -----------------------------------------------------------
>
> (Updated May 30, 2018, 7:25 p.m.)
>
>
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jie Yu, and Li Li.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> White list fds that child processes can inherit in mesos containerizer.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp eac1d16f2388385fec04ff8f013ce0ebf4e97f0f
> src/slave/containerizer/mesos/launcher.hpp f69d934d2e1a129e10df8c7f5c78723e832adc7d
> src/slave/containerizer/mesos/launcher.cpp 2fe47d368cb82a46328e1f636baa836272db244c
> src/slave/containerizer/mesos/linux_launcher.hpp 0ea9b875ae46cadea483bc8dd8bf4907fd324dc9
> src/slave/containerizer/mesos/linux_launcher.cpp 80e444501e429c1e1ae354abcd51f86430316ada
> src/tests/containerizer/launcher.hpp a8e436f164b67d937ebcff35e084d3ca755c003c
> src/tests/containerizer/launcher.cpp a92d9890f0931425d69ef8ce0896d081b8722079
> src/tests/containerizer/mesos_containerizer_tests.cpp 01f2b38cfa67b144298c361e92170322864ac201
>
>
> Diff: https://reviews.apache.org/r/67394/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Radhika Jandhyala
>
>
Re: Review Request 67394: White list fds that child processes can
inherit in mesos containerizer.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67394/#review204082
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67286, 67287, 67394]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 30, 2018, 7:25 p.m., Radhika Jandhyala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67394/
> -----------------------------------------------------------
>
> (Updated May 30, 2018, 7:25 p.m.)
>
>
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jie Yu, and Li Li.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> White list fds that child processes can inherit in mesos containerizer.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp eac1d16f2388385fec04ff8f013ce0ebf4e97f0f
> src/slave/containerizer/mesos/launcher.hpp f69d934d2e1a129e10df8c7f5c78723e832adc7d
> src/slave/containerizer/mesos/launcher.cpp 2fe47d368cb82a46328e1f636baa836272db244c
> src/slave/containerizer/mesos/linux_launcher.hpp 0ea9b875ae46cadea483bc8dd8bf4907fd324dc9
> src/slave/containerizer/mesos/linux_launcher.cpp 80e444501e429c1e1ae354abcd51f86430316ada
> src/tests/containerizer/launcher.hpp a8e436f164b67d937ebcff35e084d3ca755c003c
> src/tests/containerizer/launcher.cpp a92d9890f0931425d69ef8ce0896d081b8722079
> src/tests/containerizer/mesos_containerizer_tests.cpp 01f2b38cfa67b144298c361e92170322864ac201
>
>
> Diff: https://reviews.apache.org/r/67394/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Radhika Jandhyala
>
>
Re: Review Request 67394: White list fds that child processes can
inherit in mesos containerizer.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On June 11, 2018, 9:52 a.m., Andrew Schwartzmeyer wrote:
> > src/tests/containerizer/launcher.hpp
> > Lines 59-72 (original), 59-82 (patched)
> > <https://reviews.apache.org/r/67394/diff/1/?file=2032328#file2032328line59>
> >
> > I'm not sure I follow; why do we need this entire change instead of just `s/10/9`, adding `whiteListFds`, and changing to `containerIO`?
Dropping because the answer is that Google Mock cannot mock a function with default arguments.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67394/#review204549
-----------------------------------------------------------
On May 31, 2018, 3:50 p.m., Radhika Jandhyala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67394/
> -----------------------------------------------------------
>
> (Updated May 31, 2018, 3:50 p.m.)
>
>
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jie Yu, and Li Li.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> White list fds that child processes can inherit in mesos containerizer.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp eac1d16f2388385fec04ff8f013ce0ebf4e97f0f
> src/slave/containerizer/mesos/launcher.hpp f69d934d2e1a129e10df8c7f5c78723e832adc7d
> src/slave/containerizer/mesos/launcher.cpp 2fe47d368cb82a46328e1f636baa836272db244c
> src/slave/containerizer/mesos/linux_launcher.hpp 0ea9b875ae46cadea483bc8dd8bf4907fd324dc9
> src/slave/containerizer/mesos/linux_launcher.cpp 80e444501e429c1e1ae354abcd51f86430316ada
> src/tests/containerizer/launcher.hpp a8e436f164b67d937ebcff35e084d3ca755c003c
> src/tests/containerizer/launcher.cpp a92d9890f0931425d69ef8ce0896d081b8722079
> src/tests/containerizer/mesos_containerizer_tests.cpp 01f2b38cfa67b144298c361e92170322864ac201
>
>
> Diff: https://reviews.apache.org/r/67394/diff/1/
>
>
> Testing
> -------
>
> All mesos tests on windows
>
>
> Thanks,
>
> Radhika Jandhyala
>
>
Re: Review Request 67394: White list fds that child processes can
inherit in mesos containerizer.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67394/#review204549
-----------------------------------------------------------
src/slave/containerizer/mesos/launcher.hpp
Lines 73 (patched)
<https://reviews.apache.org/r/67394/#comment287111>
`= {}`
src/slave/containerizer/mesos/launcher.hpp
Lines 110 (patched)
<https://reviews.apache.org/r/67394/#comment287112>
`= {}`
src/slave/containerizer/mesos/linux_launcher.hpp
Lines 60 (patched)
<https://reviews.apache.org/r/67394/#comment287107>
`= {}`
src/slave/containerizer/mesos/linux_launcher.cpp
Lines 82 (patched)
<https://reviews.apache.org/r/67394/#comment287108>
Ditto.
src/tests/containerizer/launcher.hpp
Lines 59-72 (original), 59-82 (patched)
<https://reviews.apache.org/r/67394/#comment287110>
I'm not sure I follow; why do we need this entire change instead of just `s/10/9`, adding `whiteListFds`, and changing to `containerIO`?
src/tests/containerizer/mesos_containerizer_tests.cpp
Lines 1338-1344 (original), 1338-1343 (patched)
<https://reviews.apache.org/r/67394/#comment287109>
Does `containerIO` default construct with stdin/out/err set to valid file descriptors?
- Andrew Schwartzmeyer
On May 31, 2018, 3:50 p.m., Radhika Jandhyala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67394/
> -----------------------------------------------------------
>
> (Updated May 31, 2018, 3:50 p.m.)
>
>
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jie Yu, and Li Li.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> White list fds that child processes can inherit in mesos containerizer.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp eac1d16f2388385fec04ff8f013ce0ebf4e97f0f
> src/slave/containerizer/mesos/launcher.hpp f69d934d2e1a129e10df8c7f5c78723e832adc7d
> src/slave/containerizer/mesos/launcher.cpp 2fe47d368cb82a46328e1f636baa836272db244c
> src/slave/containerizer/mesos/linux_launcher.hpp 0ea9b875ae46cadea483bc8dd8bf4907fd324dc9
> src/slave/containerizer/mesos/linux_launcher.cpp 80e444501e429c1e1ae354abcd51f86430316ada
> src/tests/containerizer/launcher.hpp a8e436f164b67d937ebcff35e084d3ca755c003c
> src/tests/containerizer/launcher.cpp a92d9890f0931425d69ef8ce0896d081b8722079
> src/tests/containerizer/mesos_containerizer_tests.cpp 01f2b38cfa67b144298c361e92170322864ac201
>
>
> Diff: https://reviews.apache.org/r/67394/diff/1/
>
>
> Testing
> -------
>
> All mesos tests on windows
>
>
> Thanks,
>
> Radhika Jandhyala
>
>
Re: Review Request 67394: White list fds that child processes can
inherit in mesos containerizer.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67394/#review204736
-----------------------------------------------------------
PASS: Mesos patch 67394 was successfully built and tested.
Reviews applied: `['67286', '67287', '67394']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67394
- Mesos Reviewbot Windows
On June 13, 2018, 6:36 p.m., Radhika Jandhyala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67394/
> -----------------------------------------------------------
>
> (Updated June 13, 2018, 6:36 p.m.)
>
>
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jie Yu, and Li Li.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> White list fds that child processes can inherit in mesos containerizer.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 17a1a3762b2012ff875e4da9c9d4622514e48051
> src/slave/containerizer/mesos/launcher.hpp 4b5ae730026fbb6054b390d79bb79a9cbad64485
> src/slave/containerizer/mesos/launcher.cpp 9df05f3f8b3c989989e9421e90d4ca6571fc819f
> src/slave/containerizer/mesos/linux_launcher.hpp 4c5cdd126e6916130f40d12ccc7a4c51ad6b56ab
> src/slave/containerizer/mesos/linux_launcher.cpp 9ce5fbf9cbf961eece12c5d336d356727b251290
> src/tests/containerizer/launcher.hpp 776cb35a2eb05a0b65bdded44cd071038d30f882
> src/tests/containerizer/launcher.cpp a92d9890f0931425d69ef8ce0896d081b8722079
> src/tests/containerizer/mesos_containerizer_tests.cpp 362d9fb522817332da1fdf5ea4afd6bc2402005c
>
>
> Diff: https://reviews.apache.org/r/67394/diff/4/
>
>
> Testing
> -------
>
> All mesos tests on windows
>
>
> Thanks,
>
> Radhika Jandhyala
>
>
Re: Review Request 67394: White list fds that child processes can
inherit in mesos containerizer.
Posted by Radhika Jandhyala via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67394/
-----------------------------------------------------------
(Updated June 13, 2018, 6:36 p.m.)
Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jie Yu, and Li Li.
Changes
-------
Rebase
Repository: mesos
Description
-------
White list fds that child processes can inherit in mesos containerizer.
Diffs (updated)
-----
src/slave/containerizer/mesos/containerizer.cpp 17a1a3762b2012ff875e4da9c9d4622514e48051
src/slave/containerizer/mesos/launcher.hpp 4b5ae730026fbb6054b390d79bb79a9cbad64485
src/slave/containerizer/mesos/launcher.cpp 9df05f3f8b3c989989e9421e90d4ca6571fc819f
src/slave/containerizer/mesos/linux_launcher.hpp 4c5cdd126e6916130f40d12ccc7a4c51ad6b56ab
src/slave/containerizer/mesos/linux_launcher.cpp 9ce5fbf9cbf961eece12c5d336d356727b251290
src/tests/containerizer/launcher.hpp 776cb35a2eb05a0b65bdded44cd071038d30f882
src/tests/containerizer/launcher.cpp a92d9890f0931425d69ef8ce0896d081b8722079
src/tests/containerizer/mesos_containerizer_tests.cpp 362d9fb522817332da1fdf5ea4afd6bc2402005c
Diff: https://reviews.apache.org/r/67394/diff/4/
Changes: https://reviews.apache.org/r/67394/diff/3-4/
Testing
-------
All mesos tests on windows
Thanks,
Radhika Jandhyala
Re: Review Request 67394: White list fds that child processes can
inherit in mesos containerizer.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On June 12, 2018, 5:23 p.m., Mesos Reviewbot Windows wrote:
> > FAIL: Failed to apply the current review.
> >
> > Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 67394`
> >
> > All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67394
> >
> > Relevant logs:
> >
> > - [apply-review-67394-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67394/logs/apply-review-67394-stdout.log):
> >
> > ```
> > error: patch failed: src/tests/containerizer/launcher.hpp:56
> > error: src/tests/containerizer/launcher.hpp: patch does not apply
> > ```
Wait this still failed?
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67394/#review204648
-----------------------------------------------------------
On June 12, 2018, 3:56 p.m., Radhika Jandhyala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67394/
> -----------------------------------------------------------
>
> (Updated June 12, 2018, 3:56 p.m.)
>
>
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jie Yu, and Li Li.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> White list fds that child processes can inherit in mesos containerizer.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp eac1d16f2388385fec04ff8f013ce0ebf4e97f0f
> src/slave/containerizer/mesos/launcher.hpp f69d934d2e1a129e10df8c7f5c78723e832adc7d
> src/slave/containerizer/mesos/launcher.cpp 2fe47d368cb82a46328e1f636baa836272db244c
> src/slave/containerizer/mesos/linux_launcher.hpp 0ea9b875ae46cadea483bc8dd8bf4907fd324dc9
> src/slave/containerizer/mesos/linux_launcher.cpp 80e444501e429c1e1ae354abcd51f86430316ada
> src/tests/containerizer/launcher.hpp a8e436f164b67d937ebcff35e084d3ca755c003c
> src/tests/containerizer/launcher.cpp a92d9890f0931425d69ef8ce0896d081b8722079
> src/tests/containerizer/mesos_containerizer_tests.cpp 01f2b38cfa67b144298c361e92170322864ac201
>
>
> Diff: https://reviews.apache.org/r/67394/diff/3/
>
>
> Testing
> -------
>
> All mesos tests on windows
>
>
> Thanks,
>
> Radhika Jandhyala
>
>
Re: Review Request 67394: White list fds that child processes can
inherit in mesos containerizer.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67394/#review204648
-----------------------------------------------------------
FAIL: Failed to apply the current review.
Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 67394`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67394
Relevant logs:
- [apply-review-67394-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67394/logs/apply-review-67394-stdout.log):
```
error: patch failed: src/tests/containerizer/launcher.hpp:56
error: src/tests/containerizer/launcher.hpp: patch does not apply
```
- Mesos Reviewbot Windows
On June 12, 2018, 3:56 p.m., Radhika Jandhyala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67394/
> -----------------------------------------------------------
>
> (Updated June 12, 2018, 3:56 p.m.)
>
>
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jie Yu, and Li Li.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> White list fds that child processes can inherit in mesos containerizer.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp eac1d16f2388385fec04ff8f013ce0ebf4e97f0f
> src/slave/containerizer/mesos/launcher.hpp f69d934d2e1a129e10df8c7f5c78723e832adc7d
> src/slave/containerizer/mesos/launcher.cpp 2fe47d368cb82a46328e1f636baa836272db244c
> src/slave/containerizer/mesos/linux_launcher.hpp 0ea9b875ae46cadea483bc8dd8bf4907fd324dc9
> src/slave/containerizer/mesos/linux_launcher.cpp 80e444501e429c1e1ae354abcd51f86430316ada
> src/tests/containerizer/launcher.hpp a8e436f164b67d937ebcff35e084d3ca755c003c
> src/tests/containerizer/launcher.cpp a92d9890f0931425d69ef8ce0896d081b8722079
> src/tests/containerizer/mesos_containerizer_tests.cpp 01f2b38cfa67b144298c361e92170322864ac201
>
>
> Diff: https://reviews.apache.org/r/67394/diff/3/
>
>
> Testing
> -------
>
> All mesos tests on windows
>
>
> Thanks,
>
> Radhika Jandhyala
>
>
Re: Review Request 67394: White list fds that child processes can
inherit in mesos containerizer.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67394/#review204718
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Schwartzmeyer
On June 12, 2018, 3:56 p.m., Radhika Jandhyala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67394/
> -----------------------------------------------------------
>
> (Updated June 12, 2018, 3:56 p.m.)
>
>
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jie Yu, and Li Li.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> White list fds that child processes can inherit in mesos containerizer.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp eac1d16f2388385fec04ff8f013ce0ebf4e97f0f
> src/slave/containerizer/mesos/launcher.hpp f69d934d2e1a129e10df8c7f5c78723e832adc7d
> src/slave/containerizer/mesos/launcher.cpp 2fe47d368cb82a46328e1f636baa836272db244c
> src/slave/containerizer/mesos/linux_launcher.hpp 0ea9b875ae46cadea483bc8dd8bf4907fd324dc9
> src/slave/containerizer/mesos/linux_launcher.cpp 80e444501e429c1e1ae354abcd51f86430316ada
> src/tests/containerizer/launcher.hpp a8e436f164b67d937ebcff35e084d3ca755c003c
> src/tests/containerizer/launcher.cpp a92d9890f0931425d69ef8ce0896d081b8722079
> src/tests/containerizer/mesos_containerizer_tests.cpp 01f2b38cfa67b144298c361e92170322864ac201
>
>
> Diff: https://reviews.apache.org/r/67394/diff/3/
>
>
> Testing
> -------
>
> All mesos tests on windows
>
>
> Thanks,
>
> Radhika Jandhyala
>
>
Re: Review Request 67394: White list fds that child processes can
inherit in mesos containerizer.
Posted by Radhika Jandhyala via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67394/
-----------------------------------------------------------
(Updated June 12, 2018, 10:56 p.m.)
Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jie Yu, and Li Li.
Repository: mesos
Description
-------
White list fds that child processes can inherit in mesos containerizer.
Diffs (updated)
-----
src/slave/containerizer/mesos/containerizer.cpp eac1d16f2388385fec04ff8f013ce0ebf4e97f0f
src/slave/containerizer/mesos/launcher.hpp f69d934d2e1a129e10df8c7f5c78723e832adc7d
src/slave/containerizer/mesos/launcher.cpp 2fe47d368cb82a46328e1f636baa836272db244c
src/slave/containerizer/mesos/linux_launcher.hpp 0ea9b875ae46cadea483bc8dd8bf4907fd324dc9
src/slave/containerizer/mesos/linux_launcher.cpp 80e444501e429c1e1ae354abcd51f86430316ada
src/tests/containerizer/launcher.hpp a8e436f164b67d937ebcff35e084d3ca755c003c
src/tests/containerizer/launcher.cpp a92d9890f0931425d69ef8ce0896d081b8722079
src/tests/containerizer/mesos_containerizer_tests.cpp 01f2b38cfa67b144298c361e92170322864ac201
Diff: https://reviews.apache.org/r/67394/diff/3/
Changes: https://reviews.apache.org/r/67394/diff/2-3/
Testing
-------
All mesos tests on windows
Thanks,
Radhika Jandhyala
Re: Review Request 67394: White list fds that child processes can
inherit in mesos containerizer.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67394/#review204644
-----------------------------------------------------------
FAIL: Failed to apply the current review.
Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 67394`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67394
Relevant logs:
- [apply-review-67394-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67394/logs/apply-review-67394-stdout.log):
```
error: patch failed: src/tests/containerizer/launcher.hpp:56
error: src/tests/containerizer/launcher.hpp: patch does not apply
```
- Mesos Reviewbot Windows
On June 12, 2018, 2:07 p.m., Radhika Jandhyala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67394/
> -----------------------------------------------------------
>
> (Updated June 12, 2018, 2:07 p.m.)
>
>
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jie Yu, and Li Li.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> White list fds that child processes can inherit in mesos containerizer.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp eac1d16f2388385fec04ff8f013ce0ebf4e97f0f
> src/slave/containerizer/mesos/launcher.hpp f69d934d2e1a129e10df8c7f5c78723e832adc7d
> src/slave/containerizer/mesos/launcher.cpp 2fe47d368cb82a46328e1f636baa836272db244c
> src/slave/containerizer/mesos/linux_launcher.hpp 0ea9b875ae46cadea483bc8dd8bf4907fd324dc9
> src/slave/containerizer/mesos/linux_launcher.cpp 80e444501e429c1e1ae354abcd51f86430316ada
> src/tests/containerizer/launcher.hpp a8e436f164b67d937ebcff35e084d3ca755c003c
> src/tests/containerizer/launcher.cpp a92d9890f0931425d69ef8ce0896d081b8722079
> src/tests/containerizer/mesos_containerizer_tests.cpp 01f2b38cfa67b144298c361e92170322864ac201
>
>
> Diff: https://reviews.apache.org/r/67394/diff/2/
>
>
> Testing
> -------
>
> All mesos tests on windows
>
>
> Thanks,
>
> Radhika Jandhyala
>
>
Re: Review Request 67394: White list fds that child processes can
inherit in mesos containerizer.
Posted by Radhika Jandhyala via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67394/
-----------------------------------------------------------
(Updated June 12, 2018, 9:07 p.m.)
Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jie Yu, and Li Li.
Repository: mesos
Description
-------
White list fds that child processes can inherit in mesos containerizer.
Diffs (updated)
-----
src/slave/containerizer/mesos/containerizer.cpp eac1d16f2388385fec04ff8f013ce0ebf4e97f0f
src/slave/containerizer/mesos/launcher.hpp f69d934d2e1a129e10df8c7f5c78723e832adc7d
src/slave/containerizer/mesos/launcher.cpp 2fe47d368cb82a46328e1f636baa836272db244c
src/slave/containerizer/mesos/linux_launcher.hpp 0ea9b875ae46cadea483bc8dd8bf4907fd324dc9
src/slave/containerizer/mesos/linux_launcher.cpp 80e444501e429c1e1ae354abcd51f86430316ada
src/tests/containerizer/launcher.hpp a8e436f164b67d937ebcff35e084d3ca755c003c
src/tests/containerizer/launcher.cpp a92d9890f0931425d69ef8ce0896d081b8722079
src/tests/containerizer/mesos_containerizer_tests.cpp 01f2b38cfa67b144298c361e92170322864ac201
Diff: https://reviews.apache.org/r/67394/diff/2/
Changes: https://reviews.apache.org/r/67394/diff/1-2/
Testing
-------
All mesos tests on windows
Thanks,
Radhika Jandhyala
Re: Review Request 67394: White list fds that child processes can
inherit in mesos containerizer.
Posted by Akash Gupta <ak...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67394/#review204523
-----------------------------------------------------------
src/tests/containerizer/launcher.hpp
Line 60 (original), 60 (patched)
<https://reviews.apache.org/r/67394/#comment287066>
Just curious but why is `forkImpl` needed instead of the old way?
- Akash Gupta
On May 31, 2018, 10:50 p.m., Radhika Jandhyala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67394/
> -----------------------------------------------------------
>
> (Updated May 31, 2018, 10:50 p.m.)
>
>
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jie Yu, and Li Li.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> White list fds that child processes can inherit in mesos containerizer.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp eac1d16f2388385fec04ff8f013ce0ebf4e97f0f
> src/slave/containerizer/mesos/launcher.hpp f69d934d2e1a129e10df8c7f5c78723e832adc7d
> src/slave/containerizer/mesos/launcher.cpp 2fe47d368cb82a46328e1f636baa836272db244c
> src/slave/containerizer/mesos/linux_launcher.hpp 0ea9b875ae46cadea483bc8dd8bf4907fd324dc9
> src/slave/containerizer/mesos/linux_launcher.cpp 80e444501e429c1e1ae354abcd51f86430316ada
> src/tests/containerizer/launcher.hpp a8e436f164b67d937ebcff35e084d3ca755c003c
> src/tests/containerizer/launcher.cpp a92d9890f0931425d69ef8ce0896d081b8722079
> src/tests/containerizer/mesos_containerizer_tests.cpp 01f2b38cfa67b144298c361e92170322864ac201
>
>
> Diff: https://reviews.apache.org/r/67394/diff/1/
>
>
> Testing
> -------
>
> All mesos tests on windows
>
>
> Thanks,
>
> Radhika Jandhyala
>
>
Re: Review Request 67394: White list fds that child processes can
inherit in mesos containerizer.
Posted by Radhika Jandhyala via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67394/
-----------------------------------------------------------
(Updated May 31, 2018, 10:50 p.m.)
Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jie Yu, and Li Li.
Repository: mesos
Description
-------
White list fds that child processes can inherit in mesos containerizer.
Diffs
-----
src/slave/containerizer/mesos/containerizer.cpp eac1d16f2388385fec04ff8f013ce0ebf4e97f0f
src/slave/containerizer/mesos/launcher.hpp f69d934d2e1a129e10df8c7f5c78723e832adc7d
src/slave/containerizer/mesos/launcher.cpp 2fe47d368cb82a46328e1f636baa836272db244c
src/slave/containerizer/mesos/linux_launcher.hpp 0ea9b875ae46cadea483bc8dd8bf4907fd324dc9
src/slave/containerizer/mesos/linux_launcher.cpp 80e444501e429c1e1ae354abcd51f86430316ada
src/tests/containerizer/launcher.hpp a8e436f164b67d937ebcff35e084d3ca755c003c
src/tests/containerizer/launcher.cpp a92d9890f0931425d69ef8ce0896d081b8722079
src/tests/containerizer/mesos_containerizer_tests.cpp 01f2b38cfa67b144298c361e92170322864ac201
Diff: https://reviews.apache.org/r/67394/diff/1/
Testing (updated)
-------
All mesos tests on windows
Thanks,
Radhika Jandhyala