You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by on...@apache.org on 2016/06/11 00:42:57 UTC

svn commit: r1747825 - in /poi/trunk/src/java/org/apache/poi/ss/formula/udf: AggregatingUDFFinder.java DefaultUDFFinder.java IndexedUDFFinder.java UDFFinder.java

Author: onealj
Date: Sat Jun 11 00:42:57 2016
New Revision: 1747825

URL: http://svn.apache.org/viewvc?rev=1747825&view=rev
Log:
add @Override annotations

Modified:
    poi/trunk/src/java/org/apache/poi/ss/formula/udf/AggregatingUDFFinder.java
    poi/trunk/src/java/org/apache/poi/ss/formula/udf/DefaultUDFFinder.java
    poi/trunk/src/java/org/apache/poi/ss/formula/udf/IndexedUDFFinder.java
    poi/trunk/src/java/org/apache/poi/ss/formula/udf/UDFFinder.java

Modified: poi/trunk/src/java/org/apache/poi/ss/formula/udf/AggregatingUDFFinder.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/formula/udf/AggregatingUDFFinder.java?rev=1747825&r1=1747824&r2=1747825&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ss/formula/udf/AggregatingUDFFinder.java (original)
+++ poi/trunk/src/java/org/apache/poi/ss/formula/udf/AggregatingUDFFinder.java Sat Jun 11 00:42:57 2016
@@ -44,6 +44,7 @@ public class AggregatingUDFFinder implem
      * @param name Name of function.
      * @return Function executor. <code>null</code> if not found
      */
+    @Override
     public FreeRefFunction findFunction(String name) {
         FreeRefFunction evaluatorForFunction;
         for (UDFFinder pack : _usedToolPacks) {

Modified: poi/trunk/src/java/org/apache/poi/ss/formula/udf/DefaultUDFFinder.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/formula/udf/DefaultUDFFinder.java?rev=1747825&r1=1747824&r2=1747825&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ss/formula/udf/DefaultUDFFinder.java (original)
+++ poi/trunk/src/java/org/apache/poi/ss/formula/udf/DefaultUDFFinder.java Sat Jun 11 00:42:57 2016
@@ -44,6 +44,7 @@ public final class DefaultUDFFinder impl
         _functionsByName = m;
     }
 
+    @Override
     public FreeRefFunction findFunction(String name) {
         return _functionsByName.get(name.toUpperCase(Locale.ROOT));
     }

Modified: poi/trunk/src/java/org/apache/poi/ss/formula/udf/IndexedUDFFinder.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/formula/udf/IndexedUDFFinder.java?rev=1747825&r1=1747824&r2=1747825&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ss/formula/udf/IndexedUDFFinder.java (original)
+++ poi/trunk/src/java/org/apache/poi/ss/formula/udf/IndexedUDFFinder.java Sat Jun 11 00:42:57 2016
@@ -35,6 +35,7 @@ public class IndexedUDFFinder extends Ag
         _funcMap = new HashMap<Integer, String>();
     }
 
+    @Override
     public FreeRefFunction findFunction(String name) {
         FreeRefFunction func = super.findFunction(name);
         if (func != null) {

Modified: poi/trunk/src/java/org/apache/poi/ss/formula/udf/UDFFinder.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/formula/udf/UDFFinder.java?rev=1747825&r1=1747824&r2=1747825&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ss/formula/udf/UDFFinder.java (original)
+++ poi/trunk/src/java/org/apache/poi/ss/formula/udf/UDFFinder.java Sat Jun 11 00:42:57 2016
@@ -26,6 +26,7 @@ import org.apache.poi.ss.formula.functio
  * @author PUdalau
  */
 public interface UDFFinder {
+    // FIXME: Findbugs error: IC_SUPERCLASS_USES_SUBCLASS_DURING_INITIALIZATION
     public static final UDFFinder DEFAULT = new AggregatingUDFFinder(AnalysisToolPak.instance);
 
     /**



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org