You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Ryan Baxter <rb...@gmail.com> on 2012/04/11 18:22:00 UTC
Review Request: AbstractLockedDomainService has a protected enabled variable
as well as a public isEnabled method
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4698/
-----------------------------------------------------------
Review request for shindig, Stanton Sievers and Dan Dumont.
Summary
-------
AbstractLockedDomainService has both a protected enabled variable as well as a public isEnabled method. Both of which can be used to determine whether locked domains is enabled. However the methods in AbstractLockedDomainService and HashLockedDomainService all use the protected enabled variable so if someone who extends AbstractLockedDomainService or HashLockedDomainService and overrides isEnabled it won't actually be honored or used by any of the methods.
This addresses bug SHINDIG-1747.
https://issues.apache.org/jira/browse/SHINDIG-1747
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractLockedDomainService.java 1324741
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/HashLockedDomainService.java 1324741
Diff: https://reviews.apache.org/r/4698/diff
Testing
-------
Unit tests passed
Thanks,
Ryan
Re: Review Request: AbstractLockedDomainService has a protected enabled
variable as well as a public isEnabled method
Posted by Henry Saputra <hs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4698/#review6854
-----------------------------------------------------------
Ship it!
+1
- Henry
On 2012-04-11 16:22:00, Ryan Baxter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4698/
> -----------------------------------------------------------
>
> (Updated 2012-04-11 16:22:00)
>
>
> Review request for shindig, Stanton Sievers and Dan Dumont.
>
>
> Summary
> -------
>
> AbstractLockedDomainService has both a protected enabled variable as well as a public isEnabled method. Both of which can be used to determine whether locked domains is enabled. However the methods in AbstractLockedDomainService and HashLockedDomainService all use the protected enabled variable so if someone who extends AbstractLockedDomainService or HashLockedDomainService and overrides isEnabled it won't actually be honored or used by any of the methods.
>
>
> This addresses bug SHINDIG-1747.
> https://issues.apache.org/jira/browse/SHINDIG-1747
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractLockedDomainService.java 1324741
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/HashLockedDomainService.java 1324741
>
> Diff: https://reviews.apache.org/r/4698/diff
>
>
> Testing
> -------
>
> Unit tests passed
>
>
> Thanks,
>
> Ryan
>
>
Re: Review Request: AbstractLockedDomainService has a protected enabled
variable as well as a public isEnabled method
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4698/#review6858
-----------------------------------------------------------
Ship it!
+1
- Stanton
On 2012-04-11 16:22:00, Ryan Baxter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4698/
> -----------------------------------------------------------
>
> (Updated 2012-04-11 16:22:00)
>
>
> Review request for shindig, Stanton Sievers and Dan Dumont.
>
>
> Summary
> -------
>
> AbstractLockedDomainService has both a protected enabled variable as well as a public isEnabled method. Both of which can be used to determine whether locked domains is enabled. However the methods in AbstractLockedDomainService and HashLockedDomainService all use the protected enabled variable so if someone who extends AbstractLockedDomainService or HashLockedDomainService and overrides isEnabled it won't actually be honored or used by any of the methods.
>
>
> This addresses bug SHINDIG-1747.
> https://issues.apache.org/jira/browse/SHINDIG-1747
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractLockedDomainService.java 1324741
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/HashLockedDomainService.java 1324741
>
> Diff: https://reviews.apache.org/r/4698/diff
>
>
> Testing
> -------
>
> Unit tests passed
>
>
> Thanks,
>
> Ryan
>
>
Re: Review Request: AbstractLockedDomainService has a protected enabled
variable as well as a public isEnabled method
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4698/#review6855
-----------------------------------------------------------
Ship it!
LGTM
- Dan
On 2012-04-11 16:22:00, Ryan Baxter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4698/
> -----------------------------------------------------------
>
> (Updated 2012-04-11 16:22:00)
>
>
> Review request for shindig, Stanton Sievers and Dan Dumont.
>
>
> Summary
> -------
>
> AbstractLockedDomainService has both a protected enabled variable as well as a public isEnabled method. Both of which can be used to determine whether locked domains is enabled. However the methods in AbstractLockedDomainService and HashLockedDomainService all use the protected enabled variable so if someone who extends AbstractLockedDomainService or HashLockedDomainService and overrides isEnabled it won't actually be honored or used by any of the methods.
>
>
> This addresses bug SHINDIG-1747.
> https://issues.apache.org/jira/browse/SHINDIG-1747
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractLockedDomainService.java 1324741
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/HashLockedDomainService.java 1324741
>
> Diff: https://reviews.apache.org/r/4698/diff
>
>
> Testing
> -------
>
> Unit tests passed
>
>
> Thanks,
>
> Ryan
>
>
Re: Review Request: AbstractLockedDomainService has a protected enabled
variable as well as a public isEnabled method
Posted by Jesse Ciancetta <jc...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4698/#review6852
-----------------------------------------------------------
Ship it!
LGTM
- Jesse
On 2012-04-11 16:22:00, Ryan Baxter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4698/
> -----------------------------------------------------------
>
> (Updated 2012-04-11 16:22:00)
>
>
> Review request for shindig, Stanton Sievers and Dan Dumont.
>
>
> Summary
> -------
>
> AbstractLockedDomainService has both a protected enabled variable as well as a public isEnabled method. Both of which can be used to determine whether locked domains is enabled. However the methods in AbstractLockedDomainService and HashLockedDomainService all use the protected enabled variable so if someone who extends AbstractLockedDomainService or HashLockedDomainService and overrides isEnabled it won't actually be honored or used by any of the methods.
>
>
> This addresses bug SHINDIG-1747.
> https://issues.apache.org/jira/browse/SHINDIG-1747
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractLockedDomainService.java 1324741
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/HashLockedDomainService.java 1324741
>
> Diff: https://reviews.apache.org/r/4698/diff
>
>
> Testing
> -------
>
> Unit tests passed
>
>
> Thanks,
>
> Ryan
>
>