You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@polaris.apache.org by "flyrain (via GitHub)" <gi...@apache.org> on 2026/08/30 23:23:07 UTC

[PR] Clarify default table-like location documentation [polaris]

flyrain opened a new pull request, #5414:
URL: https://github.com/apache/polaris/pull/5414

   `defaultWarehouseLocation` does not return the catalog's default warehouse location. It returns the table-like entity's location, derived from its namespace or the catalog warehouse. The method name cannot be changed because it overrides Iceberg's inherited method.
   
   This adds Javadoc that makes that distinction explicit.
   
   ## Testing
   
   - `./gradlew format compileAll`
   - `./gradlew :polaris-runtime-service:spotlessJavaCheck --no-daemon`
   - `git diff --check`
   - `./gradlew :polaris-runtime-service:check` does not complete successfully because `RestCatalogKeycloakFileIT` fails during unrelated Keycloak test-resource startup: the admin-token endpoint returns HTTP 403. This was reproduced with both Keycloak 26.7.2 and 26.7.1.
   
   ## Checklist
   
   - [x] 🛡️ Don't disclose security issues! (contact security@apache.org)
   - [x] 🔗 Clearly explained why the changes are needed above; no related issue
   - [x] 🧪 Added/updated tests with good coverage, or manually tested (and explained how)
   - [x] 💡 Added comments for complex logic
   - [x] 🧾 Updated `CHANGELOG.md` (not needed; Javadoc-only clarification)
   - [x] 📚 Updated documentation in `site/content/in-dev/unreleased` (not needed; internal Javadoc only)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Clarify default table-like location documentation [polaris]

Posted by "flyrain (via GitHub)" <gi...@apache.org>.

flyrain merged PR #5414:
URL: https://github.com/apache/polaris/pull/5414


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org