You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/19 15:58:54 UTC
[GitHub] [spark] MaxGekk opened a new pull request #28259:
[SPARK-31488][SQL] Support `java.time.LocalDate` in Parquet filter pushdown
MaxGekk opened a new pull request #28259: [SPARK-31488][SQL] Support `java.time.LocalDate` in Parquet filter pushdown
URL: https://github.com/apache/spark/pull/28259
### What changes were proposed in this pull request?
1. Modified `ParquetFilters.valueCanMakeFilterOn()` to accept filters with `java.time.LocalDate` attributes.
2. Modified `ParquetFilters.dateToDays()` to support both types `java.sql.Date` and `java.time.LocalDate` in conversions to days.
3. Add implicit conversion from `LocalDate` to `Expression` (`Literal`).
### Why are the changes needed?
To support pushed down filters with `java.time.LocalDate` attributes. Before the changes, date filters are not pushed down to Parquet datasource when `spark.sql.datetime.java8API.enabled` is `true`.
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
Added a test to `ParquetFilterSuite`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28259: [SPARK-31488][SQL]
Support `java.time.LocalDate` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28259: [SPARK-31488][SQL] Support `java.time.LocalDate` in Parquet filter pushdown
URL: https://github.com/apache/spark/pull/28259#issuecomment-616170383
**[Test build #121479 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121479/testReport)** for PR 28259 at commit [`1804a66`](https://github.com/apache/spark/commit/1804a6673d5f975fd43dc55dfe95bf9a07693d82).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28259:
[SPARK-31488][SQL] Support `java.time.LocalDate` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28259: [SPARK-31488][SQL] Support `java.time.LocalDate` in Parquet filter pushdown
URL: https://github.com/apache/spark/pull/28259#issuecomment-616219890
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121479/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28259:
[SPARK-31488][SQL] Support `java.time.LocalDate` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28259: [SPARK-31488][SQL] Support `java.time.LocalDate` in Parquet filter pushdown
URL: https://github.com/apache/spark/pull/28259#issuecomment-616219889
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28259: [SPARK-31488][SQL]
Support `java.time.LocalDate` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28259: [SPARK-31488][SQL] Support `java.time.LocalDate` in Parquet filter pushdown
URL: https://github.com/apache/spark/pull/28259#issuecomment-616219630
**[Test build #121479 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121479/testReport)** for PR 28259 at commit [`1804a66`](https://github.com/apache/spark/commit/1804a6673d5f975fd43dc55dfe95bf9a07693d82).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28259: [SPARK-31488][SQL]
Support `java.time.LocalDate` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28259: [SPARK-31488][SQL] Support `java.time.LocalDate` in Parquet filter pushdown
URL: https://github.com/apache/spark/pull/28259#issuecomment-616219890
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121479/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28259: [SPARK-31488][SQL]
Support `java.time.LocalDate` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28259: [SPARK-31488][SQL] Support `java.time.LocalDate` in Parquet filter pushdown
URL: https://github.com/apache/spark/pull/28259#issuecomment-616170669
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26163/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28259:
[SPARK-31488][SQL] Support `java.time.LocalDate` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28259: [SPARK-31488][SQL] Support `java.time.LocalDate` in Parquet filter pushdown
URL: https://github.com/apache/spark/pull/28259#issuecomment-616170667
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28259: [SPARK-31488][SQL]
Support `java.time.LocalDate` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28259: [SPARK-31488][SQL] Support `java.time.LocalDate` in Parquet filter pushdown
URL: https://github.com/apache/spark/pull/28259#issuecomment-616219889
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28259:
[SPARK-31488][SQL] Support `java.time.LocalDate` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28259: [SPARK-31488][SQL] Support `java.time.LocalDate` in Parquet filter pushdown
URL: https://github.com/apache/spark/pull/28259#issuecomment-616170383
**[Test build #121479 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121479/testReport)** for PR 28259 at commit [`1804a66`](https://github.com/apache/spark/commit/1804a6673d5f975fd43dc55dfe95bf9a07693d82).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28259:
[SPARK-31488][SQL] Support `java.time.LocalDate` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28259: [SPARK-31488][SQL] Support `java.time.LocalDate` in Parquet filter pushdown
URL: https://github.com/apache/spark/pull/28259#issuecomment-616170669
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26163/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28259: [SPARK-31488][SQL]
Support `java.time.LocalDate` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28259: [SPARK-31488][SQL] Support `java.time.LocalDate` in Parquet filter pushdown
URL: https://github.com/apache/spark/pull/28259#issuecomment-616170667
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org