You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/05/20 05:57:15 UTC
[GitHub] [hive] ramesh0201 opened a new pull request, #3302: HIVE-26239 Shutdown Hash table load executor service threads when the…
ramesh0201 opened a new pull request, #3302:
URL: https://github.com/apache/hive/pull/3302
…y are interrupted
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a diff in pull request #3302: HIVE-26239 Shutdown Hash table load executor service threads when the…
Posted by GitBox <gi...@apache.org>.
pvary commented on code in PR #3302:
URL: https://github.com/apache/hive/pull/3302#discussion_r880805144
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java:
##########
@@ -294,7 +295,10 @@ public void load(MapJoinTableContainer[] mapJoinTables,
LOG.info("Finished loading the queue for input: {} waiting {} minutes for TPool shutdown", inputName, 2);
addQueueDoneSentinel();
loadExecService.shutdown();
- loadExecService.awaitTermination(2, TimeUnit.MINUTES);
+
+ if (!loadExecService.awaitTermination(2, TimeUnit.MINUTES)) {
+ throw new HiveException("Failed to complete the hash table loader. Loading timed out.");
Review Comment:
Catch and rethrow in the surrounding try-catch?,
```
} catch(HiveException he) {
throw he;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ramesh0201 commented on a diff in pull request #3302: HIVE-26239 Shutdown Hash table load executor service threads when the…
Posted by GitBox <gi...@apache.org>.
ramesh0201 commented on code in PR #3302:
URL: https://github.com/apache/hive/pull/3302#discussion_r880822070
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java:
##########
@@ -294,7 +295,10 @@ public void load(MapJoinTableContainer[] mapJoinTables,
LOG.info("Finished loading the queue for input: {} waiting {} minutes for TPool shutdown", inputName, 2);
addQueueDoneSentinel();
loadExecService.shutdown();
- loadExecService.awaitTermination(2, TimeUnit.MINUTES);
+
+ if (!loadExecService.awaitTermination(2, TimeUnit.MINUTES)) {
+ throw new HiveException("Failed to complete the hash table loader. Loading timed out.");
Review Comment:
thanks! Fixed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ayushtkn commented on a diff in pull request #3302: HIVE-26239 Shutdown Hash table load executor service threads when the…
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on code in PR #3302:
URL: https://github.com/apache/hive/pull/3302#discussion_r880726160
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java:
##########
@@ -312,13 +312,11 @@ public void load(MapJoinTableContainer[] mapJoinTables,
inputName, cacheKey, receivedEntries, delta);
}
} catch (InterruptedException e) {
+ loadExecService.shutdownNow();
Review Comment:
There is :
```
loadExecService.awaitTermination(2, TimeUnit.MINUTES)
```
This just waits 2 minutes, doesn't throw any exception, if the tasks don't get completed in 2 mins. Now if we waited 120 seconds and the task was supposed to be completed in 122 seconds. We would interrupt the thread now in the ``finally`` block?
Won't the result or behaviour change post this change? say it had a chance to complete before it gets terminated or so....
Or check for the return value of this awaitTermination and if it returns false, we throw an Exception rather than a success, that way this finally block might look cool
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ramesh0201 commented on pull request #3302: HIVE-26239 Shutdown Hash table load executor service threads when the…
Posted by GitBox <gi...@apache.org>.
ramesh0201 commented on PR #3302:
URL: https://github.com/apache/hive/pull/3302#issuecomment-1133937245
@maheshk114 Can you please help review this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ramesh0201 merged pull request #3302: HIVE-26239 Shutdown Hash table load executor service threads when the…
Posted by GitBox <gi...@apache.org>.
ramesh0201 merged PR #3302:
URL: https://github.com/apache/hive/pull/3302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a diff in pull request #3302: HIVE-26239 Shutdown Hash table load executor service threads when the…
Posted by GitBox <gi...@apache.org>.
pvary commented on code in PR #3302:
URL: https://github.com/apache/hive/pull/3302#discussion_r880649217
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java:
##########
@@ -314,12 +314,10 @@ public void load(MapJoinTableContainer[] mapJoinTables,
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
throw new HiveException(e);
- } catch (IOException e) {
- throw new HiveException(e);
- } catch (SerDeException e) {
- throw new HiveException(e);
} catch (Exception e) {
throw new HiveException(e);
+ } finally {
+ loadExecService.shutdownNow();
Review Comment:
I see that the `loadExecService` is cleanly handled (we may arrive here without creating a new one). This might be better:
```
if (!loadExecService.isTerminated()) {
loadExecService.shutdownNow();
}
```
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ramesh0201 commented on pull request #3302: HIVE-26239 Shutdown Hash table load executor service threads when the…
Posted by GitBox <gi...@apache.org>.
ramesh0201 commented on PR #3302:
URL: https://github.com/apache/hive/pull/3302#issuecomment-1139740168
Thanks for the review @pvary @ayushtkn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a diff in pull request #3302: HIVE-26239 Shutdown Hash table load executor service threads when the…
Posted by GitBox <gi...@apache.org>.
pvary commented on code in PR #3302:
URL: https://github.com/apache/hive/pull/3302#discussion_r880765003
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java:
##########
@@ -294,7 +295,10 @@ public void load(MapJoinTableContainer[] mapJoinTables,
LOG.info("Finished loading the queue for input: {} waiting {} minutes for TPool shutdown", inputName, 2);
addQueueDoneSentinel();
loadExecService.shutdown();
- loadExecService.awaitTermination(2, TimeUnit.MINUTES);
+
+ if (!loadExecService.awaitTermination(2, TimeUnit.MINUTES)) {
+ throw new HiveException("Failed to complete the hash table loader. Loading timed out.");
Review Comment:
This will be a doubly wrapped HiveException
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ramesh0201 commented on a diff in pull request #3302: HIVE-26239 Shutdown Hash table load executor service threads when the…
Posted by GitBox <gi...@apache.org>.
ramesh0201 commented on code in PR #3302:
URL: https://github.com/apache/hive/pull/3302#discussion_r880559727
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java:
##########
@@ -312,13 +312,11 @@ public void load(MapJoinTableContainer[] mapJoinTables,
inputName, cacheKey, receivedEntries, delta);
}
} catch (InterruptedException e) {
+ loadExecService.shutdownNow();
Review Comment:
yes that will be the right way, addressed! thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ramesh0201 commented on a diff in pull request #3302: HIVE-26239 Shutdown Hash table load executor service threads when the…
Posted by GitBox <gi...@apache.org>.
ramesh0201 commented on code in PR #3302:
URL: https://github.com/apache/hive/pull/3302#discussion_r880761280
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java:
##########
@@ -312,13 +312,11 @@ public void load(MapJoinTableContainer[] mapJoinTables,
inputName, cacheKey, receivedEntries, delta);
}
} catch (InterruptedException e) {
+ loadExecService.shutdownNow();
Review Comment:
Good catch! Thanks for finding this. Addressed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ramesh0201 commented on a diff in pull request #3302: HIVE-26239 Shutdown Hash table load executor service threads when the…
Posted by GitBox <gi...@apache.org>.
ramesh0201 commented on code in PR #3302:
URL: https://github.com/apache/hive/pull/3302#discussion_r880797274
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java:
##########
@@ -294,7 +295,10 @@ public void load(MapJoinTableContainer[] mapJoinTables,
LOG.info("Finished loading the queue for input: {} waiting {} minutes for TPool shutdown", inputName, 2);
addQueueDoneSentinel();
loadExecService.shutdown();
- loadExecService.awaitTermination(2, TimeUnit.MINUTES);
+
+ if (!loadExecService.awaitTermination(2, TimeUnit.MINUTES)) {
+ throw new HiveException("Failed to complete the hash table loader. Loading timed out.");
Review Comment:
@pvary Can you give pointers on how do I handle this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ramesh0201 commented on a diff in pull request #3302: HIVE-26239 Shutdown Hash table load executor service threads when the…
Posted by GitBox <gi...@apache.org>.
ramesh0201 commented on code in PR #3302:
URL: https://github.com/apache/hive/pull/3302#discussion_r880692865
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java:
##########
@@ -314,12 +314,10 @@ public void load(MapJoinTableContainer[] mapJoinTables,
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
throw new HiveException(e);
- } catch (IOException e) {
- throw new HiveException(e);
- } catch (SerDeException e) {
- throw new HiveException(e);
} catch (Exception e) {
throw new HiveException(e);
+ } finally {
+ loadExecService.shutdownNow();
Review Comment:
Yes, Agree. Thanks for pointing this. Also added a null check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a diff in pull request #3302: HIVE-26239 Shutdown Hash table load executor service threads when the…
Posted by GitBox <gi...@apache.org>.
pvary commented on code in PR #3302:
URL: https://github.com/apache/hive/pull/3302#discussion_r880123001
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java:
##########
@@ -312,13 +312,11 @@ public void load(MapJoinTableContainer[] mapJoinTables,
inputName, cacheKey, receivedEntries, delta);
}
} catch (InterruptedException e) {
+ loadExecService.shutdownNow();
Review Comment:
should this be `finally`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org