You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/05/21 14:12:22 UTC
[GitHub] [kafka] lbradstreet opened a new pull request #8708: MINOR: avoid unnecessary list iteration in ApiVersion.lastVersion
lbradstreet opened a new pull request #8708:
URL: https://github.com/apache/kafka/pull/8708
We unnecessarily iterate the versions list each time we lookup lastVersion, including in the hotpath Log.appendAsFollower. Given that allVersions is a constant, this is unnecessary. See the profile below from a relatively low replica count cluster. Higher replica count clusters with smaller batches may see a slightly larger effect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] lbradstreet removed a comment on pull request #8708: MINOR: avoid unnecessary list iteration in ApiVersion.lastVersion
Posted by GitBox <gi...@apache.org>.
lbradstreet removed a comment on pull request #8708:
URL: https://github.com/apache/kafka/pull/8708#issuecomment-632110111
Temporarily closing this. I'm surprised that we actually see latestVersion being called here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #8708: MINOR: avoid unnecessary seq iteration in ApiVersion.lastVersion
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #8708:
URL: https://github.com/apache/kafka/pull/8708#issuecomment-633805226
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] lbradstreet closed pull request #8708: MINOR: avoid unnecessary list iteration in ApiVersion.lastVersion
Posted by GitBox <gi...@apache.org>.
lbradstreet closed pull request #8708:
URL: https://github.com/apache/kafka/pull/8708
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #8708: MINOR: avoid unnecessary seq iteration in ApiVersion.lastVersion
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #8708:
URL: https://github.com/apache/kafka/pull/8708#issuecomment-633257004
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] lbradstreet commented on pull request #8708: MINOR: avoid unnecessary list iteration in ApiVersion.lastVersion
Posted by GitBox <gi...@apache.org>.
lbradstreet commented on pull request #8708:
URL: https://github.com/apache/kafka/pull/8708#issuecomment-632110111
Temporarily closing this. I'm surprised that we actually see latestVersion being called here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma merged pull request #8708: MINOR: avoid unnecessary seq iteration in ApiVersion.lastVersion
Posted by GitBox <gi...@apache.org>.
ijuma merged pull request #8708:
URL: https://github.com/apache/kafka/pull/8708
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #8708: MINOR: avoid unnecessary seq iteration in ApiVersion.lastVersion
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #8708:
URL: https://github.com/apache/kafka/pull/8708#issuecomment-632234746
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org