You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/07/27 12:36:07 UTC
[GitHub] [flink] MartijnVisser opened a new pull request #16608: [FLINK-23297] Upgrade Protobuf to 3.17.3
MartijnVisser opened a new pull request #16608:
URL: https://github.com/apache/flink/pull/16608
## What is the purpose of the change
* In order to support compilation with ARM (e.g. Apple M1 chip), we need to bump our Protobuf dependency to version 3.17.3.
## Brief change log
- Updated com.google.protobuf:protobuf-java from 3.11.1 to 3.17.3
- Hardcoded version for plugin protoc-jar-maven-plugin:protoc-jar-maven-plugin since that's not in sync with com.google.protobuf:protobuf-java to the latest available version
- Updated NOTICE files to deal with new version number
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): yes
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: yes
- The runtime per-record code paths (performance sensitive): don't know
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] maver1ck commented on pull request #16608: [FLINK-23297] Upgrade Protobuf to 3.17.3
Posted by GitBox <gi...@apache.org>.
maver1ck commented on pull request #16608:
URL: https://github.com/apache/flink/pull/16608#issuecomment-973902153
OK.
Is there a chance my PR will be merged in the meantime ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] maver1ck commented on pull request #16608: [FLINK-23297] Upgrade Protobuf to 3.17.3
Posted by GitBox <gi...@apache.org>.
maver1ck commented on pull request #16608:
URL: https://github.com/apache/flink/pull/16608#issuecomment-973866417
@MartijnVisser I think still something is broken with protobuf after this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #16608: [FLINK-23297] Upgrade Protobuf to 3.17.3
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #16608:
URL: https://github.com/apache/flink/pull/16608#issuecomment-889921155
I ran a `mvn dependency:tree` and don't see it load in any transitive dependencies:
```
[INFO] | | \- joda-time:joda-time:jar:2.5:compile
[INFO] | +- com.google.protobuf:protobuf-java:jar:3.17.3:compile
[INFO] | +- net.sf.py4j:py4j:jar:0.10.8.1:compile
```
```
[INFO] | | \- joda-time:joda-time:jar:2.5:test
[INFO] | +- com.google.protobuf:protobuf-java:jar:3.17.3:provided
[INFO] | +- net.sf.py4j:py4j:jar:0.10.8.1:test
```
```
[INFO] | +- org.apache.beam:beam-runners-core-java:jar:2.27.0:provided
[INFO] | +- com.google.protobuf:protobuf-java:jar:3.17.3:provided
[INFO] | +- net.sf.py4j:py4j:jar:0.10.8.1:provided
```
```
[INFO] | | \- joda-time:joda-time:jar:2.5:compile
[INFO] | +- com.google.protobuf:protobuf-java:jar:3.17.3:compile
[INFO] | +- net.sf.py4j:py4j:jar:0.10.8.1:compile
```
```
[INFO] | | \- joda-time:joda-time:jar:2.5:compile
[INFO] | +- com.google.protobuf:protobuf-java:jar:3.17.3:compile
[INFO] | +- net.sf.py4j:py4j:jar:0.10.8.1:compile
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16608: [FLINK-23297] Upgrade Protobuf to 3.17.3
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16608:
URL: https://github.com/apache/flink/pull/16608#issuecomment-887508924
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "792481ceca38f5e484de76ad41b53be537b4aba0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21034",
"triggerID" : "792481ceca38f5e484de76ad41b53be537b4aba0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 792481ceca38f5e484de76ad41b53be537b4aba0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21034)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #16608: [FLINK-23297] Upgrade Protobuf to 3.17.3
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #16608:
URL: https://github.com/apache/flink/pull/16608#issuecomment-973932677
@maver1ck Let me check in the other PR :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise merged pull request #16608: [FLINK-23297] Upgrade Protobuf to 3.17.3
Posted by GitBox <gi...@apache.org>.
AHeise merged pull request #16608:
URL: https://github.com/apache/flink/pull/16608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16608: [FLINK-23297] Upgrade Protobuf to 3.17.3
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16608:
URL: https://github.com/apache/flink/pull/16608#issuecomment-887477451
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 792481ceca38f5e484de76ad41b53be537b4aba0 (Tue Jul 27 12:39:56 UTC 2021)
**Warnings:**
* **2 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] maver1ck commented on pull request #16608: [FLINK-23297] Upgrade Protobuf to 3.17.3
Posted by GitBox <gi...@apache.org>.
maver1ck commented on pull request #16608:
URL: https://github.com/apache/flink/pull/16608#issuecomment-973893638
This is error I'm getting on build. Of course with patch from: https://github.com/apache/flink/pull/17795
```
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 06:32 min
[INFO] Finished at: 2021-11-19T09:31:23+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.xolstice.maven.plugins:protobuf-maven-plugin:0.5.1:test-compile (default) on project flink-parquet_2.12: Missing:
[ERROR] ----------
[ERROR] 1) com.google.protobuf:protoc:exe:osx-aarch_64:3.5.1
[ERROR]
[ERROR] Try downloading the file manually from the project website.
[ERROR]
[ERROR] Then, install it using the command:
[ERROR] mvn install:install-file -DgroupId=com.google.protobuf -DartifactId=protoc -Dversion=3.5.1 -Dclassifier=osx-aarch_64 -Dpackaging=exe -Dfile=/path/to/file
[ERROR]
[ERROR] Alternatively, if you host your own repository you can deploy the file there:
[ERROR] mvn deploy:deploy-file -DgroupId=com.google.protobuf -DartifactId=protoc -Dversion=3.5.1 -Dclassifier=osx-aarch_64 -Dpackaging=exe -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]
[ERROR]
[ERROR] Path to dependency:
[ERROR] 1) org.apache.flink:flink-parquet_2.12:jar:1.15-SNAPSHOT
[ERROR] 2) com.google.protobuf:protoc:exe:osx-aarch_64:3.5.1
[ERROR]
[ERROR] ----------
[ERROR] 1 required artifact is missing.
[ERROR]
[ERROR] for artifact:
[ERROR] org.apache.flink:flink-parquet_2.12:jar:1.15-SNAPSHOT
[ERROR]
[ERROR] from the specified remote repositories:
[ERROR] apache.snapshots (https://repository.apache.org/snapshots, releases=false, snapshots=true),
[ERROR] central (https://repo.maven.apache.org/maven2, releases=true, snapshots=false)
[ERROR]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #16608: [FLINK-23297] Upgrade Protobuf to 3.17.3
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #16608:
URL: https://github.com/apache/flink/pull/16608#issuecomment-973896142
@maver1ck This is when you're trying to compile the current master branch on a Mac M1, right? If so, perhaps we should continue the discussion at https://issues.apache.org/jira/browse/FLINK-23230 to figure out next steps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #16608: [FLINK-23297] Upgrade Protobuf to 3.17.3
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #16608:
URL: https://github.com/apache/flink/pull/16608#issuecomment-973890019
> @MartijnVisser I think still something is broken with protobuf after this patch.
Could you elaborate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16608: [FLINK-23297] Upgrade Protobuf to 3.17.3
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16608:
URL: https://github.com/apache/flink/pull/16608#issuecomment-887508924
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "792481ceca38f5e484de76ad41b53be537b4aba0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21034",
"triggerID" : "792481ceca38f5e484de76ad41b53be537b4aba0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 792481ceca38f5e484de76ad41b53be537b4aba0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21034)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16608: [FLINK-23297] Upgrade Protobuf to 3.17.3
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16608:
URL: https://github.com/apache/flink/pull/16608#issuecomment-887477451
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 792481ceca38f5e484de76ad41b53be537b4aba0 (Sat Aug 28 13:05:59 UTC 2021)
**Warnings:**
* **2 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16608: [FLINK-23297] Upgrade Protobuf to 3.17.3
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16608:
URL: https://github.com/apache/flink/pull/16608#issuecomment-887508924
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "792481ceca38f5e484de76ad41b53be537b4aba0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "792481ceca38f5e484de76ad41b53be537b4aba0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 792481ceca38f5e484de76ad41b53be537b4aba0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org