You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/01/07 10:50:24 UTC
[GitHub] dawidwys commented on a change in pull request #7324:
[FLINK-10596][cep] Added access to timer service in IterativeCondition
dawidwys commented on a change in pull request #7324: [FLINK-10596][cep] Added access to timer service in IterativeCondition
URL: https://github.com/apache/flink/pull/7324#discussion_r245615174
##########
File path: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java
##########
@@ -851,6 +837,20 @@ private boolean checkFilterCondition(
}
};
}
+
+ @Override
+ public Long timestamp() {
+ if (timerService.isProcessingTime()) {
+ return null;
Review comment:
This is to comply with the behavior in `ProcessFunction.Context`. We did it the same way for `org.apache.flink.cep.functions.PatternProcessFunction`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services