You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Michael Brown (Code Review)" <ge...@cloudera.org> on 2016/03/23 20:07:34 UTC

[Impala-CR](cdh5-trunk) IMPALA-2650: EE test test_udf_update_via_create: run with unique database

Michael Brown has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/2610

Change subject: IMPALA-2650: EE test test_udf_update_via_create: run with unique database
......................................................................

IMPALA-2650: EE test test_udf_update_via_create: run with unique database

The test_udf_update_via_create end-to-end test created a UDF in the
default database and left it there. Other tests (e.g.,
test_functions_ddl) polling the default database and expecting to find
no UDFs would fail. It turns out this wouldn't happen in our Jenkins
builds (see IMPALA-2650 for more details as to why), but it manifests
itself with repeated impala-py.test runs in specific order.

The fix is to create the UDF into a unique database for the test method,
which is automatically destroyed after the test completes. This leaves
the default database pristine for this test.

Testing:

Before, the following sequence of impala-py.test commands would cause
any subsequent runs of test_functions_ddl to fail:

$ # simulate the serial tests
$ impala-py.test -m "execute_serially" --workload_exploration_strategy \
    functional-query:exhaustive -k test_functions_ddl metadata/test_ddl.py
PASS
$ # simulate the parallel tests
$ impala-py.test -n4 -m "not execute_serially" --workload_exploration_strategy \
    functional-query:exhaustive -k test_udf_update_via_create query_test/test_udfs.py
PASS
$ # rerun the serial tests but do not restart impalad
$ impala-py.test -m "execute_serially" --workload_exploration_strategy \
    functional-query:exhaustive -k test_functions_ddl metadata/test_ddl.py
FAIL, because test_udf_update_via_create left a UDF

Now, I can run these over and over, and they pass. Since this failure
doesn't manifest via Jenkins anyhow, I didn't run any Jenkins builds.

Change-Id: Id4a8b4764fa310efaa4f6c6f06f64a4e18e44173
---
M tests/query_test/test_udfs.py
1 file changed, 18 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/10/2610/1
-- 
To view, visit http://gerrit.cloudera.org:8080/2610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4a8b4764fa310efaa4f6c6f06f64a4e18e44173
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Brown <mi...@cloudera.com>