You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/05 10:37:08 UTC
[GitHub] [flink] RocMarshal opened a new pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn
RocMarshal opened a new pull request #18983:
URL: https://github.com/apache/flink/pull/18983
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*[JUnit5 Migration] Module: flink-yarn*
## Brief change log
[JUnit5 Migration] Module: flink-yarn
## Verifying this change
This change is already covered by existing tests, such as *(please describe tests)*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #18983:
URL: https://github.com/apache/flink/pull/18983#discussion_r832012052
##########
File path: flink-yarn/src/test/resources/META-INF/services/org.junit.jupiter.api.extension.Extension
##########
@@ -0,0 +1,16 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+org.apache.flink.util.TestLoggerExtension
Review comment:
no; we should first port the users of the test-jar (as much as possible), then migrate flink-yarn (along with whatever couldn't be ported previously in downstream modules).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18983:
URL: https://github.com/apache/flink/pull/18983#issuecomment-1059740356
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6352c8bf4468c666c5340e887500b68434c7529e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32563",
"triggerID" : "6352c8bf4468c666c5340e887500b68434c7529e",
"triggerType" : "PUSH"
}, {
"hash" : "3cfb40cab5eb51b3a53f758e91455c0fea3017d5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33061",
"triggerID" : "3cfb40cab5eb51b3a53f758e91455c0fea3017d5",
"triggerType" : "PUSH"
}, {
"hash" : "dc2782958966e92d3486cbebe25c65e3112cc04f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33115",
"triggerID" : "dc2782958966e92d3486cbebe25c65e3112cc04f",
"triggerType" : "PUSH"
}, {
"hash" : "d63719e7bb3bd0fc2eea856e5c5f6b099d5db93e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33295",
"triggerID" : "d63719e7bb3bd0fc2eea856e5c5f6b099d5db93e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d63719e7bb3bd0fc2eea856e5c5f6b099d5db93e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33295)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #18983:
URL: https://github.com/apache/flink/pull/18983#issuecomment-1064207195
@zentol Thanks a lot for the review. I'll check it based on your comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #18983:
URL: https://github.com/apache/flink/pull/18983#discussion_r823624872
##########
File path: flink-yarn/src/test/java/org/apache/flink/yarn/YarnTaskExecutorRunnerTest.java
##########
@@ -36,13 +37,12 @@
import java.util.Map;
import java.util.Optional;
-import static org.hamcrest.Matchers.containsString;
-import static org.hamcrest.Matchers.is;
-import static org.junit.Assert.assertThat;
-import static org.junit.Assert.fail;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.junit.jupiter.api.Assertions.fail;
/** Tests for the {@link YarnTaskExecutorRunner}. */
-public class YarnTaskExecutorRunnerTest extends TestLogger {
+@ExtendWith(TestLoggerExtension.class)
Review comment:
these are unnecessary since you've setup the service loading approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on a change in pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on a change in pull request #18983:
URL: https://github.com/apache/flink/pull/18983#discussion_r825836428
##########
File path: flink-yarn/src/test/resources/META-INF/services/org.junit.jupiter.api.extension.Extension
##########
@@ -0,0 +1,16 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+org.apache.flink.util.TestLoggerExtension
Review comment:
@zentol I checked the module related about `test-jar`, there are `flink-yarn-test` and `flink-end-to-end-tests`.
May I change these modules in the same PR based the relationships ?
And `flink-yarn-test` is [here](https://github.com/apache/flink/pull/18986)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18983:
URL: https://github.com/apache/flink/pull/18983#issuecomment-1059740356
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6352c8bf4468c666c5340e887500b68434c7529e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32563",
"triggerID" : "6352c8bf4468c666c5340e887500b68434c7529e",
"triggerType" : "PUSH"
}, {
"hash" : "3cfb40cab5eb51b3a53f758e91455c0fea3017d5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33061",
"triggerID" : "3cfb40cab5eb51b3a53f758e91455c0fea3017d5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3cfb40cab5eb51b3a53f758e91455c0fea3017d5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33061)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18983:
URL: https://github.com/apache/flink/pull/18983#issuecomment-1059740356
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6352c8bf4468c666c5340e887500b68434c7529e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32563",
"triggerID" : "6352c8bf4468c666c5340e887500b68434c7529e",
"triggerType" : "PUSH"
}, {
"hash" : "3cfb40cab5eb51b3a53f758e91455c0fea3017d5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33061",
"triggerID" : "3cfb40cab5eb51b3a53f758e91455c0fea3017d5",
"triggerType" : "PUSH"
}, {
"hash" : "dc2782958966e92d3486cbebe25c65e3112cc04f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dc2782958966e92d3486cbebe25c65e3112cc04f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3cfb40cab5eb51b3a53f758e91455c0fea3017d5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33061)
* dc2782958966e92d3486cbebe25c65e3112cc04f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18983:
URL: https://github.com/apache/flink/pull/18983#issuecomment-1059740356
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6352c8bf4468c666c5340e887500b68434c7529e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32563",
"triggerID" : "6352c8bf4468c666c5340e887500b68434c7529e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6352c8bf4468c666c5340e887500b68434c7529e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32563)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18983:
URL: https://github.com/apache/flink/pull/18983#issuecomment-1059740356
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6352c8bf4468c666c5340e887500b68434c7529e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32563",
"triggerID" : "6352c8bf4468c666c5340e887500b68434c7529e",
"triggerType" : "PUSH"
}, {
"hash" : "3cfb40cab5eb51b3a53f758e91455c0fea3017d5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3cfb40cab5eb51b3a53f758e91455c0fea3017d5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6352c8bf4468c666c5340e887500b68434c7529e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32563)
* 3cfb40cab5eb51b3a53f758e91455c0fea3017d5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18983:
URL: https://github.com/apache/flink/pull/18983#issuecomment-1059740356
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6352c8bf4468c666c5340e887500b68434c7529e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32563",
"triggerID" : "6352c8bf4468c666c5340e887500b68434c7529e",
"triggerType" : "PUSH"
}, {
"hash" : "3cfb40cab5eb51b3a53f758e91455c0fea3017d5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33061",
"triggerID" : "3cfb40cab5eb51b3a53f758e91455c0fea3017d5",
"triggerType" : "PUSH"
}, {
"hash" : "dc2782958966e92d3486cbebe25c65e3112cc04f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33115",
"triggerID" : "dc2782958966e92d3486cbebe25c65e3112cc04f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3cfb40cab5eb51b3a53f758e91455c0fea3017d5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33061)
* dc2782958966e92d3486cbebe25c65e3112cc04f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33115)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18983:
URL: https://github.com/apache/flink/pull/18983#issuecomment-1059740356
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6352c8bf4468c666c5340e887500b68434c7529e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32563",
"triggerID" : "6352c8bf4468c666c5340e887500b68434c7529e",
"triggerType" : "PUSH"
}, {
"hash" : "3cfb40cab5eb51b3a53f758e91455c0fea3017d5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33061",
"triggerID" : "3cfb40cab5eb51b3a53f758e91455c0fea3017d5",
"triggerType" : "PUSH"
}, {
"hash" : "dc2782958966e92d3486cbebe25c65e3112cc04f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33115",
"triggerID" : "dc2782958966e92d3486cbebe25c65e3112cc04f",
"triggerType" : "PUSH"
}, {
"hash" : "d63719e7bb3bd0fc2eea856e5c5f6b099d5db93e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33295",
"triggerID" : "d63719e7bb3bd0fc2eea856e5c5f6b099d5db93e",
"triggerType" : "PUSH"
}, {
"hash" : "b4c5cba226ee2335eb45e66c71a016260958b9d3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33429",
"triggerID" : "b4c5cba226ee2335eb45e66c71a016260958b9d3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d63719e7bb3bd0fc2eea856e5c5f6b099d5db93e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33295)
* b4c5cba226ee2335eb45e66c71a016260958b9d3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33429)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18983:
URL: https://github.com/apache/flink/pull/18983#issuecomment-1059740356
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6352c8bf4468c666c5340e887500b68434c7529e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32563",
"triggerID" : "6352c8bf4468c666c5340e887500b68434c7529e",
"triggerType" : "PUSH"
}, {
"hash" : "3cfb40cab5eb51b3a53f758e91455c0fea3017d5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33061",
"triggerID" : "3cfb40cab5eb51b3a53f758e91455c0fea3017d5",
"triggerType" : "PUSH"
}, {
"hash" : "dc2782958966e92d3486cbebe25c65e3112cc04f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33115",
"triggerID" : "dc2782958966e92d3486cbebe25c65e3112cc04f",
"triggerType" : "PUSH"
}, {
"hash" : "d63719e7bb3bd0fc2eea856e5c5f6b099d5db93e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33295",
"triggerID" : "d63719e7bb3bd0fc2eea856e5c5f6b099d5db93e",
"triggerType" : "PUSH"
}, {
"hash" : "b4c5cba226ee2335eb45e66c71a016260958b9d3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b4c5cba226ee2335eb45e66c71a016260958b9d3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d63719e7bb3bd0fc2eea856e5c5f6b099d5db93e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33295)
* b4c5cba226ee2335eb45e66c71a016260958b9d3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #18983:
URL: https://github.com/apache/flink/pull/18983#discussion_r823626517
##########
File path: flink-kubernetes/src/test/java/org/apache/flink/kubernetes/KubernetesResourceManagerDriverTest.java
##########
@@ -364,16 +361,16 @@ protected void preparePreviousAttemptWorkers() {
@Override
protected void validateInitialization() throws Exception {
- assertNotNull(getPodCallbackHandler());
+ assertThat(getPodCallbackHandler()).isNotNull();
}
@Override
protected void validateWorkersRecoveredFromPreviousAttempt(
Collection<KubernetesWorkerNode> workers) {
- assertThat(workers.size(), is(1));
+ assertThat(workers.size()).isEqualTo(1);
Review comment:
```suggestion
assertThat(workers).hasSize(1);
```
Please also check for other similar instances.
##########
File path: flink-yarn/src/test/resources/META-INF/services/org.junit.jupiter.api.extension.Extension
##########
@@ -0,0 +1,16 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+org.apache.flink.util.TestLoggerExtension
Review comment:
This needs to be excluded from the test-jar since it otherwise leaks into downstream modules (specifically, flink-yarn-tests)
##########
File path: flink-yarn/src/test/java/org/apache/flink/yarn/TaskExecutorProcessSpecContainerResourcePriorityAdapterTest.java
##########
@@ -140,37 +141,36 @@
Collections.emptyList());
@Test
- public void testGetResourceFromSpec() {
+ void testGetResourceFromSpec() {
final TaskExecutorProcessSpecContainerResourcePriorityAdapter adapter = getAdapter();
final Resource resource = getResource(adapter, TASK_EXECUTOR_PROCESS_SPEC_1);
- assertThat(
- resource.getMemory(),
- is(TASK_EXECUTOR_PROCESS_SPEC_1.getTotalProcessMemorySize().getMebiBytes()));
- assertThat(
- resource.getVirtualCores(),
- is(TASK_EXECUTOR_PROCESS_SPEC_1.getCpuCores().getValue().intValue()));
+ assertThat(resource.getMemory())
+ .isEqualTo(TASK_EXECUTOR_PROCESS_SPEC_1.getTotalProcessMemorySize().getMebiBytes());
+ assertThat(resource.getVirtualCores())
+ .isEqualTo(TASK_EXECUTOR_PROCESS_SPEC_1.getCpuCores().getValue().intValue());
}
@Test
- public void testGetPriorityFromSpec() {
+ void testGetPriorityFromSpec() {
final TaskExecutorProcessSpecContainerResourcePriorityAdapter adapter = getAdapter();
final Priority priority1 = getPriority(adapter, TASK_EXECUTOR_PROCESS_SPEC_1);
final Priority priority2 = getPriority(adapter, TASK_EXECUTOR_PROCESS_SPEC_2);
final Priority priority3 = getPriority(adapter, TASK_EXECUTOR_PROCESS_SPEC_1);
- assertThat(priority1, not(priority2));
- assertThat(priority1, is(priority3));
+ assertThat(priority1).isNotEqualTo(priority2);
+ assertThat(priority1).isEqualTo(priority3);
}
@Test
- public void testMaxContainerResource() {
+ void testMaxContainerResource() {
final TaskExecutorProcessSpecContainerResourcePriorityAdapter adapter = getAdapter();
assertThat(
- adapter.getPriorityAndResource(TASK_EXECUTOR_PROCESS_SPEC_EXCEED_MAX).isPresent(),
- is(false));
+ adapter.getPriorityAndResource(TASK_EXECUTOR_PROCESS_SPEC_EXCEED_MAX)
+ .isPresent())
Review comment:
see above
##########
File path: flink-yarn/src/test/java/org/apache/flink/yarn/TaskExecutorProcessSpecContainerResourcePriorityAdapterTest.java
##########
@@ -185,17 +185,16 @@ public void testGetTaskExecutorProcessSpecAndResource() {
addedPriorityAndResource.getPriority())
.get();
- assertThat(
- resultSpecAndResource.getTaskExecutorProcessSpec(),
- is(TASK_EXECUTOR_PROCESS_SPEC_1));
- assertThat(resultSpecAndResource.getResource(), is(addedPriorityAndResource.getResource()));
- assertThat(
- adapter.getTaskExecutorProcessSpecAndResource(unknownPriority).isPresent(),
- is(false));
+ assertThat(resultSpecAndResource.getTaskExecutorProcessSpec())
+ .isEqualTo(TASK_EXECUTOR_PROCESS_SPEC_1);
+ assertThat(resultSpecAndResource.getResource())
+ .isEqualTo(addedPriorityAndResource.getResource());
+ assertThat(adapter.getTaskExecutorProcessSpecAndResource(unknownPriority).isPresent())
Review comment:
see above
##########
File path: flink-yarn/src/test/java/org/apache/flink/yarn/RegisterApplicationMasterResponseReflectorTest.java
##########
@@ -81,28 +79,29 @@ public void testDoesntCallGetContainersFromPreviousAttemptsMethodIfAbsent() {
registerApplicationMasterResponseReflector.getContainersFromPreviousAttemptsUnsafe(
new Object());
- assertThat(containersFromPreviousAttemptsUnsafe, empty());
+ assertThat(containersFromPreviousAttemptsUnsafe).isEmpty();
}
@Test
- public void testGetContainersFromPreviousAttemptsMethodReflectiveHadoop22() {
+ void testGetContainersFromPreviousAttemptsMethodReflectiveHadoop22() {
assumeTrue(
+ isHadoopVersionGreaterThanOrEquals(2, 2),
"Method getContainersFromPreviousAttempts is not supported by Hadoop: "
- + VersionInfo.getVersion(),
- isHadoopVersionGreaterThanOrEquals(2, 2));
+ + VersionInfo.getVersion());
final RegisterApplicationMasterResponseReflector
registerApplicationMasterResponseReflector =
new RegisterApplicationMasterResponseReflector(LOG);
- assertTrue(
- registerApplicationMasterResponseReflector
- .getGetContainersFromPreviousAttemptsMethod()
- .isPresent());
+ assertThat(
+ registerApplicationMasterResponseReflector
+ .getGetContainersFromPreviousAttemptsMethod()
+ .isPresent())
+ .isTrue();
Review comment:
```suggestion
assertThat(
registerApplicationMasterResponseReflector
.getGetContainersFromPreviousAttemptsMethod())
.isPresent();
```
##########
File path: flink-yarn/src/test/java/org/apache/flink/yarn/AbstractYarnClusterTest.java
##########
@@ -33,49 +33,60 @@
import org.apache.hadoop.yarn.conf.YarnConfiguration;
import org.apache.hadoop.yarn.exceptions.YarnException;
import org.apache.hadoop.yarn.util.Records;
-import org.junit.Rule;
-import org.junit.Test;
-import org.junit.rules.TemporaryFolder;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.junit.jupiter.api.io.TempDir;
import java.io.IOException;
+import java.nio.file.Path;
import java.util.Collections;
import java.util.Map;
+import static org.apache.flink.util.TempDirUtils.newFolderIn;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+
/** Tests for the {@link YarnClusterDescriptor}. */
-public class AbstractYarnClusterTest extends TestLogger {
+@ExtendWith(TestLoggerExtension.class)
+class AbstractYarnClusterTest {
- @Rule public TemporaryFolder temporaryFolder = new TemporaryFolder();
+ @TempDir private Path tempDir;
/** Tests that the cluster retrieval of a finished YARN application fails. */
- @Test(expected = ClusterRetrieveException.class)
- public void testClusterClientRetrievalOfFinishedYarnApplication() throws Exception {
- final ApplicationId applicationId =
- ApplicationId.newInstance(System.currentTimeMillis(), 42);
- final ApplicationReport applicationReport =
- createApplicationReport(
- applicationId,
- YarnApplicationState.FINISHED,
- FinalApplicationStatus.SUCCEEDED);
-
- final YarnClient yarnClient =
- new TestingYarnClient(Collections.singletonMap(applicationId, applicationReport));
- final YarnConfiguration yarnConfiguration = new YarnConfiguration();
- yarnClient.init(yarnConfiguration);
- yarnClient.start();
-
- final YarnClusterDescriptor clusterDescriptor =
- YarnTestUtils.createClusterDescriptorWithLogging(
- temporaryFolder.newFolder().getAbsolutePath(),
- new Configuration(),
- yarnConfiguration,
- yarnClient,
- false);
-
- try {
- clusterDescriptor.retrieve(applicationId);
- } finally {
- clusterDescriptor.close();
- }
+ @Test
+ void testClusterClientRetrievalOfFinishedYarnApplication() throws Exception {
+ assertThatThrownBy(
Review comment:
Instead of wrapping the entire test we can (and should) now target the specific line that causes the failure.
Please also check for similar instances.
##########
File path: flink-yarn/src/test/java/org/apache/flink/yarn/RegisterApplicationMasterResponseReflectorTest.java
##########
@@ -111,12 +110,12 @@ public void testCallsGetSchedulerResourceTypesMethodIfPresent() {
registerApplicationMasterResponseReflector.getSchedulerResourceTypeNamesUnsafe(
new HasMethod());
- assertTrue(schedulerResourceTypeNames.isPresent());
- assertThat(schedulerResourceTypeNames.get(), containsInAnyOrder("MEMORY", "CPU"));
+ assertThat(schedulerResourceTypeNames.isPresent()).isTrue();
Review comment:
see above
##########
File path: flink-yarn/src/test/java/org/apache/flink/yarn/YarnFileStageTest.java
##########
@@ -288,10 +285,10 @@ private static void testCopySingleFileFromLocal(
FileSystem targetFileSystem,
Path targetDir,
String localResourceDirectory,
- TemporaryFolder temporaryFolder)
+ java.nio.file.Path temporaryFolder)
throws IOException, InterruptedException, URISyntaxException {
- final File srcDir = temporaryFolder.newFolder();
+ final File srcDir = newFolderIn(temporaryFolder).toFile();
Review comment:
This just seems unnecessary. I'd add a `@TempDir` parameter to each test that requires it and use it as-is.
##########
File path: flink-yarn/src/test/java/org/apache/flink/yarn/YarnFileStageTest.java
##########
@@ -81,11 +79,11 @@
// Test setup and shutdown
// ------------------------------------------------------------------------
- @BeforeClass
+ @BeforeAll
public static void createHDFS() throws Exception {
Review comment:
```suggestion
public static void createHDFS(@TempDir File tempDir) throws Exception {
```
remove classTempDir
##########
File path: flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerDriverTest.java
##########
@@ -315,15 +308,15 @@ public void testTerminationWaitsOnContainerStopError() throws Exception {
public void testDeleteApplicationFiles() throws Exception {
new Context() {
{
- final File applicationDir = folder.newFolder(".flink");
+ final File applicationDir = newFolderIn(tmpFolder, ".flink");
env.put(FLINK_YARN_FILES, applicationDir.getCanonicalPath());
runTest(
() -> {
getDriver().deregisterApplication(ApplicationStatus.SUCCEEDED, null);
assertFalse(
Review comment:
should be migrated to assertj as well
##########
File path: flink-yarn/src/test/java/org/apache/flink/yarn/YarnFileStageTestS3ITCase.java
##########
@@ -173,34 +178,43 @@ private void testRecursiveUploadForYarn(String scheme, String pathSuffix) throws
}
}
- @Test
- @RetryOnFailure(times = 3)
+ @TestTemplate
+ @RetryOnException(times = 3, exception = Exception.class)
public void testRecursiveUploadForYarnS3n() throws Exception {
// skip test on Hadoop 3: https://issues.apache.org/jira/browse/HADOOP-14738
- Assume.assumeTrue(
- "This test is skipped for Hadoop versions above 3",
- VersionUtil.compareVersions(System.getProperty("hadoop.version"), "3.0.0") < 0);
+ assumeTrue(
+ VersionUtil.compareVersions(System.getProperty("hadoop.version"), "3.0.0") < 0,
+ "This test is skipped for Hadoop versions above 3");
try {
Class.forName("org.apache.hadoop.fs.s3native.NativeS3FileSystem");
} catch (ClassNotFoundException e) {
// not in the classpath, cannot run this test
String msg = "Skipping test because NativeS3FileSystem is not in the class path";
log.info(msg);
- assumeNoException(msg, e);
+ assumingThat(
+ false,
+ () -> {
+ throw new TestAbortedException();
+ });
}
testRecursiveUploadForYarn("s3n", "testYarn-s3n");
}
- @Test
- @RetryOnFailure(times = 3)
+ @TestTemplate
+ @RetryOnException(times = 3, exception = Exception.class)
public void testRecursiveUploadForYarnS3a() throws Exception {
try {
Class.forName("org.apache.hadoop.fs.s3a.S3AFileSystem");
} catch (ClassNotFoundException e) {
// not in the classpath, cannot run this test
String msg = "Skipping test because S3AFileSystem is not in the class path";
log.info(msg);
+ assumingThat(
+ false,
+ () -> {
+ throw new TestAbortedException();
+ });
Review comment:
?
##########
File path: flink-yarn/src/test/resources/META-INF/services/org.junit.jupiter.api.extension.Extension
##########
@@ -0,0 +1,16 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+org.apache.flink.util.TestLoggerExtension
Review comment:
you should also double-check what the test jar is used for; if some test base is used in downstream projects then it cannot be converted to junit5 yet.
##########
File path: flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerDriverTest.java
##########
@@ -153,8 +151,9 @@ public void testRunAsyncCausesFatalError() throws Exception {
final Optional<RuntimeException> optionalCause =
ExceptionUtils.findThrowable(t, RuntimeException.class);
- assertTrue(optionalCause.isPresent());
- assertThat(optionalCause.get().getMessage(), is(exceptionMessage));
+ assertThat(optionalCause).isPresent();
+ assertThat(optionalCause.get().getMessage())
+ .isEqualTo(exceptionMessage);
Review comment:
```suggestion
assertThat(optionalCause.get())
.hasMessage(exceptionMessage);
```
##########
File path: flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerDriverTest.java
##########
@@ -293,9 +288,7 @@ public void testTerminationWaitsOnContainerStopError() throws Exception {
getDriver().terminate();
});
- assertThat(
- driverHasTerminatedFuture,
- FlinkMatchers.willNotComplete(Duration.ofMillis(20L)));
+ assertThat(driverHasTerminatedFuture).isNotCompleted();
Review comment:
This is not equivalent to the previous implementation.
##########
File path: flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/util/TempDirUtils.java
##########
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.util;
+
+import javax.annotation.Nonnull;
+
+import java.io.File;
+import java.io.IOException;
+import java.nio.file.Path;
+import java.util.UUID;
+
+/**
+ * Util class for implementing common functions in junit4 {@link org.junit.rules.TemporaryFolder},
+ * like newFolder() and newFile() for junit5 {@link org.junit.jupiter.api.io.TempDir}.
+ */
+public class TempDirUtils {
+
+ private TempDirUtils() {}
+
+ public static Path newFolderIn(@Nonnull Path baseTempPath) {
Review comment:
I'm not really sold on these tbh. From what I've seen most tests just to weird stuff making this often unnecessary. Explicitly defining the temp dirs for tests and passing them around in my mind makes it easier to understand what is actually done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on a change in pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on a change in pull request #18983:
URL: https://github.com/apache/flink/pull/18983#discussion_r825836428
##########
File path: flink-yarn/src/test/resources/META-INF/services/org.junit.jupiter.api.extension.Extension
##########
@@ -0,0 +1,16 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+org.apache.flink.util.TestLoggerExtension
Review comment:
@zentol I checked the module related about `test-jar`, there are `flink-yarn-test` and `flink-end-to-end-tests`.
May I change these modules in the same PR based the relationships ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18983:
URL: https://github.com/apache/flink/pull/18983#issuecomment-1059740356
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6352c8bf4468c666c5340e887500b68434c7529e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32563",
"triggerID" : "6352c8bf4468c666c5340e887500b68434c7529e",
"triggerType" : "PUSH"
}, {
"hash" : "3cfb40cab5eb51b3a53f758e91455c0fea3017d5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33061",
"triggerID" : "3cfb40cab5eb51b3a53f758e91455c0fea3017d5",
"triggerType" : "PUSH"
}, {
"hash" : "dc2782958966e92d3486cbebe25c65e3112cc04f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33115",
"triggerID" : "dc2782958966e92d3486cbebe25c65e3112cc04f",
"triggerType" : "PUSH"
}, {
"hash" : "d63719e7bb3bd0fc2eea856e5c5f6b099d5db93e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d63719e7bb3bd0fc2eea856e5c5f6b099d5db93e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dc2782958966e92d3486cbebe25c65e3112cc04f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33115)
* d63719e7bb3bd0fc2eea856e5c5f6b099d5db93e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18983:
URL: https://github.com/apache/flink/pull/18983#issuecomment-1059740356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18983:
URL: https://github.com/apache/flink/pull/18983#issuecomment-1059740356
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6352c8bf4468c666c5340e887500b68434c7529e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6352c8bf4468c666c5340e887500b68434c7529e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6352c8bf4468c666c5340e887500b68434c7529e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18983:
URL: https://github.com/apache/flink/pull/18983#issuecomment-1059740356
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6352c8bf4468c666c5340e887500b68434c7529e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32563",
"triggerID" : "6352c8bf4468c666c5340e887500b68434c7529e",
"triggerType" : "PUSH"
}, {
"hash" : "3cfb40cab5eb51b3a53f758e91455c0fea3017d5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33061",
"triggerID" : "3cfb40cab5eb51b3a53f758e91455c0fea3017d5",
"triggerType" : "PUSH"
}, {
"hash" : "dc2782958966e92d3486cbebe25c65e3112cc04f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33115",
"triggerID" : "dc2782958966e92d3486cbebe25c65e3112cc04f",
"triggerType" : "PUSH"
}, {
"hash" : "d63719e7bb3bd0fc2eea856e5c5f6b099d5db93e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33295",
"triggerID" : "d63719e7bb3bd0fc2eea856e5c5f6b099d5db93e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dc2782958966e92d3486cbebe25c65e3112cc04f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33115)
* d63719e7bb3bd0fc2eea856e5c5f6b099d5db93e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33295)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18983:
URL: https://github.com/apache/flink/pull/18983#issuecomment-1059740356
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6352c8bf4468c666c5340e887500b68434c7529e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32563",
"triggerID" : "6352c8bf4468c666c5340e887500b68434c7529e",
"triggerType" : "PUSH"
}, {
"hash" : "3cfb40cab5eb51b3a53f758e91455c0fea3017d5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33061",
"triggerID" : "3cfb40cab5eb51b3a53f758e91455c0fea3017d5",
"triggerType" : "PUSH"
}, {
"hash" : "dc2782958966e92d3486cbebe25c65e3112cc04f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33115",
"triggerID" : "dc2782958966e92d3486cbebe25c65e3112cc04f",
"triggerType" : "PUSH"
}, {
"hash" : "d63719e7bb3bd0fc2eea856e5c5f6b099d5db93e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33295",
"triggerID" : "d63719e7bb3bd0fc2eea856e5c5f6b099d5db93e",
"triggerType" : "PUSH"
}, {
"hash" : "b4c5cba226ee2335eb45e66c71a016260958b9d3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33429",
"triggerID" : "b4c5cba226ee2335eb45e66c71a016260958b9d3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b4c5cba226ee2335eb45e66c71a016260958b9d3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33429)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on a change in pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on a change in pull request #18983:
URL: https://github.com/apache/flink/pull/18983#discussion_r825836428
##########
File path: flink-yarn/src/test/resources/META-INF/services/org.junit.jupiter.api.extension.Extension
##########
@@ -0,0 +1,16 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+org.apache.flink.util.TestLoggerExtension
Review comment:
@zentol I checked the modules related about `test-jar` in `flink-yarn`, there are `flink-yarn-test` and `flink-end-to-end-tests`.
May I change these modules in the same PR based the relationships ?
And `flink-yarn-test` is [here](https://github.com/apache/flink/pull/18986).
I'll check pull/18986 based on comments in the PR before the review on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18983:
URL: https://github.com/apache/flink/pull/18983#issuecomment-1059740356
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6352c8bf4468c666c5340e887500b68434c7529e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32563",
"triggerID" : "6352c8bf4468c666c5340e887500b68434c7529e",
"triggerType" : "PUSH"
}, {
"hash" : "3cfb40cab5eb51b3a53f758e91455c0fea3017d5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33061",
"triggerID" : "3cfb40cab5eb51b3a53f758e91455c0fea3017d5",
"triggerType" : "PUSH"
}, {
"hash" : "dc2782958966e92d3486cbebe25c65e3112cc04f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33115",
"triggerID" : "dc2782958966e92d3486cbebe25c65e3112cc04f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dc2782958966e92d3486cbebe25c65e3112cc04f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33115)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18983:
URL: https://github.com/apache/flink/pull/18983#issuecomment-1059740356
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6352c8bf4468c666c5340e887500b68434c7529e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32563",
"triggerID" : "6352c8bf4468c666c5340e887500b68434c7529e",
"triggerType" : "PUSH"
}, {
"hash" : "3cfb40cab5eb51b3a53f758e91455c0fea3017d5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33061",
"triggerID" : "3cfb40cab5eb51b3a53f758e91455c0fea3017d5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6352c8bf4468c666c5340e887500b68434c7529e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32563)
* 3cfb40cab5eb51b3a53f758e91455c0fea3017d5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33061)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on a change in pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on a change in pull request #18983:
URL: https://github.com/apache/flink/pull/18983#discussion_r825836428
##########
File path: flink-yarn/src/test/resources/META-INF/services/org.junit.jupiter.api.extension.Extension
##########
@@ -0,0 +1,16 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+org.apache.flink.util.TestLoggerExtension
Review comment:
@zentol I checked the modules related about `test-jar` in `flink-yarn`, there are `flink-yarn-test` and `flink-end-to-end-tests`.
May I change these modules in the same PR based the relationships ?
And `flink-yarn-test` is [here](https://github.com/apache/flink/pull/18986)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #18983:
URL: https://github.com/apache/flink/pull/18983#issuecomment-1059944331
Hi, @leonardBang could you help me to review this patch ? Thank you very much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18983:
URL: https://github.com/apache/flink/pull/18983#issuecomment-1059740356
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6352c8bf4468c666c5340e887500b68434c7529e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32563",
"triggerID" : "6352c8bf4468c666c5340e887500b68434c7529e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6352c8bf4468c666c5340e887500b68434c7529e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32563)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org